Issue metadata
Sign in to add a comment
|
Move TrayAccessibilityTest to ash and make them work with UnifiedSystemTray |
||||||||||||||||||||||||
Issue descriptionUnifiedSystemTray is a new system tray. (Design doc: go/cros-qs-restyling) UnifiedSystemTray class will completely replace old SystemTray class and SystemTrayItem classes. TrayAccessibilityTest will also be removed and only the detailed view will be reused. The typical workflow of fixing browser tests for UnifiedSystemTray is first porting the tests to Mash using SystemTrayTestApi, because it works as common interface for both old and new SystemTrays. However, TrayAccessibilityTest will be moved to ash_unittests, we can just wait necessary methods to be moved to ash, and then move these tests to ash/, rather than rewrite TrayAccessibilityTest using SystemTrayTestApi.
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b83e531f7182432ab3a5a5ca9ee92cf900aad06 commit 8b83e531f7182432ab3a5a5ca9ee92cf900aad06 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Jun 07 01:26:23 2018 Disable a11y SystemTray browser tests. This CL disables TrayAccessibilityTest. It's better to be fixed after AccessibilityManager is moved to ash/. TEST=browser_tests --enable-features=SystemTrayUnified BUG= 847104 , 850014 Change-Id: Idde44ac1b5aada8999c9cfca8b435c5e6d1615ab Reviewed-on: https://chromium-review.googlesource.com/1086892 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#565134} [modify] https://crrev.com/8b83e531f7182432ab3a5a5ca9ee92cf900aad06/chrome/browser/chromeos/DEPS [modify] https://crrev.com/8b83e531f7182432ab3a5a5ca9ee92cf900aad06/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
,
Jun 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8c75e020348f855af97dd96a99fe5cd95bc46eb commit b8c75e020348f855af97dd96a99fe5cd95bc46eb Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Sat Jun 09 02:10:18 2018 Unified: Restore a11y detailed view ash_unittests. This CL restores TrayAccessibilityTest.CheckMenuVIsibilityOnDetailMenu on UnifiedSystemTray. The detailed view is also used in UnifiedSystemTray and should not depend on old SystemTray. TEST=ash_unittests (--enable-features=SystemTrayUnified) BUG= 850014 Change-Id: Id0a525147815e242decfa7c09c27fb829622e1af Reviewed-on: https://chromium-review.googlesource.com/1092623 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#565820} [modify] https://crrev.com/b8c75e020348f855af97dd96a99fe5cd95bc46eb/ash/system/tray_accessibility.h [modify] https://crrev.com/b8c75e020348f855af97dd96a99fe5cd95bc46eb/ash/system/tray_accessibility_unittest.cc
,
Aug 13
,
Oct 10
,
Oct 30
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a12026d872f65212b946b607ec49860563efcb1e commit a12026d872f65212b946b607ec49860563efcb1e Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Oct 31 02:42:05 2018 Port some a11y tests from browser to ash This CL ports following tests from browser to ash: * TrayAccessibilityTest.ClickDetailMenu * TrayAccessibilityTest.CheckMarksOnDetailMenu Other TrayAccessibilityTest browser_tests will be refactored to use SystemTrayTestApi mojo interface and kept on the browser side, because these tests are hard to do in ash unit tests. This CL also removes following tests: * TrayAccessibilityTest.ShowTrayIcon (browser_tests) * TrayAccessibilityTest.VisibilityFromMenu (ash_unittests) * TrayAccessibilityTest.VisibilityFromSettings (ash_unittests) * TrayAccessibilityLoginScreenTest.LoginStatus (ash_unittests) They either have the replacement in AccessibilityFeaturePodControllerTest, or simply the feature is removed. TEST=ash_unittests, browser_tests BUG= 850014 Change-Id: I4d7c8d99cb6ce5df9de4115d874fc56d7a0c276a Reviewed-on: https://chromium-review.googlesource.com/c/1306937 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#604119} [modify] https://crrev.com/a12026d872f65212b946b607ec49860563efcb1e/ash/system/accessibility/tray_accessibility_unittest.cc [modify] https://crrev.com/a12026d872f65212b946b607ec49860563efcb1e/ash/system/unified/unified_detailed_view_delegate.h [modify] https://crrev.com/a12026d872f65212b946b607ec49860563efcb1e/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4b210adbab7370af45db9d3ccc1b620ac5f0588 commit b4b210adbab7370af45db9d3ccc1b620ac5f0588 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Mon Nov 05 01:48:38 2018 Use SystemTrayTestApi in a11y browser tests. This CL restores disabled TrayAccessibilityTest browser tests by using SystemTrayTestApi mojo interface. Although now the style of the test is Mash compliant, it still doesn't work with Mash because some a11y features are not yet ported to Mash. TEST=browser_tests BUG= 850014 Change-Id: I25bc3ec4b7409eb97632e9b14fc91aedf8fed178 Reviewed-on: https://chromium-review.googlesource.com/c/1309554 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#605227} [modify] https://crrev.com/b4b210adbab7370af45db9d3ccc1b620ac5f0588/ash/public/cpp/ash_view_ids.h [modify] https://crrev.com/b4b210adbab7370af45db9d3ccc1b620ac5f0588/ash/public/interfaces/system_tray_test_api.mojom [modify] https://crrev.com/b4b210adbab7370af45db9d3ccc1b620ac5f0588/ash/system/accessibility/accessibility_feature_pod_controller.cc [modify] https://crrev.com/b4b210adbab7370af45db9d3ccc1b620ac5f0588/ash/system/accessibility/tray_accessibility.cc [modify] https://crrev.com/b4b210adbab7370af45db9d3ccc1b620ac5f0588/ash/system/tray/hover_highlight_view.h [modify] https://crrev.com/b4b210adbab7370af45db9d3ccc1b620ac5f0588/ash/system/tray/system_tray_test_api.cc [modify] https://crrev.com/b4b210adbab7370af45db9d3ccc1b620ac5f0588/ash/system/tray/system_tray_test_api.h [modify] https://crrev.com/b4b210adbab7370af45db9d3ccc1b620ac5f0588/ash/system/unified/unified_system_tray_test_api.cc [modify] https://crrev.com/b4b210adbab7370af45db9d3ccc1b620ac5f0588/ash/system/unified/unified_system_tray_test_api.h [modify] https://crrev.com/b4b210adbab7370af45db9d3ccc1b620ac5f0588/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc [modify] https://crrev.com/b4b210adbab7370af45db9d3ccc1b620ac5f0588/chrome/browser/ui/ash/system_tray_client_browsertest.cc [modify] https://crrev.com/b4b210adbab7370af45db9d3ccc1b620ac5f0588/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
,
Nov 5
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jamescook@chromium.org
, Jun 6 2018