Issue metadata
Sign in to add a comment
|
pointerup event not fired when using styles
Reported by
steven.o...@gmail.com,
Jun 6 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.62 Safari/537.36 Steps to reproduce the problem: 1. Place stylus on page 2. Lift styles 3. Dev console will not list pointerup event What is the expected behavior? pointerup to be sent What went wrong? pointerup is not fired Attachment contains a comparison of all pointer events (except for pointermove). In v66 en v67 Did this work before? Yes 66.0.3359 Does this work in other browsers? Yes Chrome version: 67.0.3396.62 Channel: stable OS Version: 10.0 Flash Version: Reproducible on MS Surface Pro 4 with stylus and generic touch display with active pen
,
Jun 6 2018
I don't believe this is a stable blocker bug. I'll take a closer look to see what caused this as I had fixed a similar issue a few releases back.
,
Jun 6 2018
Lan, would you be able to take a look at this whenever you get a chance. It seems to be related that hover bit we talked about.
,
Jun 6 2018
Sure, I will start it today.
,
Jun 7 2018
,
Jun 11 2018
,
Jun 12 2018
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fed11438f82f3bfa04702c06b6399fcfe5b60b2b commit fed11438f82f3bfa04702c06b6399fcfe5b60b2b Author: lanwei <lanwei@chromium.org> Date: Tue Jun 19 15:37:09 2018 Send PointerUp event when using stylus on Windows After we changed to use ui::TouchEvent to represent stylus input instead of ui::MouseEvent, we should not set its flag to left button or right button when we press or release the pen on the tablet or any button on the pen. Bug: 850011 Change-Id: I2c2dc11e2cc625691aee11c14f28e632e0c15df3 Reviewed-on: https://chromium-review.googlesource.com/1099876 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Ella Ge <eirage@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#568461} [modify] https://crrev.com/fed11438f82f3bfa04702c06b6399fcfe5b60b2b/ui/views/win/pen_event_processor.cc [modify] https://crrev.com/fed11438f82f3bfa04702c06b6399fcfe5b60b2b/ui/views/win/pen_event_processor_unittest.cc
,
Jun 20 2018
Reporter we landed a fix for this. We wanted to also merge this in 68 to make sure we have the fix sooner. Could you verify your use case with the latest Canary and see whether it is fixed. It should be in any Canary after 69.0.3466.0.
,
Jun 20 2018
Just tested it and it works now! Attached the html file I used for the test. Chrome version: 69.0.3466.0 canary OS version: Windows NT: 10.0.17134 Device: Surface Pro 4 Just one more thing: previously a 'pointermove' event with e.button=0 was fired instead of the corresponding 'pointerup'. This 'pointermove' event is not fired anymore.
,
Jun 20 2018
The missing 'pointerup' event was converted to the 'pointermove' event. You are right, we are not firing this 'pointermove' anymore.
,
Jun 21 2018
,
Jun 21 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 21 2018
Thanks for the fix. Can you please comment on how safe this merge is overall, chances of introducing new regressions? Why is this critical for M68 vs waiting until M69?
,
Jun 21 2018
I think this fix is really safe, and it would not cause any more regression, because it changes a small part of the code. Because it fixed an issue which is critical to web users, we think it should be on the stable chrome as early as possible. Thank you.
,
Jun 21 2018
Yeah, we've been receiving reports of this from our users as well and it'd be great to have a fix out ASAP. Thanks
,
Jun 22 2018
Hi, I can confirm the initial issue is resolved by this fix. However issue 851457 , which was merged into this issue, is still present in the latest canary (69.0.3469.3)
,
Jun 22 2018
I unmarked that bug as duplicate and added comments over there.
,
Jun 22 2018
Sorry, I was not aware that Issue 851457 was merged to this one, which should be a totally different bug.
,
Jun 25 2018
Approving merge for M68. Branch:3440
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0907bc845ec5d38ddb074c8f0272aa0f5e23ed26 commit 0907bc845ec5d38ddb074c8f0272aa0f5e23ed26 Author: lanwei <lanwei@chromium.org> Date: Mon Jun 25 18:25:12 2018 Send PointerUp event when using stylus on Windows After we changed to use ui::TouchEvent to represent stylus input instead of ui::MouseEvent, we should not set its flag to left button or right button when we press or release the pen on the tablet or any button on the pen. TBR=lanwei@chromium.org (cherry picked from commit fed11438f82f3bfa04702c06b6399fcfe5b60b2b) Bug: 850011 Change-Id: I2c2dc11e2cc625691aee11c14f28e632e0c15df3 Reviewed-on: https://chromium-review.googlesource.com/1099876 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Ella Ge <eirage@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#568461} Reviewed-on: https://chromium-review.googlesource.com/1114058 Reviewed-by: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#511} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/0907bc845ec5d38ddb074c8f0272aa0f5e23ed26/ui/views/win/pen_event_processor.cc [modify] https://crrev.com/0907bc845ec5d38ddb074c8f0272aa0f5e23ed26/ui/views/win/pen_event_processor_unittest.cc
,
Jul 3
,
Jul 15
I am using a surfacebook 2 with the stylus. The pointerdown and pointerup event are not fired for the eraser button.
,
Jul 17
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by phanindra.mandapaka@chromium.org
, Jun 6 2018Components: Blink>Input
Labels: -Pri-2 ReleaseBlock-Stable Triaged-ET RegressedIn-67 M-67 Target-67 FoundIn-67 Target-68 Target-69 FoundIn-69 FoundIn-68 hasbisect Pri-1
Owner: nzolghadr@chromium.org
Status: Assigned (was: Unconfirmed)