New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850011 link

Starred by 13 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

pointerup event not fired when using styles

Reported by steven.o...@gmail.com, Jun 6 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.62 Safari/537.36

Steps to reproduce the problem:
1. Place stylus on page
2. Lift styles
3. Dev console will not list pointerup event

What is the expected behavior?
pointerup to be sent

What went wrong?
pointerup is not fired

Attachment contains a comparison of all pointer events (except for pointermove). In v66 en v67

Did this work before? Yes 66.0.3359

Does this work in other browsers? Yes

Chrome version: 67.0.3396.62  Channel: stable
OS Version: 10.0
Flash Version: 

Reproducible on MS Surface Pro 4 with stylus and generic touch display with active pen
 
pointerupissue.zip
10.4 KB Download
pointerupmissing.PNG
11.5 KB View Download
Cc: phanindra.mandapaka@chromium.org
Components: Blink>Input
Labels: -Pri-2 ReleaseBlock-Stable Triaged-ET RegressedIn-67 M-67 Target-67 FoundIn-67 Target-68 Target-69 FoundIn-69 FoundIn-68 hasbisect Pri-1
Owner: nzolghadr@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported chrome & chromium versions 67.0.3396.62  & latest chrome 69.0.3451.0 using Windows10 MS Surface Pro 4 with stylus.Hence providing the bisect information below.

Note: While running tool bisect invoked builds are crashing hence checked manually for the suspect.

Bisect Info:
================
Good build: 66.0.3359.181
Bad build: 67.0.3360.0

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/66.0.3359.0..67.0.3360.0?pretty=fuller&n=10000

suspect: https://chromium-review.googlesource.com/c/chromium/src/+/929861

Reviewed-on: Reviewed-on: https://chromium-review.googlesource.com/929861

nzolghadr@: Please confirm the issue and help in re-assigning if it is not related to your change.

Thanks!
Labels: -ReleaseBlock-Stable -Target-67
I don't believe this is a stable blocker bug. I'll take a closer look to see what caused this as I had fixed a similar issue a few releases back.
Cc: nzolghadr@chromium.org
Owner: lanwei@chromium.org
Lan, would you be able to take a look at this whenever you get a chance. It seems to be related that hover bit we talked about.
Sure, I will start it today.
Status: Started (was: Assigned)
Cc: vamshi.kommuri@chromium.org
 Issue 851314  has been merged into this issue.
Cc: krajshree@chromium.org
 Issue 851457  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fed11438f82f3bfa04702c06b6399fcfe5b60b2b

commit fed11438f82f3bfa04702c06b6399fcfe5b60b2b
Author: lanwei <lanwei@chromium.org>
Date: Tue Jun 19 15:37:09 2018

Send PointerUp event when using stylus on Windows

After we changed to use ui::TouchEvent to represent stylus input instead
of ui::MouseEvent, we should not set its flag to left button or right
button when we press or release the pen on the tablet or any button on
the pen.


Bug:  850011 
Change-Id: I2c2dc11e2cc625691aee11c14f28e632e0c15df3
Reviewed-on: https://chromium-review.googlesource.com/1099876
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568461}
[modify] https://crrev.com/fed11438f82f3bfa04702c06b6399fcfe5b60b2b/ui/views/win/pen_event_processor.cc
[modify] https://crrev.com/fed11438f82f3bfa04702c06b6399fcfe5b60b2b/ui/views/win/pen_event_processor_unittest.cc

Reporter we landed a fix for this. We wanted to also merge this in 68 to make sure we have the fix sooner. Could you verify your use case with the latest Canary and see whether it is fixed. It should be in any Canary after 69.0.3466.0.
Just tested it and it works now! Attached the html file I used for the test.

Chrome version: 69.0.3466.0 canary
OS version: Windows NT: 10.0.17134
Device: Surface Pro 4

Just one more thing: previously a 'pointermove' event with e.button=0 was fired instead of the corresponding 'pointerup'. This 'pointermove' event is not fired anymore.


PenPointerUpChromeSurface.html
1.4 KB View Download

Comment 11 by lanwei@google.com, Jun 20 2018

The missing 'pointerup' event was converted to the 'pointermove' event. You are right, we are not firing this 'pointermove' anymore.
Labels: Merge-Request-68
Project Member

Comment 13 by sheriffbot@chromium.org, Jun 21 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks for the fix. Can you please comment on how safe this merge is overall, chances of introducing new regressions? Why is this critical for M68 vs waiting until M69?
I think this fix is really safe, and it would not cause any more regression, because it changes a small part of the code. Because it fixed an issue which is critical to web users, we think it should be on the stable chrome as early as possible. Thank you.

Comment 16 by jor...@kamihq.com, Jun 21 2018

Yeah, we've been receiving reports of this from our users as well and it'd be great to have a fix out ASAP.

Thanks
Hi, I can confirm the initial issue is resolved by this fix.
However  issue 851457 , which was merged into this issue, is still present in the latest canary (69.0.3469.3)
I unmarked that bug as duplicate and added comments over there.
Sorry, I was not aware that  Issue 851457  was merged to this one, which should be a totally different bug.
Labels: -Merge-Review-68 Merge-Approved-68
Approving merge for M68. Branch:3440
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 25 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0907bc845ec5d38ddb074c8f0272aa0f5e23ed26

commit 0907bc845ec5d38ddb074c8f0272aa0f5e23ed26
Author: lanwei <lanwei@chromium.org>
Date: Mon Jun 25 18:25:12 2018

Send PointerUp event when using stylus on Windows

After we changed to use ui::TouchEvent to represent stylus input instead
of ui::MouseEvent, we should not set its flag to left button or right
button when we press or release the pen on the tablet or any button on
the pen.


TBR=lanwei@chromium.org

(cherry picked from commit fed11438f82f3bfa04702c06b6399fcfe5b60b2b)

Bug:  850011 
Change-Id: I2c2dc11e2cc625691aee11c14f28e632e0c15df3
Reviewed-on: https://chromium-review.googlesource.com/1099876
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#568461}
Reviewed-on: https://chromium-review.googlesource.com/1114058
Reviewed-by: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#511}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/0907bc845ec5d38ddb074c8f0272aa0f5e23ed26/ui/views/win/pen_event_processor.cc
[modify] https://crrev.com/0907bc845ec5d38ddb074c8f0272aa0f5e23ed26/ui/views/win/pen_event_processor_unittest.cc

Cc: lanwei@chromium.org viswa.karala@chromium.org
 Issue 857085  has been merged into this issue.
I am using a surfacebook 2 with the stylus. The pointerdown and pointerup event are not fired for the eraser button. 
Status: Fixed (was: Started)
For the eraser button, there is a separate issue,  Issue 851457 .

Sign in to add a comment