New issue
Advanced search Search tips

Issue 850000 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 538475
issue 850004



Sign in to add a comment

[css-logical] Flow relative margins, paddings and borders

Project Member Reported by r...@igalia.com, Jun 6 2018

Issue description

Spec: https://drafts.csswg.org/css-logical-1/#box

Implement margin-{block,inline}-{start,end}, padding-{block,inline}-{start,end} and
border-{block,inline}-{start,end}-{width,style,color}
using the standard names (currently they're already supported using
-webkit prefix and slightly different names).

Only longhands properties would be implemented as part of this,
the shorthands are not supported yet prefixed so they're left for a different issue.

The full list of properties would be: margin-block-start, margin-block-end,
margin-inline-start, margin-inline-end, padding-block-start, padding-block-end,
padding-inline-start, padding-inline-end, border-block-start-width, border-block-end-width,
border-inline-start-width, border-inline-end-width, border-block-start-style,
border-block-end-style, border-inline-start-style, border-inline-end-style,
border-block-start-color, border-block-end-color, border-inline-start-color,
border-inline-end-color.


 

Comment 1 by r...@igalia.com, Jun 6 2018

Cc: futhark@chromium.org
 Issue 812918  has been merged into this issue.
Woo bug number 850000 \o/

Comment 3 by r...@igalia.com, Jun 6 2018

Blocking: 850004

Comment 4 by r...@igalia.com, Jun 8 2018

Owner: obru...@igalia.com

Comment 5 by r...@igalia.com, Jun 8 2018

Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e697679eeb3e6c7c52832e68ae452f8122548d0

commit 3e697679eeb3e6c7c52832e68ae452f8122548d0
Author: Oriol Brufau <obrufau@igalia.com>
Date: Tue Jun 12 10:02:00 2018

[css-logical] Implement flow-relative margin longhand properties

These properties provide the author with the ability to control margins
through logical, rather than physical, direction and dimension mappings.

Intent to Implement and Ship:
CSS flow-relative margins, paddings and borders
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tkN-r119eNc

Spec: https://drafts.csswg.org/css-logical/#margin-properties

BUG= 850000 

TEST=external/wpt/css/css-logical/logical-box-margin.html

The test still has some failures because sideways writing modes have not
been implemented yet (http://crbug.com/680331).

Change-Id: I891c3bab3cd4ee810da0ed8e8fb907c141898817
Reviewed-on: https://chromium-review.googlesource.com/1075050
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#566367}
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-margin-expected.txt
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/get-set-stylesheet-text-expected.txt
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-utf8-bom-expected.txt
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/region-style-crash-expected.txt
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/selector-source-data-expected.txt
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/WebKit/LayoutTests/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/blink/public/mojom/use_counter/css_property_id.mojom
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/blink/renderer/core/css/BUILD.gn
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/blink/renderer/core/css/parser/css_proto_converter.cc
[rename] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/blink/renderer/core/css/properties/longhands/margin_block_end_custom.cc
[copy] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/blink/renderer/core/css/properties/longhands/margin_block_start_custom.cc
[copy] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/blink/renderer/core/css/properties/longhands/margin_inline_end_custom.cc
[copy] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/blink/renderer/core/css/properties/longhands/margin_inline_start_custom.cc
[delete] https://crrev.com/b5ffbeb6415d1aa747041e312d5222d67cee7a93/third_party/blink/renderer/core/css/properties/longhands/webkit_margin_before_custom.cc
[delete] https://crrev.com/b5ffbeb6415d1aa747041e312d5222d67cee7a93/third_party/blink/renderer/core/css/properties/longhands/webkit_margin_end_custom.cc
[delete] https://crrev.com/b5ffbeb6415d1aa747041e312d5222d67cee7a93/third_party/blink/renderer/core/css/properties/longhands/webkit_margin_start_custom.cc
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/blink/renderer/core/css/resolver/style_resolver.cc
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/blink/renderer/core/frame/use_counter.cc
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/third_party/blink/renderer/core/html/html_table_element.cc
[modify] https://crrev.com/3e697679eeb3e6c7c52832e68ae452f8122548d0/tools/metrics/histograms/enums.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef171a6dd4095e0790267d64677c51367e150425

commit ef171a6dd4095e0790267d64677c51367e150425
Author: Oriol Brufau <obrufau@igalia.com>
Date: Tue Jun 12 12:06:22 2018

[css-logical] Implement flow-relative padding longhand properties

These properties provide the author with the ability to control paddings
through logical, rather than physical, direction and dimension mappings.

Intent to Implement and Ship:
CSS flow-relative margins, paddings and borders
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tkN-r119eNc

Spec: https://drafts.csswg.org/css-logical/#padding-properties

BUG= 850000 

TEST=external/wpt/css/css-logical/logical-box-padding.html

The test still has some failures because sideways writing modes have not
been implemented yet (http://crbug.com/680331).

Change-Id: Ic76da56385f2ef8c9638f90c9a358e4874d7c338
Reviewed-on: https://chromium-review.googlesource.com/1091313
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#566386}
[modify] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-padding-expected.txt
[modify] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/WebKit/LayoutTests/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/blink/public/mojom/use_counter/css_property_id.mojom
[modify] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/blink/renderer/core/css/BUILD.gn
[modify] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
[modify] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/blink/renderer/core/css/parser/css_proto_converter.cc
[rename] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/blink/renderer/core/css/properties/longhands/padding_block_end_custom.cc
[copy] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/blink/renderer/core/css/properties/longhands/padding_block_start_custom.cc
[copy] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/blink/renderer/core/css/properties/longhands/padding_inline_end_custom.cc
[copy] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/blink/renderer/core/css/properties/longhands/padding_inline_start_custom.cc
[delete] https://crrev.com/72648da9df0395c2b753ed85964b34b061bde37f/third_party/blink/renderer/core/css/properties/longhands/webkit_padding_after_custom.cc
[delete] https://crrev.com/72648da9df0395c2b753ed85964b34b061bde37f/third_party/blink/renderer/core/css/properties/longhands/webkit_padding_end_custom.cc
[delete] https://crrev.com/72648da9df0395c2b753ed85964b34b061bde37f/third_party/blink/renderer/core/css/properties/longhands/webkit_padding_start_custom.cc
[modify] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/third_party/blink/renderer/core/frame/use_counter.cc
[modify] https://crrev.com/ef171a6dd4095e0790267d64677c51367e150425/tools/metrics/histograms/enums.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3ccbca2c8b0497f620366bfeae6947a2239760b

commit b3ccbca2c8b0497f620366bfeae6947a2239760b
Author: Oriol Brufau <obrufau@igalia.com>
Date: Thu Jun 28 00:18:47 2018

[css-logical] Implement flow-relative border longhand properties

These properties provide the author with the ability to control borders
through logical, rather than physical, direction and dimension mappings.

Intent to Implement and Ship:
CSS flow-relative margins, paddings and borders
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tkN-r119eNc

Spec: https://drafts.csswg.org/css-logical/#border-properties

BUG= 850000 

TEST=external/wpt/css/css-logical/logical-box-border-color.html
TEST=external/wpt/css/css-logical/logical-box-border-style.html
TEST=external/wpt/css/css-logical/logical-box-border-width.html

The tests still have some failures because sideways writing modes have
not been implemented yet (http://crbug.com/680331).

Change-Id: Ide70c65777ed42e9ef34fbcb2f58ef85f62bad4c
Reviewed-on: https://chromium-review.googlesource.com/1092695
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#570965}
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-border-color-expected.txt
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-border-style-expected.txt
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-border-width-expected.txt
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/WebKit/LayoutTests/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/public/mojom/use_counter/css_property_id.mojom
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/BUILD.gn
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/parser/css_proto_converter.cc
[rename] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/properties/longhands/border_block_end_color_custom.cc
[copy] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/properties/longhands/border_block_end_width_custom.cc
[copy] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/properties/longhands/border_block_start_color_custom.cc
[copy] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/properties/longhands/border_block_start_width_custom.cc
[copy] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/properties/longhands/border_inline_end_color_custom.cc
[copy] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/properties/longhands/border_inline_end_width_custom.cc
[copy] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/properties/longhands/border_inline_start_color_custom.cc
[rename] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/properties/longhands/border_inline_start_width_custom.cc
[delete] https://crrev.com/18aedf278c1a57b3a1d5a6ee68c011d1e206aa84/third_party/blink/renderer/core/css/properties/longhands/webkit_border_after_width_custom.cc
[delete] https://crrev.com/18aedf278c1a57b3a1d5a6ee68c011d1e206aa84/third_party/blink/renderer/core/css/properties/longhands/webkit_border_before_color_custom.cc
[delete] https://crrev.com/18aedf278c1a57b3a1d5a6ee68c011d1e206aa84/third_party/blink/renderer/core/css/properties/longhands/webkit_border_before_width_custom.cc
[delete] https://crrev.com/18aedf278c1a57b3a1d5a6ee68c011d1e206aa84/third_party/blink/renderer/core/css/properties/longhands/webkit_border_end_color_custom.cc
[delete] https://crrev.com/18aedf278c1a57b3a1d5a6ee68c011d1e206aa84/third_party/blink/renderer/core/css/properties/longhands/webkit_border_start_color_custom.cc
[delete] https://crrev.com/18aedf278c1a57b3a1d5a6ee68c011d1e206aa84/third_party/blink/renderer/core/css/properties/longhands/webkit_border_start_width_custom.cc
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/css/resolver/style_resolver.cc
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/frame/use_counter.cc
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/third_party/blink/renderer/core/layout/layout_table_cell.cc
[modify] https://crrev.com/b3ccbca2c8b0497f620366bfeae6947a2239760b/tools/metrics/histograms/enums.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8afe728f7ad2dd99ee78604ba73e6d42fe72b038

commit 8afe728f7ad2dd99ee78604ba73e6d42fe72b038
Author: Oriol Brufau <obrufau@igalia.com>
Date: Fri Jun 29 20:29:31 2018

[css-logical] Implement some flow-relative border shorthand properties

These properties provide the author with the ability to control borders
through logical, rather than physical, direction and dimension mappings.

The patch only adds 'border-block-start', 'border-block-end',
'border-inline-start' and 'border-inline-end'. The other flow-relative
border shorthands will be implemented behind a flag in another patch.

Intent to Implement and Ship:
CSS flow-relative margins, paddings and borders
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tkN-r119eNc

Spec: https://drafts.csswg.org/css-logical/#border-shorthands

BUG= 850000 

TEST=external/wpt/css/css-logical/logical-box-border-shorthands.html

The test still has some failures because sideways writing modes have
not been implemented yet (http://crbug.com/680331).

Change-Id: If186e1bd9826a24bce2d7ca5a4a58b0051cd5ece
Reviewed-on: https://chromium-review.googlesource.com/1117185
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571615}
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-border-shorthands-expected.txt
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/WebKit/LayoutTests/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/blink/public/mojom/use_counter/css_property_id.mojom
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/blink/renderer/core/css/BUILD.gn
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/blink/renderer/core/css/parser/css_proto_converter.cc
[copy] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/blink/renderer/core/css/properties/shorthands/border_block_end_custom.cc
[copy] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/blink/renderer/core/css/properties/shorthands/border_block_start_custom.cc
[rename] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/blink/renderer/core/css/properties/shorthands/border_inline_end_custom.cc
[rename] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/blink/renderer/core/css/properties/shorthands/border_inline_start_custom.cc
[delete] https://crrev.com/35e3eed7609b25cc60f3b5e657eae9c11af6a17b/third_party/blink/renderer/core/css/properties/shorthands/webkit_border_before_custom.cc
[delete] https://crrev.com/35e3eed7609b25cc60f3b5e657eae9c11af6a17b/third_party/blink/renderer/core/css/properties/shorthands/webkit_border_start_custom.cc
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/blink/renderer/core/css/resolver/style_resolver.cc
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/blink/renderer/core/css/style_property_serializer.cc
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/third_party/blink/renderer/core/frame/use_counter.cc
[modify] https://crrev.com/8afe728f7ad2dd99ee78604ba73e6d42fe72b038/tools/metrics/histograms/enums.xml

Comment 10 by obru...@igalia.com, Jun 29 2018

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72107012d6ed8fe70cbbf20198eeea6820d015a7

commit 72107012d6ed8fe70cbbf20198eeea6820d015a7
Author: Oriol Brufau <obrufau@igalia.com>
Date: Tue Jul 24 00:18:05 2018

[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in /ui/webui

 Bug 850000  added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch replaces all the
uses in /ui/webeui

Spec: https://drafts.csswg.org/css-logical/#box

BUG=862141

Change-Id: I9c77c4374bef006fa518eba96f10db8e9bc9c2eb
Reviewed-on: https://chromium-review.googlesource.com/1146930
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#577360}
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_components/certificate_manager/certificate_shared_css.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_components/certificate_manager/certificate_subentry.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_components/chromeos/network/network_nameservers.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_components/chromeos/network/network_property_list.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_components/chromeos/network/network_proxy.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/chromeos/network/cr_network_list_item.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/cr_drawer/cr_drawer.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/cr_input/cr_input_style_css.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/cr_radio_button/cr_radio_button_style_css.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/cr_toast/cr_toast.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/paper_button_style_css.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/cr_elements/shared_vars_css.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/css/apps/topbutton_bar.css
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/css/bubble.css
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/css/bubble_button.css
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/css/chrome_shared.css
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/css/controlled_indicator.css
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/css/dialogs.css
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/css/menu.css
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/css/overlay.css
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/css/table.css
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/css/tabs.css
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/css/tree.css
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/css/widgets.css
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/html/md_select_css.html
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/js/cr/ui/page_manager/page_manager.js
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/js/cr/ui/table/table_header.js
[modify] https://crrev.com/72107012d6ed8fe70cbbf20198eeea6820d015a7/ui/webui/resources/js/cr/ui/tree.js

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515

commit e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515
Author: Oriol Brufau <obrufau@igalia.com>
Date: Tue Jul 24 14:36:57 2018

[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in /third_party/WebKit/LayoutTests

 Bug 850000  added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch replaces all the
uses in /third_party/WebKit/LayoutTests, except that the original
fast/css/logical-property-resolution.html is preserved in a new test
logical-property-resolution-webkit-prefix.html to ensure that prefixed
properties continue working.

Spec: https://drafts.csswg.org/css-logical/#box

BUG=862141

Change-Id: I3090713fc6fbe507a19724cca4f6ca69bcaf5eb9
Reviewed-on: https://chromium-review.googlesource.com/1147523
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#577530}
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/css-parser/unitless-length-quirk.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/css3/flexbox/flex-flow-2.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/css3/flexbox/flex-flow-auto-margins.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/css3/flexbox/flex-flow-border.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/css3/flexbox/flex-flow-margins.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/css3/flexbox/flex-flow-padding.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/css3/flexbox/flex-flow.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/css3/flexbox/multiline-align-self.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/css3/flexbox/multiline-justify-content.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/css3/flexbox/negative-flex-rounding-assert.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/css3/flexbox/writing-modes.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/editing/deleting/delete-blockquote-large-offsets.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-word-visually-crash-test-5.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/editing/text-iterator/first_letter_find_string_crash.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox/position-absolute-001.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/backgrounds/bug420029.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/block/float/overhanging-float-crashes-when-sibling-becomes-formatting-context.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/block/margin-collapse/self-collapsing-block-discards-margin.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/block/positioning/vertical-lr/003.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/block/positioning/vertical-lr/004.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/block/positioning/vertical-rl/003.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/block/positioning/vertical-rl/004.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/borders/border-styles-split.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/border-start-end-expected.txt
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/crash-inherit-value-font-family.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/fontMetric-webkit-border-end-width-null-crash.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/identical-logical-height-decl.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/inherit-initial-shorthand-values-expected.txt
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/inherit-initial-shorthand-values.html
[add] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/logical-property-resolution-webkit-prefix-expected.txt
[add] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/logical-property-resolution-webkit-prefix.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/logical-property-resolution.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/margin-start-end-expected.txt
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/padding-start-end-expected.txt
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/parsing-color-quirk-expected.txt
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/parsing-color-quirk.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/script-tests/border-start-end.js
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/script-tests/margin-start-end.js
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/script-tests/padding-start-end.js
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/style-resolver-cache-direction-1.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/style-resolver-cache-direction-2.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/style-resolver-cache-direction-3.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/css/window-internals-isCSSPropertyUseCounted.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-change-before-text-node.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-change-child-node.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-change-text-form-control.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-change-text.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-children.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-remove-add-children.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dom/HTMLElement/attr-dir-auto-text-form-control.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dom/HTMLElement/attr-dir-auto.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dom/HTMLElement/attr-dir-value-change.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dom/shadow/attr-dir-inherit.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dynamic/crash-paint-no-documentElement-renderer-expected.txt
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/dynamic/crash-paint-no-documentElement-renderer.html-disabled
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/html/layout-runs-and-floats-crash.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/multicol/hit-test-end-of-column-with-line-height.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/multicol/newmulticol/hide-box-vertical-lr-expected.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/multicol/newmulticol/hide-box-vertical-lr.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/multicol/newmulticol/hide-box-vertical-rl-expected.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/multicol/newmulticol/hide-box-vertical-rl.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/multicol/overflow-content-expected.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/multicol/overflow-content.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/multicol/pageLogicalOffset-vertical.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/rules-with-border-before.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/float-truncation.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/rules-with-border-before.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/ruby/position-after.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/table/border-collapsing/001-vertical.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/table/border-collapsing/border-collapsing-head-foot-vertical.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/table/border-collapsing/equal-precedence-resolution-vertical.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/table/border-collapsing/rtl-border-collapsing-vertical.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/table/fixed-with-auto-with-colspan-vertical.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/text/decorations-with-text-combine.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/text/dirty-inline-textbox-crash.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/text/justify-vertical-expected.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/text/justify-vertical.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/Kusa-Makura-background-canvas.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/block-level-images.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/border-radius-clipping-vertical-lr.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/border-styles-vertical-lr.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/border-styles-vertical-rl.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/fieldsets.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/flipped-blocks-text-map-local-to-container.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/logical-height-after-clear-expected.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/logical-height-after-clear.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-inline-block.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/root-lr-basic.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/vertical-lr-replaced-selection.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/fast/writing-mode/vertical-rl-replaced-selection.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/http/tests/csspaint/invalidation-background-image.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/http/tests/csspaint/resources/test-runner-invalidation-logging.js
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/images/mask-box-image-crash.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/paint/transparency/compositing-alpha-fold-crash.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/scrollbars/scrollbar-part-created-with-no-parent-crash.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/scrollbars/scrollbar-percent-padding-crash.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/svg/as-image/svg-intrinsic-size-rectangular-vertical-expected.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/svg/as-image/svg-intrinsic-size-rectangular-vertical.html
[modify] https://crrev.com/e88a3b6a7dd1bbfc4d8f64e4b9148adce5f1b515/third_party/WebKit/LayoutTests/touchadjustment/small-target-test.html

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf

commit c6c32fb4b7188a509b8d9fdf39e2c793484d15bf
Author: Oriol Brufau <obrufau@igalia.com>
Date: Tue Jul 24 20:53:06 2018

[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in /chrome/browser/

 Bug 850000  added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch replaces all the
uses in /chrome/browser/.
This should fix  bug 866783 , resulting from a previous replacement of
prefixed properties only in /ui/webui/, because /chrome/ still uses
prefixed properties and the inconsistency broke some CSS mixins.

Spec: https://drafts.csswg.org/css-logical/#box

BUG=862141

Change-Id: I73837ed67359b332dfe354d8902a6eff7ed7fede
Reviewed-on: https://chromium-review.googlesource.com/1148579
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#577673}
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/about_sys/about_sys.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/bluetooth_internals/bluetooth_internals.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/certificate_viewer.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/assistant_optin/assistant_confirm_reject.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/assistant_optin/assistant_get_more.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/assistant_optin/assistant_loading.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/assistant_optin/assistant_ready.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/assistant_optin/assistant_third_party.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/assistant_optin/assistant_value_prop.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/emulator/input_device_settings.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/emulator/shared_styles.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/first_run/app/style.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/first_run/step.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/guest_session_tab.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/internet_detail_dialog/internet_detail_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/accessibility_menu.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/apps_menu.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/arc_terms_of_service.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/discover/discover_welcome.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/encryption_migration.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/gaia_password_changed.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/header_bar.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/md_header_bar.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/md_top_header_bar.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/offline_ad_login.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_back_button.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_change_picture.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_eula.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_hid_detection.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_next_button.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_popup_overlay.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_reset.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_reset_confirmation_overlay.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_screen.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_screen_user_image.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/oobe_welcome_secondary_button.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/recommend_apps.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/screen_app_launch_splash.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/screen_arc_kiosk_splash.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/login/sync_consent.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/mobile_dialogs.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/mobile_setup.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/neterror.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/set_time.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/components.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/conflicts/about_conflicts.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/device_log_ui/device_log_ui.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/discards/discards.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/feedback/css/feedback.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/inspect/inspect.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/local_discovery/local_discovery.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/local_ntp/local_ntp.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_bookmarks/app.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_bookmarks/dnd_chip.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_bookmarks/item.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/code_section.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/error_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/install_warnings_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/keyboard_shortcuts.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/kiosk_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/load_error.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/options_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/pack_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/sidebar.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/toggle_row.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_extensions/toolbar.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_history/history.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_history/history_item.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_history/shared_style.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_history/side_bar.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_history/synced_device_card.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_user_manager/control_bar.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_user_manager/create_profile.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_user_manager/user_manager.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/md_user_manager/user_manager_tutorial.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/media_router/elements/route_controls/route_controls.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/media_router/elements/route_details/route_details.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/ntp4/incognito_tab.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/ntp4/nav_dot.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/ntp4/new_tab.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/policy.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/policy_android.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/policy_common.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/advanced_settings_item.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/button_css.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/checkbox_radio_css.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/destination_list_item.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/header.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/search_dialog_css.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/select_css.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/new/settings_section.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/print_preview.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/search/destination_list.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/search/destination_list_item.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/search/destination_search.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/settings/destination_settings.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/settings/page_settings.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/print_preview/settings/settings_box.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/set_as_default_browser.css
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/a11y_page/tts_subpage.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/about_page/detailed_build_info.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/change_password_page/change_password_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/controls/controlled_button.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/controls/controlled_radio_button.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/controls/extension_controlled_indicator.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/controls/settings_checkbox.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/controls/settings_slider.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/date_time_page/timezone_subpage.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/device_page/display_size_slider.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/device_page/pointers.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/device_page/storage.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/internet_page/internet_shared_css.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/internet_page/internet_subpage.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/internet_page/network_proxy_section.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/multidevice_page/multidevice_feature_item.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/people_page/change_picture.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/people_page/sync_account_control.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/people_page/user_list.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/people_page/users_page.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/printing_page/cups_printer_shared_css.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/privacy_page/personalization_options.html
[modify] https://crrev.com/c6c32fb4b7188a509b8d9fdf39e2c793484d15bf/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/c6c32fb4
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0446e3f79dfc2bf89c71994be68fe0ee65c1474

commit c0446e3f79dfc2bf89c71994be68fe0ee65c1474
Author: Oriol Brufau <obrufau@igalia.com>
Date: Tue Jul 24 22:32:57 2018

[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in styleguide, and add check to avoid future uses

 Bug 850000  added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch updates the style
guide so that it refers to the standard properties, and adds a new CSS
presubmit check to ensure that the prefixed properties are not added
back anywhere.

Spec: https://drafts.csswg.org/css-logical/#box

BUG=862141

Change-Id: I50166e5bf13259302eb02aaa16ec299c9b2a4b0a
Reviewed-on: https://chromium-review.googlesource.com/1147524
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#577715}
[modify] https://crrev.com/c0446e3f79dfc2bf89c71994be68fe0ee65c1474/styleguide/web/web.md
[modify] https://crrev.com/c0446e3f79dfc2bf89c71994be68fe0ee65c1474/tools/web_dev_style/css_checker.py
[modify] https://crrev.com/c0446e3f79dfc2bf89c71994be68fe0ee65c1474/tools/web_dev_style/css_checker_test.py

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dc39c2c4fdfd92d30701a9292e35d0a8c1306f7

commit 1dc39c2c4fdfd92d30701a9292e35d0a8c1306f7
Author: Oriol Brufau <obrufau@igalia.com>
Date: Wed Jul 25 15:39:50 2018

[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in /chrome/common

 Bug 850000  added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch replaces all the
uses in /chrome/common

Spec: https://drafts.csswg.org/css-logical/#box

BUG=862141

Change-Id: Ic8ec1308146f68a7c1bf82f850361adb3b4b63f8
Reviewed-on: https://chromium-review.googlesource.com/1150025
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#577905}
[modify] https://crrev.com/1dc39c2c4fdfd92d30701a9292e35d0a8c1306f7/chrome/common/extensions/docs/examples/api/fontSettings/css/chrome_shared.css
[modify] https://crrev.com/1dc39c2c4fdfd92d30701a9292e35d0a8c1306f7/chrome/common/extensions/docs/examples/api/fontSettings/css/overlay.css
[modify] https://crrev.com/1dc39c2c4fdfd92d30701a9292e35d0a8c1306f7/chrome/common/extensions/docs/examples/api/fontSettings/css/uber_shared.css
[modify] https://crrev.com/1dc39c2c4fdfd92d30701a9292e35d0a8c1306f7/chrome/common/extensions/docs/examples/api/fontSettings/css/widgets.css
[modify] https://crrev.com/1dc39c2c4fdfd92d30701a9292e35d0a8c1306f7/chrome/common/extensions/docs/examples/api/fontSettings/options.html
[modify] https://crrev.com/1dc39c2c4fdfd92d30701a9292e35d0a8c1306f7/chrome/common/extensions/docs/examples/extensions/plugin_settings/css/plugin_list.css
[modify] https://crrev.com/1dc39c2c4fdfd92d30701a9292e35d0a8c1306f7/chrome/common/extensions/docs/examples/extensions/plugin_settings/css/rule_list.css
[modify] https://crrev.com/1dc39c2c4fdfd92d30701a9292e35d0a8c1306f7/chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/css/chrome_shared.css
[modify] https://crrev.com/1dc39c2c4fdfd92d30701a9292e35d0a8c1306f7/chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/css/select.css
[modify] https://crrev.com/1dc39c2c4fdfd92d30701a9292e35d0a8c1306f7/chrome/common/extensions/docs/examples/extensions/plugin_settings/options/css/list.css

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42

commit f3fd9e3ae2cbefdc2ce0498a03726839c8737c42
Author: Oriol Brufau <obrufau@igalia.com>
Date: Thu Jul 26 11:44:26 2018

[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in /components

 Bug 850000  added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch replaces all the
uses in /components

Spec: https://drafts.csswg.org/css-logical/#box

BUG=862141

Change-Id: Id71b93522241bd4db07133ec98bdc5a32b0a2e4a
Reviewed-on: https://chromium-review.googlesource.com/1150231
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#578264}
[modify] https://crrev.com/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42/components/chrome_apps/webstore_widget/app/main.css
[modify] https://crrev.com/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42/components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.css
[modify] https://crrev.com/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42/components/crash/core/browser/resources/crashes.css
[modify] https://crrev.com/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42/components/flags_ui/resources/flags.css
[modify] https://crrev.com/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42/components/neterror/resources/neterror.css
[modify] https://crrev.com/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42/components/nux_google_apps/resources/apps_chooser.html
[modify] https://crrev.com/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42/components/security_interstitials/core/common/resources/interstitial_common.css
[modify] https://crrev.com/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42/components/supervised_user_error_page/resources/supervised_user_block_interstitial.css
[modify] https://crrev.com/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42/components/sync/driver/resources/sync_node_browser.css
[modify] https://crrev.com/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42/components/sync/driver/resources/sync_search.css
[modify] https://crrev.com/f3fd9e3ae2cbefdc2ce0498a03726839c8737c42/components/version_ui/resources/about_version.css

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2976bc70cae2f802321faf3087573229e851bb0c

commit 2976bc70cae2f802321faf3087573229e851bb0c
Author: Oriol Brufau <obrufau@igalia.com>
Date: Wed Oct 17 20:07:31 2018

[css-logical] Use standard logical properties in /third_party/blink

 Bug 850000  added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch replaces all the
uses in /third_party/blink

Spec: https://drafts.csswg.org/css-logical/#box

BUG=862141

Change-Id: I4d50faa5071ce735931488990d6c2275e57932f7
Reviewed-on: https://chromium-review.googlesource.com/c/1163785
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#600531}
[modify] https://crrev.com/2976bc70cae2f802321faf3087573229e851bb0c/third_party/blink/renderer/core/css/html.css
[modify] https://crrev.com/2976bc70cae2f802321faf3087573229e851bb0c/third_party/blink/renderer/core/css/themeInputMultipleFields.css
[modify] https://crrev.com/2976bc70cae2f802321faf3087573229e851bb0c/third_party/blink/renderer/core/html/forms/resources/calendarPicker.css
[modify] https://crrev.com/2976bc70cae2f802321faf3087573229e851bb0c/third_party/blink/renderer/core/html/forms/resources/listPicker.css
[modify] https://crrev.com/2976bc70cae2f802321faf3087573229e851bb0c/third_party/blink/renderer/core/html/forms/resources/listPicker.js
[modify] https://crrev.com/2976bc70cae2f802321faf3087573229e851bb0c/third_party/blink/renderer/core/html/forms/resources/pickerButton.css
[modify] https://crrev.com/2976bc70cae2f802321faf3087573229e851bb0c/third_party/blink/renderer/core/html/forms/resources/validation_bubble.css
[modify] https://crrev.com/2976bc70cae2f802321faf3087573229e851bb0c/third_party/blink/renderer/core/testing/data/longpress_image_contenteditable.html
[modify] https://crrev.com/2976bc70cae2f802321faf3087573229e851bb0c/third_party/blink/renderer/devtools/front_end/elements/elementsTreeOutline.css
[modify] https://crrev.com/2976bc70cae2f802321faf3087573229e851bb0c/third_party/blink/renderer/devtools/front_end/elements/stylesSectionTree.css
[modify] https://crrev.com/2976bc70cae2f802321faf3087573229e851bb0c/third_party/blink/renderer/devtools/front_end/layer_viewer/layerDetailsView.css
[modify] https://crrev.com/2976bc70cae2f802321faf3087573229e851bb0c/third_party/blink/renderer/devtools/front_end/source_frame/xmlTree.css

Sign in to add a comment