https://chromium-review.googlesource.com/c/chromium/src/+/1121145

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330fc4a13c739591b9a1cf438b6b82a8e8cde96d

commit 330fc4a13c739591b9a1cf438b6b82a8e8cde96d
Author: Sidney San Martín <sdy@chromium.org>
Date: Mon Jul 02 23:27:19 2018

Make all MacViews windows potentially draggable.

This fixes the PiP window not being draggable on Mac.

Bug:  849983 
Change-Id: I1b0f503de1a1f154f23afd1870943a6b7009be75
Reviewed-on: https://chromium-review.googlesource.com/1121145
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572038}
[modify] https://crrev.com/330fc4a13c739591b9a1cf438b6b82a8e8cde96d/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm
[modify] https://crrev.com/330fc4a13c739591b9a1cf438b6b82a8e8cde96d/chrome/browser/ui/views/frame/native_widget_mac_frameless_nswindow.mm
[modify] https://crrev.com/330fc4a13c739591b9a1cf438b6b82a8e8cde96d/ui/views/cocoa/native_widget_mac_nswindow.h
[modify] https://crrev.com/330fc4a13c739591b9a1cf438b6b82a8e8cde96d/ui/views/cocoa/native_widget_mac_nswindow.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07c50437949bbc21dcf3b5f24046fa63ffb4635c

commit 07c50437949bbc21dcf3b5f24046fa63ffb4635c
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 03 10:07:17 2018

Revert "Make all MacViews windows potentially draggable."

This reverts commit 330fc4a13c739591b9a1cf438b6b82a8e8cde96d.

Reason for revert: speculative revert to fix views_unittests (https://bugs.chromium.org/p/chromium/issues/detail?id=859829).

Original change's description:
> Make all MacViews windows potentially draggable.
>
> This fixes the PiP window not being draggable on Mac.
>
> Bug:  849983 
> Change-Id: I1b0f503de1a1f154f23afd1870943a6b7009be75
> Reviewed-on: https://chromium-review.googlesource.com/1121145
> Commit-Queue: Sidney San Martín <sdy@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572038}

TBR=avi@chromium.org,sdy@chromium.org

Change-Id: Ic1e718a03d272c2c1b4646ead018ad776d03fd18
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  849983 , 859829 
Reviewed-on: https://chromium-review.googlesource.com/1124299
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572161}
[modify] https://crrev.com/07c50437949bbc21dcf3b5f24046fa63ffb4635c/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm
[modify] https://crrev.com/07c50437949bbc21dcf3b5f24046fa63ffb4635c/chrome/browser/ui/views/frame/native_widget_mac_frameless_nswindow.mm
[modify] https://crrev.com/07c50437949bbc21dcf3b5f24046fa63ffb4635c/ui/views/cocoa/native_widget_mac_nswindow.h
[modify] https://crrev.com/07c50437949bbc21dcf3b5f24046fa63ffb4635c/ui/views/cocoa/native_widget_mac_nswindow.mm

 Issue 861702  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/725947f86744da7eed4a28b760a6ae51d56e2a9e

commit 725947f86744da7eed4a28b760a6ae51d56e2a9e
Author: Sidney San Martín <sdy@chromium.org>
Date: Tue Jul 10 21:45:18 2018

Reland "Make all MacViews windows potentially draggable."

This is a reland of 330fc4a13c739591b9a1cf438b6b82a8e8cde96d with some
changes:

- |[super mouseDown:]| is called from each subclass rather than the
  shared NSView category, so that it uses the direct superclass
  implementation instead of NSResponder :/.

- If a mouse event would result in a resize, don't start a drag. I
  verified that this method exists back to 10.9. NSThemeFrame does this
  check, too, when movableByWindowBackground is set on its window, but
  it's missing from the frame view class which borderless windows use.
  For simplicity, I'm using the workaround for both.

- Our theme frame subclasses override -usesCustomDrawing to return NO to
  avoid AppKit breakage (like the title not redrawing when it should).

Original change's description:
> Make all MacViews windows potentially draggable.
>
> This fixes the PiP window not being draggable on Mac.
>
> Bug:  849983 
> Change-Id: I1b0f503de1a1f154f23afd1870943a6b7009be75
> Reviewed-on: https://chromium-review.googlesource.com/1121145
> Commit-Queue: Sidney San Martín <sdy@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572038}

Bug:  849983 ,  844417 ,  859820 ,  859829 
Change-Id: I3e596bed04312617edf658e0e652e1491374b9aa
Reviewed-on: https://chromium-review.googlesource.com/1125099
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573926}
[modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm
[modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/chrome/browser/ui/views/frame/native_widget_mac_frameless_nswindow.mm
[modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/ui/views/cocoa/native_widget_mac_nswindow.h
[modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/ui/views/cocoa/native_widget_mac_nswindow.mm