New issue
Advanced search Search tips

Issue 849975 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Layout Test external/wpt/css/css-animations/Element-getAnimations.tentative.html is failing

Project Member Reported by nhiroki@chromium.org, Jun 6 2018

Issue description

The following layout test is failing on multiple platforms.

- external/wpt/css/css-animations/Element-getAnimations.tentative.html

Looks like this test is newly imported from the WPT's repository.
 
Flakiness dashboard:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&showExpectations=true&tests=external%2Fwpt%2Fcss%2Fcss-animations%2FElement-getAnimations.tentative.html


Results on the "Mac10.13 Tests":

--- /b/s/w/ioQtrhme/layout-test-results/external/wpt/css/css-animations/Element-getAnimations.tentative-expected.txt
+++ /b/s/w/ioQtrhme/layout-test-results/external/wpt/css/css-animations/Element-getAnimations.tentative-actual.txt
@@ -8,7 +8,7 @@
 PASS getAnimations for CSS Animations that have finished but are forwards filling
 PASS getAnimations for CSS Animations with animation-name: none
 PASS getAnimations for CSS Animations with animation-name: missing
-PASS getAnimations for CSS Animations where the @keyframes rule is added later
+FAIL getAnimations for CSS Animations where the @keyframes rule is added later assert_true: Newly added animation has a later start time expected true got false
 PASS getAnimations for CSS Animations with duplicated animation-name
 PASS getAnimations for CSS Animations with empty keyframes rule
 PASS getAnimations for CSS animations in delay phase
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec29bf3885c76410ab79d4ea8130df67297b2f97

commit ec29bf3885c76410ab79d4ea8130df67297b2f97
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Jun 06 06:31:17 2018

Sheriff: Suppress failures on external/wpt/css/css-animations/Element-getAnimations.tentative.html

See the issue for details.

Bug: 849975
Change-Id: If597bdb282a3f50b7f9f36d1e9970ae7eae27271
Notry: true
TBR: nhiroki@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1088347
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564805}
[modify] https://crrev.com/ec29bf3885c76410ab79d4ea8130df67297b2f97/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by e...@chromium.org, Jun 7 2018

Components: -Blink>CSS Blink>Animation
Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2bc49cf7603a49aa935fc20b1f212ad9487269c

commit a2bc49cf7603a49aa935fc20b1f212ad9487269c
Author: Rune Lillesveen <futhark@chromium.org>
Date: Wed Oct 10 10:20:16 2018

Recalc style from first to last sibling.

There's no need to do it the opposite way anymore. This also aligns the
order of which transition/animation events are triggered with Gecko
since these events are dispatched in the recalc order. The ordering tests
in [1] have a couple of extra asserts passing.

[1] external/wpt/css/css-animations/Document-getAnimations.tentative.html

Bug: 849975

Change-Id: I6cb63b586d607b2a3c69fcf14f289a5824c60c6b
Reviewed-on: https://chromium-review.googlesource.com/c/1269856
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598275}
[modify] https://crrev.com/a2bc49cf7603a49aa935fc20b1f212ad9487269c/third_party/WebKit/LayoutTests/animations/events/delay-start-event-expected.txt
[modify] https://crrev.com/a2bc49cf7603a49aa935fc20b1f212ad9487269c/third_party/WebKit/LayoutTests/external/wpt/css/css-animations/Document-getAnimations.tentative-expected.txt
[modify] https://crrev.com/a2bc49cf7603a49aa935fc20b1f212ad9487269c/third_party/blink/renderer/core/dom/container_node.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbd79f32f41261658516ce0e669626955c6fb327

commit fbd79f32f41261658516ce0e669626955c6fb327
Author: Rune Lillesveen <futhark@chromium.org>
Date: Wed Oct 10 19:43:33 2018

Missing rebaselines for r598275

Android and Fuchsia generate CONSOLE messages which rely on the order
of style recalc, which changed in mentioned revision.

Bug: 894042, 849975
Change-Id: I305ed05de09c7c6094a275204698393f721d7e3a
Reviewed-on: https://chromium-review.googlesource.com/c/1274126
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598457}
[modify] https://crrev.com/fbd79f32f41261658516ce0e669626955c6fb327/third_party/WebKit/LayoutTests/platform/android/fast/inspector-support/cssURLQuotes-expected.txt
[modify] https://crrev.com/fbd79f32f41261658516ce0e669626955c6fb327/third_party/WebKit/LayoutTests/platform/fuchsia/fast/inspector-support/cssURLQuotes-expected.txt

Sign in to add a comment