New issue
Advanced search Search tips

Issue 849941 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 894049



Sign in to add a comment

Add a flag for webgl msaa sample count

Project Member Reported by jie.a.c...@intel.com, Jun 6 2018

Issue description

WebGL needs a runtime option for setting MSAA sample count similar to the current "GPU rasterization MSAA sample count" flag. With this option, developers can better tune GPU performance, and users can have a choice for their machines regarding the balance of webgl performance and quality.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfbc812c747865d603256e0aae6042cb2686704e

commit cfbc812c747865d603256e0aae6042cb2686704e
Author: jchen10 <jie.a.chen@intel.com>
Date: Mon Jun 11 04:09:39 2018

Add cmdline options for webgl antialiasing

--webgl-antialiasing-mode is used to specify AA method:
  "none" -- no AA.
  "explicit" -- MSAA with explicit resolve.
  "implicit" -- MSAA with implicit resolve.
  "screenspace" -- screen space AA(CMAA).

--webgl-msaa-sample-count is used to specify the
default sample count if MSAA is currently enabled.

Bug:  849941 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia20ca291c120124f4801b08e01624c6fc28af078
Reviewed-on: https://chromium-review.googlesource.com/1075167
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565923}
[modify] https://crrev.com/cfbc812c747865d603256e0aae6042cb2686704e/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/cfbc812c747865d603256e0aae6042cb2686704e/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/cfbc812c747865d603256e0aae6042cb2686704e/gpu/config/gpu_feature_info.h
[modify] https://crrev.com/cfbc812c747865d603256e0aae6042cb2686704e/gpu/config/gpu_switches.cc
[modify] https://crrev.com/cfbc812c747865d603256e0aae6042cb2686704e/gpu/config/gpu_switches.h
[modify] https://crrev.com/cfbc812c747865d603256e0aae6042cb2686704e/gpu/config/gpu_util.cc
[modify] https://crrev.com/cfbc812c747865d603256e0aae6042cb2686704e/gpu/ipc/common/gpu_feature_info.mojom
[modify] https://crrev.com/cfbc812c747865d603256e0aae6042cb2686704e/gpu/ipc/common/gpu_feature_info.typemap
[add] https://crrev.com/cfbc812c747865d603256e0aae6042cb2686704e/gpu/ipc/common/gpu_feature_info_struct_traits.cc
[modify] https://crrev.com/cfbc812c747865d603256e0aae6042cb2686704e/gpu/ipc/common/gpu_feature_info_struct_traits.h
[modify] https://crrev.com/cfbc812c747865d603256e0aae6042cb2686704e/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
[modify] https://crrev.com/cfbc812c747865d603256e0aae6042cb2686704e/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.h

Comment 2 by kbr@chromium.org, Jun 26 2018

Is this bug considered fixed? Please mark it if so. Thanks.

Status: Fixed (was: Started)
Okay, done!
Blocking: 894049

Sign in to add a comment