New issue
Advanced search Search tips

Issue 849932 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocked on:
issue 835871

Blocking:
issue 849492



Sign in to add a comment

EG tests that use [ChromeEarlGreyUI openShareMenu] are failing.

Project Member Reported by kkhorimoto@chromium.org, Jun 6 2018

Issue description

This is because [ChromeEarlGreyUI openShareMenu] does not work since there is no share button in the tools menu after the UI refresh.  The fact that these tests only failed on iOS 10 is that they were already disabled on iOS 11 due to Issue 747622.

Stepan, you're working on adding the share button to the omnibox for portrait iPhones, right?

 
Affected tests:

ActivityServiceControllerTestCase.testActivityServiceControllerPrintAfterRedirectionToUnprintablePage
ActivityServiceControllerTestCase.testActivityServiceControllerCantPrintUnprintablePages
ActivityServiceControllerTestCase.testOpenActivityServiceControllerAndCopy
JavaScriptDialogTestCase.testShowJavaScriptAfterShareMenu
PrintControllerTestCase.testPrintNormalPage
PrintControllerTestCase.testPrintPDF
ToolbarTestCase.testCopyPasteURL
Components: Test
Labels: ReleaseBlock-Beta M-69
Blockedon: 835871
Status: Started (was: Assigned)
Can these tests be re-enabled now?
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f214555c63f5e69446adf4be717b413e54334efd

commit f214555c63f5e69446adf4be717b413e54334efd
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jul 18 14:14:45 2018

Reenable tests using openShareMenu.

 - Reenable tests that rely on the share menu.
 - Fix -openShareMenu test helper
 - Fix location bar's trailing button accessibility:
now it's correctly updated when it's switched between
voice search and share.

Bug:  849932 ,  835871 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I01101fb34ce57464e2722a753e5e3ad9c71bbd3f
Reviewed-on: https://chromium-review.googlesource.com/1140161
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576032}
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/location_bar/location_bar_consumer.h
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/location_bar/location_bar_mediator.mm
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/location_bar/location_bar_view_controller.h
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/print/print_controller_egtest.mm
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_egtest.mm
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/toolbar/clean/toolbar_mediator.mm
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
[modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/test/earl_grey/chrome_matchers.mm

Cc: kariahda@chromium.org
This bug is marked as not time critical but is blocking M69 beta. Please adjust priority or remove RBB. 
Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD Merge-Request-69
This not only fixes tests, but also includes a few fixes for edge-cases, specifically the omnibox button on iPad now has correct accessibility. This needs to be cherry-picked if it's not on the branch. 
Project Member

Comment 12 by sheriffbot@chromium.org, Jul 19

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: We don't branch M69 until 2018-07-19.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-69
This made M69 already. No merge needed. Removing merge labels.

https://storage.googleapis.com/chromium-find-releases-static/f21.html#f214555c63f5e69446adf4be717b413e54334efd

Sign in to add a comment