New issue
Advanced search Search tips

Issue 849928 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/css/css-logical by import https://crrev.com/c/1087824

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Jun 6 2018

Issue description

WPT import https://crrev.com/c/1087824 introduced new failures in external/wpt/css/css-logical:

List of new failures:
external/wpt/css/css-logical/logical-box-border-style.html new failing tests: https://crrev.com/c/1087824/4/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-border-style-expected.txt
external/wpt/css/css-logical/logical-box-size.html new failing tests: https://crrev.com/c/1087824/4/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-size-expected.txt
external/wpt/css/css-logical/logical-box-border-width.html new failing tests: https://crrev.com/c/1087824/4/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-border-width-expected.txt
external/wpt/css/css-logical/logical-box-inset.html new failing tests: https://crrev.com/c/1087824/4/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-inset-expected.txt
external/wpt/css/css-logical/logical-box-padding.html new failing tests: https://crrev.com/c/1087824/4/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-padding-expected.txt
external/wpt/css/css-logical/logical-box-margin.html new failing tests: https://crrev.com/c/1087824/4/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-margin-expected.txt
external/wpt/css/css-logical/logical-box-border-color.html new failing tests: https://crrev.com/c/1087824/4/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-box-border-color-expected.txt

This import contains upstream changes from 1e64b416a81befaae0b180c1033651fda12e6777 to a7683a8516a1af5b4047a4bbaef7aaba575ad774:
Merge pull request #11326 from web-platform-tests/woff2-sync-up-available: https://github.com/web-platform-tests/wpt/commit/a7683a8516a1af5b4047a4bbaef7aaba575ad774
Merge pull request #11313 from web-platform-tests/woff2-sync-up: https://github.com/web-platform-tests/wpt/commit/40ff5f965fd8dfaaf426d2037632bb997fc91c3d
Merge pull request #11324 from Loirooriol/css-logical-longhands: https://github.com/web-platform-tests/wpt/commit/096cc8f668deca283a93e19b73dcf21fd8cf75b8
Add tests that deal with applying number format specifiers on Symbols: https://github.com/web-platform-tests/wpt/commit/a21cb02941464102abb91349b732f0864a2d2586
Auto-update the payment-request IDL: https://github.com/web-platform-tests/wpt/commit/e8fb48bf865db29f2984e4d6f75c1bb9f06df63a
Make --verify-log-full not override log level: https://github.com/web-platform-tests/wpt/commit/d564a348a73af817ff565814ebf522ca5991aa55
Fix #10921: make --stability use the same code as --verify: https://github.com/web-platform-tests/wpt/commit/5bd42c170ce485e9f26eeac3a1f0b919d0fa3106
Make check_stability.py use the --verify code: https://github.com/web-platform-tests/wpt/commit/38809cb9636e65d9083453c2400024f567c7f687
Make IndexedDB/support.js work in workers: https://github.com/web-platform-tests/wpt/commit/60a937de7bd20eb1890893a48423a79b096866d8
Add tests for logical box model longhand properties: https://github.com/web-platform-tests/wpt/commit/30eb26b3ed60dc7f276e0dc030c586d2d5c090a0 [affecting this directory]
Redirect POST requests using .py resource: https://github.com/web-platform-tests/wpt/commit/ec9ffb132d24fa16088b90db12a65509b72ef826
Test for used column-count when column-count/width are not auto (#10250): https://github.com/web-platform-tests/wpt/commit/8b089cb6cebe9c83a471e5cfb10a1570dad65ed4 [affecting this directory]
Merge pull request #11352 from mrego/contain-layout-fixes: https://github.com/web-platform-tests/wpt/commit/7a80bc95a6e56d527a426aa4440bc2bec2cf8169
[css-contain] Fix references to paint instead of layout containment: https://github.com/web-platform-tests/wpt/commit/8c28134611cc36b428240af079b2abc9a7ba478e [affecting this directory]
XMLHttpRequest: upload listener flag: https://github.com/web-platform-tests/wpt/commit/1706eb31b901d4e5ce8bb873ffb5b31bb01e1e58
[LayoutNG] Need to know when establishing a new FC during min/max calculation.: https://github.com/web-platform-tests/wpt/commit/aa5ec97282685cba4a2ae34165ddb5043c251e39 [affecting this directory]
HTML: Fix sandbox-disallow-same-origin.html to expect SecurityError: https://github.com/web-platform-tests/wpt/commit/e4fd758fb3ed204ec4234eb678323273a99eb685
Fetch: port blocking change (427, 548, 6697): https://github.com/web-platform-tests/wpt/commit/2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
Experimental Priority Hints support on fetch() API: https://github.com/web-platform-tests/wpt/commit/dae7535c0428fbf057a5c39f324d5a3f47ba64c7
HTML: Change <td hidden> and <th hidden> to expect display: none: https://github.com/web-platform-tests/wpt/commit/b20cb44c2991d09cc4c6e87260221cb777c15ef5
[wptrunner] End Sauce Connect process gracefully (#11334): https://github.com/web-platform-tests/wpt/commit/2bd11b91d490ddd5237bcb6d8149a7f25faaa101
Revert "WaveShaper must output non-zero values even if input is silent": https://github.com/web-platform-tests/wpt/commit/fa5ee47808411c866d09ad6a34dccf383b097bca
custom-elements: Element created by createElement(name, options) with valid custom element name and options set to undefined should be upgraded: https://github.com/web-platform-tests/wpt/commit/8a5301b16f5e913bf9ffbb7d76abfda9d2435af2
Compute correct sticky box constraints within scrollable containers: https://github.com/web-platform-tests/wpt/commit/dc60bfc45b49e3a5e653320e65b0fd447676b836 [affecting this directory]
Make multiple-workers tests fail if (Shared)Worker is not defined: https://github.com/web-platform-tests/wpt/commit/4f7d09666f738d1db19ba49721b2db4330bf4e82
WaveShaper must output non-zero values even if input is silent: https://github.com/web-platform-tests/wpt/commit/5007510675fa679ff60a44a9d10ae33903fa275c
Update event-dispatch test now that we can use the updated EventWatcher: https://github.com/web-platform-tests/wpt/commit/4b77fc947623698b4724986cf8570d425c91635b [affecting this directory]
Add spec links to test files: https://github.com/web-platform-tests/wpt/commit/2031f81273d04741082d1d60212c561eed66b1e0 [affecting this directory]
Move CSS animations / Web animation integration tests to web-platform-tests: https://github.com/web-platform-tests/wpt/commit/78744934a6d1ab334dfe284923608e6244bb7aca [affecting this directory]
Update test_animation-starttime.html: https://github.com/web-platform-tests/wpt/commit/2160e0f714100f9b8dea4bc35ac4499cd777402a
Move the reversing test to Web Animations web-platform-tests: https://github.com/web-platform-tests/wpt/commit/df00d564e1dc0791742eda7216e277084e0494c9
Tidy up test_animation-ready.html: https://github.com/web-platform-tests/wpt/commit/504843968deb218bf844dd0d2b28d5283afd0385
Re-arrange tests in test_animations-currenttime.html: https://github.com/web-platform-tests/wpt/commit/0a51201198721c98b13a620246b268076a7dc4cb
Fix race condition within wpt test policy-inherited-correctly-by-plznavigate.html.: https://github.com/web-platform-tests/wpt/commit/6e44ea96e656cc19b396e76afa32295eebcc2b42
WOFF2: Sync up available-* tests against https://github.com/w3c/woff2-tests: https://github.com/web-platform-tests/wpt/commit/b4073eb66dc44ec6ab5ded0dffdd4337528d317d [affecting this directory]
Regenerated test index for WOFF2.: https://github.com/web-platform-tests/wpt/commit/8e487e021d278e61992e2fa14e2d23c0ba4a1457 [affecting this directory]
Remove obsolete WOFF2 tests for metadata display.: https://github.com/web-platform-tests/wpt/commit/6ce1b0b52aa246d0a19fd06a326472d09c88cac6 [affecting this directory]
Add new WOFF2 tests: directory-knowntags-001 and tabledata-glyf-origlength-003.: https://github.com/web-platform-tests/wpt/commit/387c22ceff5180e77aba76bc20b4e302309db290 [affecting this directory]
Whoops - forgot to delete: https://github.com/web-platform-tests/wpt/commit/d32ee4244382faec06357cef04bfd7a23300c899
Manually test number format specifiers applied to Symbols: https://github.com/web-platform-tests/wpt/commit/13436ebf461b3713c3df7f71cf59e5edcf898eca
Add tests that deal with applying number format specifiers on Symbols: https://github.com/web-platform-tests/wpt/commit/94c053e429240dd44a05e654566c0d003c37232c

 

Comment 1 by r...@igalia.com, Jun 6 2018

Cc: obru...@igalia.com r...@igalia.com
These are new tests in WPT and some things that are wrong ( issue #849855 ) or not implemented yet in Chromimum ( issue #850000 ).

I guess we can just close this issue, or what's the expected thing to do here?
Re #1: in which case it'd be great to change TestExpectations to associate the failures with the known issues and then close this bug. Thanks!

Comment 3 by r...@igalia.com, Jun 6 2018

Mmmm, but what happens with testharness.js tests.

Inside a single test fail you can have many test() functions, if 5 FAIL and 10 PASS, how do we mark that on TestExpectations?
Re #3: ahh the testharness.js tests won't end up in TestExpectations at all. They are "rebaselined" (new expected outputs are created). Sorry I didn't look carefully enough. Looks like all failures here are testharness.js tests, so you can simply list comment failures in their respective bugs and close this issue.

Comment 5 by r...@igalia.com, Jun 7 2018

Status: Fixed (was: Untriaged)
Ok, one of the issues ( issue #850000 ) is actually for implementing this stuff so it's very clear there are issues with this.
I added a comment in the other one about the specific test that is failing due to that.

We're working on them now so things will improve on that regard.

Thanks for the information.

Sign in to add a comment