New issue
Advanced search Search tips

Issue 849913 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[WebView Autofill] Provide local prediction in WebView

Project Member Reported by michaelbai@chromium.org, Jun 6 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5df82767fbdc92a2871f10ee55b06c9304f1f01

commit d5df82767fbdc92a2871f10ee55b06c9304f1f01
Author: Tao Bai <michaelbai@chromium.org>
Date: Wed Jun 20 05:52:56 2018

Move form_structures_ to AutofillHandler

This is the first patch to share the local prediction in Android
autofill.

Bug: 849913

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I20454214528244f1af7b42ccb2907987f4855913
Reviewed-on: https://chromium-review.googlesource.com/1081180
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568740}
[modify] https://crrev.com/d5df82767fbdc92a2871f10ee55b06c9304f1f01/chrome/browser/autofill/form_structure_browsertest.cc
[modify] https://crrev.com/d5df82767fbdc92a2871f10ee55b06c9304f1f01/components/autofill/core/browser/autofill_handler.cc
[modify] https://crrev.com/d5df82767fbdc92a2871f10ee55b06c9304f1f01/components/autofill/core/browser/autofill_handler.h
[modify] https://crrev.com/d5df82767fbdc92a2871f10ee55b06c9304f1f01/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/d5df82767fbdc92a2871f10ee55b06c9304f1f01/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/d5df82767fbdc92a2871f10ee55b06c9304f1f01/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/d5df82767fbdc92a2871f10ee55b06c9304f1f01/components/autofill/core/browser/test_autofill_manager.cc
[modify] https://crrev.com/d5df82767fbdc92a2871f10ee55b06c9304f1f01/ios/chrome/browser/autofill/autofill_controller_unittest.mm
[modify] https://crrev.com/d5df82767fbdc92a2871f10ee55b06c9304f1f01/ios/chrome/browser/autofill/form_structure_browsertest.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1976e41c16e11ad1527f326efde62c9ae501c11e

commit 1976e41c16e11ad1527f326efde62c9ae501c11e
Author: Tao Bai <michaelbai@chromium.org>
Date: Tue Jun 26 21:15:53 2018

[Autofill] Parse forms in AutofillHandler::OnFormsSeen.

This patch parses forms in AutofillHandler::OnFormsSeen(), so the
code could be shared between chrome and WebView autofill.

The parse is disabled in WebView autofill now.

Bug: 849913
Change-Id: I25260fa87eb59c2cc2d9060a1d92acbca0254e84
Reviewed-on: https://chromium-review.googlesource.com/1108921
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570533}
[modify] https://crrev.com/1976e41c16e11ad1527f326efde62c9ae501c11e/components/autofill/core/browser/autofill_handler.cc
[modify] https://crrev.com/1976e41c16e11ad1527f326efde62c9ae501c11e/components/autofill/core/browser/autofill_handler.h
[modify] https://crrev.com/1976e41c16e11ad1527f326efde62c9ae501c11e/components/autofill/core/browser/autofill_handler_proxy.cc
[modify] https://crrev.com/1976e41c16e11ad1527f326efde62c9ae501c11e/components/autofill/core/browser/autofill_handler_proxy.h
[modify] https://crrev.com/1976e41c16e11ad1527f326efde62c9ae501c11e/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/1976e41c16e11ad1527f326efde62c9ae501c11e/components/autofill/core/browser/autofill_manager.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f127d376cab3f21a885bc2ece2ddc88f7a7f62c

commit 5f127d376cab3f21a885bc2ece2ddc88f7a7f62c
Author: Tao Bai <michaelbai@chromium.org>
Date: Tue Jul 31 19:06:22 2018

Call DetermineHeuristicTypes in AutofillHandler

- Leave the UKM in AutofillManager.
- Call DetermineHeristicTypes in AutofillHandler

Bug: 849913
Change-Id: Ic193afbab0ac14595e6c975caf5d2520209be06e
Reviewed-on: https://chromium-review.googlesource.com/1150732
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579513}
[modify] https://crrev.com/5f127d376cab3f21a885bc2ece2ddc88f7a7f62c/components/autofill/core/browser/autofill_assistant_unittest.cc
[modify] https://crrev.com/5f127d376cab3f21a885bc2ece2ddc88f7a7f62c/components/autofill/core/browser/autofill_handler.cc
[modify] https://crrev.com/5f127d376cab3f21a885bc2ece2ddc88f7a7f62c/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/5f127d376cab3f21a885bc2ece2ddc88f7a7f62c/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/5f127d376cab3f21a885bc2ece2ddc88f7a7f62c/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/5f127d376cab3f21a885bc2ece2ddc88f7a7f62c/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/5f127d376cab3f21a885bc2ece2ddc88f7a7f62c/components/autofill/core/browser/form_data_importer_unittest.cc
[modify] https://crrev.com/5f127d376cab3f21a885bc2ece2ddc88f7a7f62c/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/5f127d376cab3f21a885bc2ece2ddc88f7a7f62c/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/5f127d376cab3f21a885bc2ece2ddc88f7a7f62c/components/autofill/core/browser/form_structure_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13145d837be8cedec977e9321a02fc9ee54e64e8

commit 13145d837be8cedec977e9321a02fc9ee54e64e8
Author: Tao Bai <michaelbai@chromium.org>
Date: Sat Sep 01 04:08:14 2018

[Webview Autofill] Implement Local prediction

Present heuristic type to Android Autofill service.

Bug: 849913
Change-Id: I7e832aa157d6fe5adadc8c8edc2dcc77ecd9effa
Reviewed-on: https://chromium-review.googlesource.com/1174977
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588264}
[modify] https://crrev.com/13145d837be8cedec977e9321a02fc9ee54e64e8/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
[modify] https://crrev.com/13145d837be8cedec977e9321a02fc9ee54e64e8/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
[modify] https://crrev.com/13145d837be8cedec977e9321a02fc9ee54e64e8/components/autofill/android/autofill_provider_android.cc
[modify] https://crrev.com/13145d837be8cedec977e9321a02fc9ee54e64e8/components/autofill/android/form_data_android.cc
[modify] https://crrev.com/13145d837be8cedec977e9321a02fc9ee54e64e8/components/autofill/android/form_data_android.h
[modify] https://crrev.com/13145d837be8cedec977e9321a02fc9ee54e64e8/components/autofill/android/form_field_data_android.cc
[modify] https://crrev.com/13145d837be8cedec977e9321a02fc9ee54e64e8/components/autofill/android/form_field_data_android.h
[modify] https://crrev.com/13145d837be8cedec977e9321a02fc9ee54e64e8/components/autofill/android/java/src/org/chromium/components/autofill/FormFieldData.java
[modify] https://crrev.com/13145d837be8cedec977e9321a02fc9ee54e64e8/components/autofill/core/browser/autofill_handler.h
[modify] https://crrev.com/13145d837be8cedec977e9321a02fc9ee54e64e8/components/autofill/core/browser/autofill_handler_proxy.cc
[modify] https://crrev.com/13145d837be8cedec977e9321a02fc9ee54e64e8/components/autofill/core/browser/autofill_type.cc

Labels: -Pri-3 Merge-Request-70 Pri-2
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 2

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 5

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-70 Merge-Merged
The patch has been merged 

https://chromium-review.googlesource.com/c/chromium/src/+/1204720
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 5

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f160462484772e770ae081272186ff65bd475d68

commit f160462484772e770ae081272186ff65bd475d68
Author: Tao Bai <michaelbai@chromium.org>
Date: Tue Sep 04 18:25:24 2018

[Webview Autofill] Implement Local prediction

Present heuristic type to Android Autofill service.

Bug: 849913
Change-Id: I7e832aa157d6fe5adadc8c8edc2dcc77ecd9effa
Reviewed-on: https://chromium-review.googlesource.com/1174977
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588264}(cherry picked from commit 13145d837be8cedec977e9321a02fc9ee54e64e8)
Reviewed-on: https://chromium-review.googlesource.com/1204720
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#30}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/f160462484772e770ae081272186ff65bd475d68/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
[modify] https://crrev.com/f160462484772e770ae081272186ff65bd475d68/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
[modify] https://crrev.com/f160462484772e770ae081272186ff65bd475d68/components/autofill/android/autofill_provider_android.cc
[modify] https://crrev.com/f160462484772e770ae081272186ff65bd475d68/components/autofill/android/form_data_android.cc
[modify] https://crrev.com/f160462484772e770ae081272186ff65bd475d68/components/autofill/android/form_data_android.h
[modify] https://crrev.com/f160462484772e770ae081272186ff65bd475d68/components/autofill/android/form_field_data_android.cc
[modify] https://crrev.com/f160462484772e770ae081272186ff65bd475d68/components/autofill/android/form_field_data_android.h
[modify] https://crrev.com/f160462484772e770ae081272186ff65bd475d68/components/autofill/android/java/src/org/chromium/components/autofill/FormFieldData.java
[modify] https://crrev.com/f160462484772e770ae081272186ff65bd475d68/components/autofill/core/browser/autofill_handler.h
[modify] https://crrev.com/f160462484772e770ae081272186ff65bd475d68/components/autofill/core/browser/autofill_handler_proxy.cc
[modify] https://crrev.com/f160462484772e770ae081272186ff65bd475d68/components/autofill/core/browser/autofill_type.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ca5922d9e49da89a3bc4cf42d7125519c948eaa

commit 3ca5922d9e49da89a3bc4cf42d7125519c948eaa
Author: Tao Bai <michaelbai@chromium.org>
Date: Thu Sep 20 16:05:24 2018

Add autofill missing resource

These resources are used by hueristic field type prediction.

Bug: 849913
Change-Id: Iab2935bce88984c604ac87f0148910c1a4b343c2
Reviewed-on: https://chromium-review.googlesource.com/1231819
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592821}
[modify] https://crrev.com/3ca5922d9e49da89a3bc4cf42d7125519c948eaa/android_webview/ui/grit_strings_whitelist.txt

Labels: -Merge-Merged -Hotlist-Merge-Approved -merge-merged-3538 Merge-Request-70
The patch in #11 needs to merge to M70
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 20

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-70 Merge-Approved-70
Approved for merge to 70, branch 3538.
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 21

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d3c3c302fc7857e6e16906fa7f210d464bdaad5

commit 8d3c3c302fc7857e6e16906fa7f210d464bdaad5
Author: Tao Bai <michaelbai@chromium.org>
Date: Fri Sep 21 19:53:07 2018

Add autofill missing resource

These resources are used by hueristic field type prediction.

Bug: 849913
Change-Id: Iab2935bce88984c604ac87f0148910c1a4b343c2
Reviewed-on: https://chromium-review.googlesource.com/1231819
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592821}(cherry picked from commit 3ca5922d9e49da89a3bc4cf42d7125519c948eaa)
Reviewed-on: https://chromium-review.googlesource.com/1239178
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#562}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/8d3c3c302fc7857e6e16906fa7f210d464bdaad5/android_webview/ui/grit_strings_whitelist.txt

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/8d3c3c302fc7857e6e16906fa7f210d464bdaad5

Commit: 8d3c3c302fc7857e6e16906fa7f210d464bdaad5
Author: michaelbai@chromium.org
Commiter: michaelbai@chromium.org
Date: 2018-09-21 19:53:07 +0000 UTC

Add autofill missing resource

These resources are used by hueristic field type prediction.

Bug: 849913
Change-Id: Iab2935bce88984c604ac87f0148910c1a4b343c2
Reviewed-on: https://chromium-review.googlesource.com/1231819
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592821}(cherry picked from commit 3ca5922d9e49da89a3bc4cf42d7125519c948eaa)
Reviewed-on: https://chromium-review.googlesource.com/1239178
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#562}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
no manualy verification needed as per Micheal

Sign in to add a comment