New issue
Advanced search Search tips

Issue 849912 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 846410



Sign in to add a comment

NoProfileChooserOnOutsideUserDataDirProfiles fails with Refresh avatar button

Project Member Reported by bsep@chromium.org, Jun 6 2018

Issue description

ProfileChooserViewExtensionsTest.NoProfileChooserOnOutsideUserDataDirProfiles fails when Refresh is enabled. I invesigated as part of  bug 846410 , but it looks like a real issue with the new button: the menu should never trigger when using an outside user data directory.
 

Comment 1 by pbos@chromium.org, Jun 6 2018

Blocking: 846410
Cc: msw@chromium.org est...@chromium.org
Labels: -Pri-2 Pri-1
Bumping to P1 as resolving these tests blocks default-enabling Refresh as tests fail.

+msw@, +estade@: You seem to be involved in issue 527505 for which this test was seemingly added. I don't see why a changed profile directory means we won't show the avatar button, can you help shed some light on this?

For MD Refresh we always show a toolbar button, so ShowAvatarBubbleFromAvatarButton always works as there's always an avatar button. This is why this test ends up failing as the ProfileChooserView gets instantiated. What's reasonable as a follow-up here? What would the avatar button (that's always visible) reasonably show instead?

Comment 2 by msw@chromium.org, Jun 6 2018

I'm not really familiar with the scenario, but I'm happy to chat if you're really stuck.
Labels: -Pri-1 Pri-2
Triage:
Disable tests for now, bumping down to P2.

Comment 4 by bsep@chromium.org, Jun 14 2018

Labels: -Pri-2 Pri-1
I don't think this test should be disabled without making sure whatever scenario this is isn't going to crash the browser.

Comment 5 by pbos@chromium.org, Jun 14 2018

Cc: msarda@chromium.org
msarda@ do you know more about triggering the profile switcher menu with an out-of-userdata profile or more what out-of-userdatadir profile means in general? 

Comment 6 by msarda@chromium.org, Jun 15 2018

Cc: rogerta@chromium.org
pbos@: I do not know much about this. Maybe rogerta@ remembers what this is.

Comment 7 by pbos@chromium.org, Jun 19 2018

Cc: pkasting@chromium.org
I checked with them, no one seems to know or think of a good use case for out-of-user-data-dir profiles. I'm trying to repro bad things using --profile-directory=..\ on Windows but it seems to DCHECK inside ChromeZoomLevelPrefs' constructor (as profile_path.IsParent(partition_path) fails.

I'm inclined to rather than fixing this test add some sanity checking of the --profile-directory parameter. pkasting@ if you happen to have an opinion on where to validate this switch (or ignore when invalid) please let me know.

I'll disable the test for now so we can enable Refresh by default. If this switch (outside user dir) is truly unsupported this test should probably be removed altogether. Any objections to that, please speak up.
No opinion.  And no objection to removing the test.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/499278c4e2e55675e852b971dc9fae9a69af8ec1

commit 499278c4e2e55675e852b971dc9fae9a69af8ec1
Author: Peter Boström <pbos@chromium.org>
Date: Tue Jun 19 02:32:14 2018

Remove profile-chooser-outside-datadir test

We haven't been able to figure out why profiles outside the user
data directory make any sense whatsoever. It seems more reasonable to
reject or sanitize this directory path than taking it into account when
trying to spawn the profile switcher.

Bug:  chromium:849912 
Change-Id: I8386bee829c95ff6450b676d39091adf7bfad9d6
Reviewed-on: https://chromium-review.googlesource.com/1105495
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568309}
[modify] https://crrev.com/499278c4e2e55675e852b971dc9fae9a69af8ec1/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

Comment 10 by pbos@chromium.org, Jun 19 2018

Status: WontFix (was: Assigned)
WontFix as test is gone. We might need to revisit this if we see problems in the wild because of this.

Sign in to add a comment