New issue
Advanced search Search tips

Issue 849911 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 846410



Sign in to add a comment

Refresh avatar button should trigger menu on mouse press

Project Member Reported by bsep@chromium.org, Jun 6 2018

Issue description

Unlike normal buttons, the Refresh avatar menu button should trigger on mouse down to support old-Mac-style drag-and-release selection of menu items.

The ProfileChooserViewExtensionsTest suite in browser_tests correctly exercises this.
 

Comment 1 by pbos@chromium.org, Jun 6 2018

Blocking: 846410
Labels: -Pri-2 Pri-1
Labels: -Pri-1 Pri-2
Triage:
Moving to P2.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cab92fd124f3ec3e8219dfae926c42ce18fb268

commit 9cab92fd124f3ec3e8219dfae926c42ce18fb268
Author: Peter Boström <pbos@chromium.org>
Date: Thu Jun 07 22:23:21 2018

Trigger AvatarToolbarButton menu on LMB press

This makes the AvatarToolbarButton toggle like a MenuButton similarly to
the adjacent BrowserAppMenuButton (which is actually a MenuButton).

Bug:  chromium:849911 
Change-Id: I30690c61dd9b9b58b80e28dcbc85dc9e72835b9d
Reviewed-on: https://chromium-review.googlesource.com/1091592
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565440}
[modify] https://crrev.com/9cab92fd124f3ec3e8219dfae926c42ce18fb268/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc

Triage: any further work?

Comment 5 by pbos@chromium.org, Jun 11 2018

Status: Fixed (was: Assigned)
None!

Sign in to add a comment