New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 849905 link

Starred by 1 user
Status: Fixed
Owner:
lijeffrey@chromium.org
Closed: Jun 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] update_monorail_bug_pipeline_test needs to mock IssueTrackerAPI

Project Member Reported by lijeffrey@chromium.org, Jun 6 2018 
update_monorail_bug_pipeline_test has unit tests making real calls to monorail. Need proper mocking
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/58eeb6b4f3455b30a590de7907f953c66df8b0c2

commit 58eeb6b4f3455b30a590de7907f953c66df8b0c2
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Wed Jun 06 00:47:04 2018

[Findit] Flake Analyzer - Proper mocking of IssueTrackerAPI in unit tests

Bug:  849905 
Change-Id: I7e62f0b93a7b0d3422fb7e074a194eeb9bb70696
Reviewed-on: https://chromium-review.googlesource.com/1087518
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/58eeb6b4f3455b30a590de7907f953c66df8b0c2/appengine/findit/pipelines/flake_failure/test/update_monorail_bug_pipeline_test.py

Comment 2 by lijeffrey@chromium.org, Jun 6 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment