Add UMA metrics for Display zoom factors |
||||||
Issue description
We need UMA metrics on the zoom factors that users set.
Since uma is only a signal, we also need to decide what type of signals we want to store.
What we need:
- For a given device, what zoom factor users are setting for the internal display.
- What zoom factor users are setting for a given resolution of external display.
Since zoom factor can be any value, we need to create buckets.
For internal displays we can have:
- [40, 45)
- [45, 50)
.....
....
- [145, 150)
- [150, 175)
would require a total of 23 buckets.
However I am not sure how we should set up the signals for external displays. We can figure out all the internal display information based on what device the signal is coming from, however this cannot be done for external displays.
We can send a different signal for an external displays belonging to one of the bucket:
- [720p, 1080p)
- [100, 110)
- [110, 120)
- ....
- [1080p, 1440p)
- ....
..
..
..
- [3200, 3840)
- ...
Another problem that we may want to think about is that we will send a signal for every zoom factor change that the user does. This means that even if the user is only trying out a certain zoom level for a few seconds, we will record it as a signal. Is this important? Does UMA has a way to ignore signals that are sent close to one another?
,
Jun 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20ef07ea8c8c673306485d031ab6355d1320e0ad commit 20ef07ea8c8c673306485d031ab6355d1320e0ad Author: Malay Keshav <malaykeshav@chromium.org> Date: Sat Jun 16 01:37:56 2018 Add UMA metrics for internal display zoom factor changes This patch records UMA metrics for any change to the internal display's zoom factor. It does not record temporary zoom factor changes by debouncing signals that are within a small interval and only allowing the last signal to pass through. Bug: 849894 Change-Id: I2dc7d31e9910855ca4a59834a56d8322641a9f5b Component: Display Manager, UMA, Zoom Reviewed-on: https://chromium-review.googlesource.com/1093270 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#567855} [modify] https://crrev.com/20ef07ea8c8c673306485d031ab6355d1320e0ad/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/20ef07ea8c8c673306485d031ab6355d1320e0ad/ui/display/manager/display_manager.cc [modify] https://crrev.com/20ef07ea8c8c673306485d031ab6355d1320e0ad/ui/display/manager/display_manager.h
,
Jun 18 2018
,
Jun 18 2018
,
Jun 18 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 18 2018
This seems more like a feature than a bug, do we really need this in 68?
,
Jun 18 2018
The list of zoom levels we present to the users are quite experimental as of now, and we have no way to know more besides user feedback. M68 is the first version where we enable the display zoom feature by default. It would be quite helpful to note what setting the user sets to calibrate our options further for the next milestone.
,
Jun 19 2018
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2934d3e544d39b6bdad6ac89afba7143794c555f commit 2934d3e544d39b6bdad6ac89afba7143794c555f Author: Malay Keshav <malaykeshav@chromium.org> Date: Tue Jun 19 22:17:44 2018 (merge) Add UMA metrics for internal display zoom factor changes This patch records UMA metrics for any change to the internal display's zoom factor. It does not record temporary zoom factor changes by debouncing signals that are within a small interval and only allowing the last signal to pass through. Bug: 849894 Change-Id: I2dc7d31e9910855ca4a59834a56d8322641a9f5b Component: Display Manager, UMA, Zoom Reviewed-on: https://chromium-review.googlesource.com/1093270 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#567855}(cherry picked from commit 20ef07ea8c8c673306485d031ab6355d1320e0ad) Reviewed-on: https://chromium-review.googlesource.com/1106942 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#458} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/2934d3e544d39b6bdad6ac89afba7143794c555f/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/2934d3e544d39b6bdad6ac89afba7143794c555f/ui/display/manager/display_manager.cc [modify] https://crrev.com/2934d3e544d39b6bdad6ac89afba7143794c555f/ui/display/manager/display_manager.h |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by weifangsun@chromium.org
, Jun 15 2018