New issue
Advanced search Search tips

Issue 849887 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Feature



Sign in to add a comment

Support process filtering in tracing

Project Member Reported by alph@chromium.org, Jun 5 2018

Issue description

Allow the tracing clients to specify what processes they want to exclude from tracing upon start.

That should allow DevTools performance recording do not collect unneeded data thus reducing recording CPU and memory overhead.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c182b7ccdcea813dcd0dd53d92041e8275f77de8

commit c182b7ccdcea813dcd0dd53d92041e8275f77de8
Author: Alexei Filippov <alph@chromium.org>
Date: Thu Jun 28 21:44:53 2018

Support filtering of processes that participate in tracing.

Adds ProcessFilterConfig part to TraceConfig. The functionality
allows clients to whitelist processes that need to record traces.

It is going to be used by DevTools to limit the trace collection
to inspected processes. It will greatly reduce overhead of performance
recording, especially when it is being run in a browser having lots
of tabs open.

BUG= 849887 

Change-Id: I6395170509cd9b2ff688ee675a768393d0e95c8a
Reviewed-on: https://chromium-review.googlesource.com/1087947
Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571274}
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/base/trace_event/trace_config.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/base/trace_event/trace_config.h
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/base/trace_event/trace_log.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/content/browser/tracing/cast_tracing_agent.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/content/browser/tracing/cros_tracing_agent.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/content/browser/tracing/etw_tracing_agent_win.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/content/browser/tracing/power_tracing_agent.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/content/browser/tracing/tracing_controller_impl.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/services/tracing/agent_registry.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/services/tracing/agent_registry.h
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/services/tracing/agent_registry_unittest.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/services/tracing/coordinator.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/services/tracing/coordinator.h
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/services/tracing/coordinator_unittest.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/services/tracing/public/cpp/base_agent.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/services/tracing/public/cpp/base_agent.h
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/services/tracing/public/cpp/trace_event_agent.cc
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/services/tracing/public/mojom/tracing.mojom
[modify] https://crrev.com/c182b7ccdcea813dcd0dd53d92041e8275f77de8/services/tracing/tracing_service_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6c1fa1bb83ef29562c22ee56b17433ed0d6955a

commit a6c1fa1bb83ef29562c22ee56b17433ed0d6955a
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Jul 06 22:45:49 2018

DevTools: Update tracing process filters when process is ready.

Drive-by: Fix a failing DCHECK on Pid() invoked on a non-ready process.

BUG= 848398 , 849887 

Change-Id: I1df89b5027ec5ed85235566427dd767ade092fa0
Reviewed-on: https://chromium-review.googlesource.com/1128055
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573099}
[modify] https://crrev.com/a6c1fa1bb83ef29562c22ee56b17433ed0d6955a/content/browser/devtools/protocol/tracing_handler.cc
[modify] https://crrev.com/a6c1fa1bb83ef29562c22ee56b17433ed0d6955a/content/browser/devtools/protocol/tracing_handler.h

Status: Fixed (was: Started)

Sign in to add a comment