Peter, Anna, another small change?

Regular ChromeTabbedActivity seems to have the same issue.

Let me add that even in a regular tab, that icon's description is the same. What makes it less of a problem in that case is that for this UI there's additional text clues -- "Offline" or "Secure" labels, or the "https" prefix of the URL for instance -- that assist in providing the full context.

But as these extra pieces are sometimes changing we might want to have an appropriate, context-full content description for the regular tab's security chip as well.

I'm attaching here the UI-Automator Viewer reports I generated to investigate this issue for the offline pages case. To open these one can use that application which is available at:

third_party/android_tools/sdk/tools/bin/uiautomatorviewer

This file contains 4 reports for offline pages being opened:
* In a regular tab with the old style UI
* In a regular tab with the new style UI
* In a CCT with the old style UI
* In a CCT with the new style UI

Deleted: ui-automator-view-of-offline-pages.zip 516 KB

ui-automator-view-of-offline-pages.zip 516 KB Download

We are trying to set an a11y description of the security icon in the toolbar instead of "Site information". We are trying to reuse the existing strings we have for Page Info, but DANGEROUS state is used for several different things: HTTPS connection errors, malware, phishing, etc.  The individual dangerous states have the following strings: 
"This site contains malware"
"This site is deceptive"
"This site contains harmful programs" 

The actual UI just communicates that there is something dangerous about the page. What is the best string to use in that case, i.e. unify all dangerous states, for example "This page is dangerous"/"This site contains dangerous elements."?

Related CL: 1092747.  

My 2 cents:

Thinking from the PoV of someone who doesn't has any disabilities, the red, stop-like icon (I assume that is the one you are referring to) itself won't communicate more than "dangerous" either. One can get more information by opening the info bubble where the kind of thread should be further clarified with text.

One could argue that demanding one more UI action from a user with disabilities is "too much" but if all we are aiming for is having parity with the regular UI than just having the "dangerous" text seems like it should be enough.

Thanks for filing this bug, Carlos. For Android a11y text for the Dangerous icon, I recommend using: "This page is dangerous". Instead of hint "Double-tap to activate", we could also use custom hint text "Double-tap for more information." Because if I hear "this page is dangerous," I'm not going to want to tap "Double-tap to activate", the current hint.

Reason just "dangerous" may not be enough: In the visual UI, we rely not only on the Dangerous icon but also the red background of the interstitial to communicate upon page load that a site is dangerous. The screenreader experience doesn't have the benefit of the red background. So one way to achieve parity is to use a more descriptive string (but still succinct) for the Dangerous icon - which the user can navigate to before landing on page content. 

Is there a proposal for the (i) icon? Something like: "Site's connection is not secure"?

We want to reuse strings we have for Page Info, so we used "Your connection to this site is not secure." for the (i) icon and "Connection is secure." for the lock icon.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7488d261f6dbe1ed6e4a6f9a2cc717dde5756da

commit b7488d261f6dbe1ed6e4a6f9a2cc717dde5756da
Author: Anna Malova <amalova@chromium.org>
Date: Tue Jul 24 18:13:31 2018

Add content description for the security icon based on the security level

Bug:  849861 
Change-Id: Ia09b1c41f7a631502e14cf29509d6908d8eb7eac
Reviewed-on: https://chromium-review.googlesource.com/1092747
Commit-Queue: Anna Malova <amalova@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577608}
[modify] https://crrev.com/b7488d261f6dbe1ed6e4a6f9a2cc717dde5756da/chrome/android/java/res/layout-sw600dp/location_bar.xml
[modify] https://crrev.com/b7488d261f6dbe1ed6e4a6f9a2cc717dde5756da/chrome/android/java/res/layout/custom_tabs_toolbar.xml
[modify] https://crrev.com/b7488d261f6dbe1ed6e4a6f9a2cc717dde5756da/chrome/android/java/res/layout/location_bar_base.xml
[modify] https://crrev.com/b7488d261f6dbe1ed6e4a6f9a2cc717dde5756da/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/b7488d261f6dbe1ed6e4a6f9a2cc717dde5756da/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
[modify] https://crrev.com/b7488d261f6dbe1ed6e4a6f9a2cc717dde5756da/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarDataProvider.java
[modify] https://crrev.com/b7488d261f6dbe1ed6e4a6f9a2cc717dde5756da/chrome/android/java/strings/android_chrome_strings.grd