New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849854 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 529963



Sign in to add a comment

Some elements with a background-attachment of fixed won't display. Changing to "initial" causes the image to display.

Reported by quinn...@gmail.com, Jun 5 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36

Example URL:
http://b3q.ce0.myftpupload.com/

Steps to reproduce the problem:
1. Load http://b3q.ce0.myftpupload.com/
2. Towards the bottom of the page, the section that states "APPLYING FOR FINANCING IS QUICK AND EASY" should have a background image with a background-attachment: fixed
3. The image is not loading at all

What is the expected behavior?
The image should load with the parallax style effect that background-attachment fixed provides

What went wrong?
The image does not load at all unless the background-attachment property is changes from "fixed"

Does it occur on multiple sites: Yes

Is it a problem with a plugin? N/A 

Did this work before? Yes Version 66.0.3359.181 (Official Build) (64-bit)

Does this work in other browsers? Yes

Chrome version: 67.0.3396.62  Channel: stable
OS Version: 10 OS build 15063.1029
Flash Version:
 
Screenshot 155432.png
236 KB View Download
Cc: pbomm...@chromium.org gov...@chromium.org chrishtr@chromium.org
Components: -Blink Blink>Paint
Labels: -Type-Bug -Pri-2 ReleaseBlock-Stable M-68 RegressedIn-67 M-67 M-69 Target-67 FoundIn-67 FoundIn-69 FoundIn-68 Target-68 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on latest Chrome Stable i.e., 67.0.3396.62 on Windows,Mac and Linux :


You are probably looking for a change made after 543290 (known good), but no later than 543291 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/63667eca2a1d86f5de61f29c7c5c6417cc351757..3a3c78a924a686ed0d3f90d765b00cdd78453e11
 
Labels: -M-67 -Target-67
Let's target M68.
Cc: trchen@chromium.org
Reduced test case

Expected: the box should be always have blue background.
Actual: the box's background disappears when scrolled down.

Seems related to incorrect composited background layer offset (with subpixels).
bg-fixed.html
309 bytes View Download
quinnj83@gmail.com, thanks for the report, and sorry for the break. Before the fix is available, you can try to avoid the issue by adding "position: static" on the div with the fixed attachment background.
Blocking: 529963
Cc: -trchen@chromium.org wangxianzhu@chromium.org
Owner: trchen@chromium.org
I think this is the SPv175 version of  bug 529963 .
trchen@ can you take a look?

(My statement in #c3 about composited background layer is incorrect. There is no composited background layer actually.)
Friendly ping to get an update on this issue as it is marked as RBS for M68.
Thanks..!

Comment 7 by pdr@chromium.org, Jun 11 2018

Cc: pdr@chromium.org

Comment 9 by pdr@chromium.org, Jun 13 2018

 Issue 848208  has been merged into this issue.

Comment 10 by pdr@chromium.org, Jun 13 2018

 Issue 852339  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bfdf66c7331d13158b731eeed637d490ace174d

commit 6bfdf66c7331d13158b731eeed637d490ace174d
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Wed Jun 13 22:46:13 2018

[Blink/SPv175] Fix background-attachment:fixed for SPv175

This CL fixes two bugs with background-attachment:fixed computation:

1. Since CL 827671 we switch root layer in PaintInfo whenever the
current transform node changes. This has a side effect that the painting
root layer is no longer guaranteed to be a containing block ancestor of
the current layout object, and AccumulatedScrollOffsetForFixedBackground()
may skip over the painting root all the way to the root. This CL adds
the skipping check to ensure we only collect scroll offsets up to the
painting root.

2. FixedAttachmentPositioningArea() converts the viewport rect to the
space of the current paint context. Prior to SPv175 the border box space
of the painting root is always equivalent to the space of the current
paint context, so FixedAttachmentPositioningArea() did just that. In
SPv175 the painting root may not always create a paint offset
translation in case of a squashed layer, thus can induce an offset from
its transform node. This CL ensures the paint offset taken into account.

BUG= 529963 , 849854 

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib2f84a619235ab4ec6a9bfc695b57aae9d41b808
Reviewed-on: https://chromium-review.googlesource.com/1098313
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567030}
[add] https://crrev.com/6bfdf66c7331d13158b731eeed637d490ace174d/third_party/WebKit/LayoutTests/fast/backgrounds/background-attachment-fixed-on-abs-pos-expected.html
[add] https://crrev.com/6bfdf66c7331d13158b731eeed637d490ace174d/third_party/WebKit/LayoutTests/fast/backgrounds/background-attachment-fixed-on-abs-pos.html
[add] https://crrev.com/6bfdf66c7331d13158b731eeed637d490ace174d/third_party/WebKit/LayoutTests/fast/backgrounds/background-attachment-fixed-squashed-expected.html
[add] https://crrev.com/6bfdf66c7331d13158b731eeed637d490ace174d/third_party/WebKit/LayoutTests/fast/backgrounds/background-attachment-fixed-squashed.html
[modify] https://crrev.com/6bfdf66c7331d13158b731eeed637d490ace174d/third_party/blink/renderer/core/paint/background_image_geometry.cc

Labels: Merge-Request-68

Comment 13 by d...@rewsllc.com, Jun 14 2018

I beleive this is the same issue,
https://codepen.io/anon/pen/jKLKPE

Expecting to see the background remain in place when scrolling the page, and in edge and firefox this is the case. In chrome the background scrolls down and off the screen and blinks white failing to render at all at times.

Google Chrome	67.0.3396.87 (Official Build) (64-bit) (cohort: Stable)

I've seen the same symptom on various websites with parallax backgrounds and condensed down this example. 
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 14 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: TE-Verified-M69 TE-Verified-69.0.3461.2
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #69.0.3461.2 as per the reduced test case given in comment#3.
Attaching screen cast for reference.
Observed that box maintained blue background while scrolling.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version 67.0.3396.62

Thanks...!!
849854.mp4
525 KB View Download
Labels: -Merge-Review-68 Merge-Approved-68
Approved - branch:3440
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 18 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b99f46198c730a42f52a2827daf27f6b7a14dd20

commit b99f46198c730a42f52a2827daf27f6b7a14dd20
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Mon Jun 18 21:26:29 2018

[Blink/SPv175] Fix background-attachment:fixed for SPv175

This CL fixes two bugs with background-attachment:fixed computation:

1. Since CL 827671 we switch root layer in PaintInfo whenever the
current transform node changes. This has a side effect that the painting
root layer is no longer guaranteed to be a containing block ancestor of
the current layout object, and AccumulatedScrollOffsetForFixedBackground()
may skip over the painting root all the way to the root. This CL adds
the skipping check to ensure we only collect scroll offsets up to the
painting root.

2. FixedAttachmentPositioningArea() converts the viewport rect to the
space of the current paint context. Prior to SPv175 the border box space
of the painting root is always equivalent to the space of the current
paint context, so FixedAttachmentPositioningArea() did just that. In
SPv175 the painting root may not always create a paint offset
translation in case of a squashed layer, thus can induce an offset from
its transform node. This CL ensures the paint offset taken into account.

BUG= 529963 , 849854 

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib2f84a619235ab4ec6a9bfc695b57aae9d41b808
Reviewed-on: https://chromium-review.googlesource.com/1098313
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567030}(cherry picked from commit 6bfdf66c7331d13158b731eeed637d490ace174d)
Reviewed-on: https://chromium-review.googlesource.com/1105238
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#420}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[add] https://crrev.com/b99f46198c730a42f52a2827daf27f6b7a14dd20/third_party/WebKit/LayoutTests/fast/backgrounds/background-attachment-fixed-on-abs-pos-expected.html
[add] https://crrev.com/b99f46198c730a42f52a2827daf27f6b7a14dd20/third_party/WebKit/LayoutTests/fast/backgrounds/background-attachment-fixed-on-abs-pos.html
[add] https://crrev.com/b99f46198c730a42f52a2827daf27f6b7a14dd20/third_party/WebKit/LayoutTests/fast/backgrounds/background-attachment-fixed-squashed-expected.html
[add] https://crrev.com/b99f46198c730a42f52a2827daf27f6b7a14dd20/third_party/WebKit/LayoutTests/fast/backgrounds/background-attachment-fixed-squashed.html
[modify] https://crrev.com/b99f46198c730a42f52a2827daf27f6b7a14dd20/third_party/blink/renderer/core/paint/background_image_geometry.cc

Cc: abdulsyed@chromium.org
Pls merge you change to M68 branch 3440 ASAP so we can pick it up for this week Beta release. Merge has to happen latest by 1:00 PM PT tomorrow, Tuesday (06/19), so we can pick it up for Wednesday Beta release.




Status: Fixed (was: Assigned)
Cc: bokan@chromium.org
 Issue 854065  has been merged into this issue.
Labels: TE-Verified-M68 TE-Verified-68.0.3440.33
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #68.0.3440.33 as per the reduced test case given in comment#3.
Attaching screen cast for reference.
Observed that box maintained blue background while scrolling.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version 67.0.3396.62

Thanks...!!
849854.mp4
708 KB View Download
Seems to still be an issue on the Android mobile version of Google Chrome. My version is 68.0.3440.70 (Official Build) (32-bit). OS: Android 8.0.0

I noticed this issue when working on a website, and confirmed it with the reduced test (I put the code in both JSFiddle and Codepen and got the same results). 
Android does not support fixed backgrounds in some situations due to computational cost. This bug was for problems with desktop versions.

Sign in to add a comment