New issue
Advanced search Search tips

Issue 849853 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Can't test a change to cros_chromite.py

Project Member Reported by dgarr...@chromium.org, Jun 5 2018

Issue description

I'm attempting to run uncommitted changes to cros_chromite.py so that I can test them (currently uploaded in https://crrev.com/c/1087771).

I'm using this command to try and test:

cd infra
./run.py infra.tools.cros_pin --debug update master


But it is checking out a clean copy of the chops infra code, and seems to be running that instead. I added new logging messages and even assertions to my change to confirm this.
 
Summary: Can't test a change to cros_chromite.py (was: Can't test a change to cit cros_pin)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6f2d18c39759f92a9a605aae91b38949d4165dcb

commit 6f2d18c39759f92a9a605aae91b38949d4165dcb
Author: Ryan Tseng <hinoka@google.com>
Date: Wed Jun 06 22:34:52 2018

[cros_pin] add --build-revision flag to specify a custom build revision

The idea being that you can call:

cit cros_pin --build-revision refs/changes/<last 2 digit of change ID>/<change ID>/<patchset>

To try out a different version of cros_chromite.py.

Bug:  849853 
Change-Id: Id6874255fe5ab4f71027eea37480f14192cbce46
Reviewed-on: https://chromium-review.googlesource.com/1089636
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/6f2d18c39759f92a9a605aae91b38949d4165dcb/infra/tools/cros_pin/cros_pin.py
[modify] https://crrev.com/6f2d18c39759f92a9a605aae91b38949d4165dcb/infra/tools/cros_pin/checkout.py

Status: Fixed (was: Untriaged)

Sign in to add a comment