WebUI cr-dialog: Tweak title and button-container padding-top. |
||
Issue descriptionBased on latest discussions with bettes@: - title padding-top change from 16px to 20px. - button-container padding-top change from 16px to 24px.
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc9eab356c74d336af3dce361b462c5bf32a870e commit fc9eab356c74d336af3dce361b462c5bf32a870e Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Jun 06 00:04:47 2018 WebUI: cr-dialog, padding adjustments Bug: 849851 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I84564b4c1dce0729ccdcb00b346196c6b3111401 Reviewed-on: https://chromium-review.googlesource.com/1087810 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#564712} [modify] https://crrev.com/fc9eab356c74d336af3dce361b462c5bf32a870e/chrome/browser/resources/print_preview/new/search_dialog_css.html [modify] https://crrev.com/fc9eab356c74d336af3dce361b462c5bf32a870e/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
,
Jun 6 2018
,
Jun 14 2018
Bisected to this CL when investigated the incorrect sizing of a simple extension options dialog: now a vertical scrollbar is displayed. https://chrome.google.com/webstore/detail/stylus/clngdbkpkpeebahjckkjfobafhncgmne Should I open a new issue?
,
Jun 14 2018
Oh, it was reported and fixed already in issue 850877 . |
||
►
Sign in to add a comment |
||
Comment 1 by aee@chromium.org
, Jun 5 2018Status: Started (was: Available)