New issue
Advanced search Search tips

Issue 849819 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 850994



Sign in to add a comment

Create a new API in touch action filter

Project Member Reported by xidac...@chromium.org, Jun 5 2018

Issue description

The TouchActionFilter::OnSetTouchAction can be called in the following 2 case:
1. InputRouterImpl::OnSetTouchAction
2. InputRouterImpl::OnTouchEventAck, when it is a touch start and that the ack state is
      ack_result == INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS

For the first case, we are setting the touch action because there is a event handler. For the second case, we should provide another API to set the allowed_touch_action_ to auto.

With that change, we can add a DCHECK in the TouchActionFilter::OnSetTouchAction to make sure that there is a touch event handler.
 
Alternately, we can remove OnSetTouchAction calls when there is a touch event handler since they should be unnecessary.
sorry, I meant when there is not a touch event handler ^
Right, we should be able to remove the OnSetTouchAction call when there is no touch event handler. Just need to make sure that iframe will call OnHasTouchEventHandler(false) to set the touch action to auto first.
Blockedon: 850994

Sign in to add a comment