New issue
Advanced search Search tips

Issue 849813 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 6
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add team drives debugging info to chrome://drive-internals

Project Member Reported by slangley@chromium.org, Jun 5 2018

Issue description

Specifically the sync status of each team drive.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aee3e871677f10ebd557878ab6654dac8472f7f7

commit aee3e871677f10ebd557878ab6654dac8472f7f7
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Jul 02 05:11:42 2018

Print the team drive id in change list loading log messages.

Prints either the team drive id or "default corpus" when logging message from
change list loader in the chrome://drive-internals logs.

Bug:  849813 
Change-Id: I7463d99308f6c9ee30ce27f7e89641a0cf7b9526
Reviewed-on: https://chromium-review.googlesource.com/1121675
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571821}
[modify] https://crrev.com/aee3e871677f10ebd557878ab6654dac8472f7f7/components/drive/chromeos/change_list_loader.cc
[modify] https://crrev.com/aee3e871677f10ebd557878ab6654dac8472f7f7/components/drive/chromeos/change_list_loader.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71f9a0060dfbaa63319a064bed05f9c432a5e2ac

commit 71f9a0060dfbaa63319a064bed05f9c432a5e2ac
Author: Stuart Langley <slangley@chromium.org>
Date: Wed Jul 04 13:34:44 2018

Report debug status in a table for delta change list updates.

To enable useful formatting of the delta updates for the users default
corpus and each team drive we move the data into a table. This table
will have a row for the default corpus and then a row for each team drive.

Bug:  849813 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I966917d845cd2fb239a53afe0b209a2832c6f582
Reviewed-on: https://chromium-review.googlesource.com/1124128
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572550}
[modify] https://crrev.com/71f9a0060dfbaa63319a064bed05f9c432a5e2ac/chrome/browser/resources/chromeos/drive_internals.html
[modify] https://crrev.com/71f9a0060dfbaa63319a064bed05f9c432a5e2ac/chrome/browser/resources/chromeos/drive_internals.js
[modify] https://crrev.com/71f9a0060dfbaa63319a064bed05f9c432a5e2ac/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fa4e251305c42edee2ba319b74f5bba6abf50d0

commit 8fa4e251305c42edee2ba319b74f5bba6abf50d0
Author: Stuart Langley <slangley@chromium.org>
Date: Fri Jul 06 01:08:11 2018

Pass all team drive start page tokens back in metadata requests.

This patch adds sending back team drive metadata in the GetMetadata
request, but only the start page token and if the drive is refreshing.

Will add last update time and last update error in a follow up CL.

Added test for GetMetadata, I guess there wasn't one before \o/.

Bug:  849813 
Change-Id: Ic850e07422888c9363b89d49341420a8d4204422
Reviewed-on: https://chromium-review.googlesource.com/1126587
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572877}
[modify] https://crrev.com/8fa4e251305c42edee2ba319b74f5bba6abf50d0/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] https://crrev.com/8fa4e251305c42edee2ba319b74f5bba6abf50d0/components/drive/chromeos/file_system.cc
[modify] https://crrev.com/8fa4e251305c42edee2ba319b74f5bba6abf50d0/components/drive/chromeos/file_system.h
[modify] https://crrev.com/8fa4e251305c42edee2ba319b74f5bba6abf50d0/components/drive/chromeos/file_system_interface.h
[modify] https://crrev.com/8fa4e251305c42edee2ba319b74f5bba6abf50d0/components/drive/file_system_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b8a6097a6af9b0f660f8868f80171a65d0d0de0

commit 8b8a6097a6af9b0f660f8868f80171a65d0d0de0
Author: Stuart Langley <slangley@chromium.org>
Date: Fri Jul 06 06:03:58 2018

Record update time, error for team drives and report them on debug page.

Bug:  849813 
Change-Id: I2c2d86b79d26c0647ac4ee1244e8f3b5ac7a8fba
Reviewed-on: https://chromium-review.googlesource.com/1127506
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572907}
[modify] https://crrev.com/8b8a6097a6af9b0f660f8868f80171a65d0d0de0/components/drive/chromeos/file_system.cc
[modify] https://crrev.com/8b8a6097a6af9b0f660f8868f80171a65d0d0de0/components/drive/chromeos/file_system.h
[modify] https://crrev.com/8b8a6097a6af9b0f660f8868f80171a65d0d0de0/components/drive/file_system_unittest.cc

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86e215a79959e7fc54f67fb1381e4869fe096091

commit 86e215a79959e7fc54f67fb1381e4869fe096091
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Jul 09 05:24:53 2018

Show the team drive path as part of the debug info in chrome://drive-internals.

Adding the path makes it easier to parse the debug information that is being
displayed.

Bug:  849813 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ic4dc03e5df3fdbc9286ea17561bec4fbe1abea11
Reviewed-on: https://chromium-review.googlesource.com/1127911
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573222}
[modify] https://crrev.com/86e215a79959e7fc54f67fb1381e4869fe096091/chrome/browser/resources/chromeos/drive_internals.html
[modify] https://crrev.com/86e215a79959e7fc54f67fb1381e4869fe096091/chrome/browser/resources/chromeos/drive_internals.js
[modify] https://crrev.com/86e215a79959e7fc54f67fb1381e4869fe096091/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] https://crrev.com/86e215a79959e7fc54f67fb1381e4869fe096091/components/drive/chromeos/file_system.cc
[modify] https://crrev.com/86e215a79959e7fc54f67fb1381e4869fe096091/components/drive/file_system_metadata.h
[modify] https://crrev.com/86e215a79959e7fc54f67fb1381e4869fe096091/components/drive/file_system_unittest.cc

Sign in to add a comment