Settings: Don't pre-allocate space for incognito checkbox in "add exception dialog". |
||||
Issue descriptionCurrently we pre-allocate white space to hold the "current incognito session" checkbox, which makes the dialog look odd in the normal case, where no incognito window is open. Proposal: Let's have the dialog grow when an incognito dialog is shown, instead of pre-allocating the space. Thoughts?
,
Jun 5 2018
,
Jun 5 2018
The original issue was that the dialog would decrease in size after the incognito status was retrieved causing a flicker ( https://crbug.com/708078 ). It seems preferable to wait until the incognito status is known before opening the dialog.
,
Jun 5 2018
I see, thanks for finding the original issue. Personally I think not pre-allocating size, such that the dialog can only grow once incognito status is retrieved, instead of shrinking is a good trade-off between primary and secondary use cases.
,
Jun 5 2018
np, here is my proposed fix. https://chromium-review.googlesource.com/c/chromium/src/+/1087783
,
Jun 5 2018
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c30abaa308f19182594786411600c8781048267 commit 1c30abaa308f19182594786411600c8781048267 Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Jun 07 23:22:15 2018 Settings: use hidden for incognito checkbox Bug: 849811 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib034544b40403e47e1c7c538b70b93e9d3f6ee8c Reviewed-on: https://chromium-review.googlesource.com/1087783 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#565457} [modify] https://crrev.com/1c30abaa308f19182594786411600c8781048267/chrome/browser/resources/settings/site_settings/add_site_dialog.html [modify] https://crrev.com/1c30abaa308f19182594786411600c8781048267/chrome/browser/resources/settings/site_settings/add_site_dialog.js [modify] https://crrev.com/1c30abaa308f19182594786411600c8781048267/chrome/browser/resources/settings/site_settings/site_list.html [modify] https://crrev.com/1c30abaa308f19182594786411600c8781048267/chrome/browser/resources/settings/site_settings/site_list.js [modify] https://crrev.com/1c30abaa308f19182594786411600c8781048267/chrome/test/data/webui/settings/site_list_tests.js
,
Jun 7 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpa...@chromium.org
, Jun 5 2018