New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849810 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Nothing should be highlighted by default when opening user menu

Project Member Reported by ew...@chromium.org, Jun 5 2018

Issue description

Chrome Version: 69.0.3450.0 (Official Build) canary (64-bit)
OS: Mac OS X

What steps will reproduce the problem?
(1) Enable chrome://flags/#views-browser-window (so the profile chip is in the toolbar instead of top-chrome)
(2) Click the avatar to open the user menu

What is the expected result?
No rows/buttons are highlighted by default

What happens instead?
The first profile row is highlighted by default. See screenshot: https://screenshot.googleplex.com/DzGfvjvX44N.png
 

Comment 1 by ew...@chromium.org, Jun 5 2018

Cc: sabineb@chromium.org
Cc: rachelis@chromium.org
Owner: ew...@chromium.org
Status: Assigned (was: Accepted)
Eli, does the identity team own this piece of UI?
Cc: markchang@chromium.org

Comment 4 by ew...@chromium.org, Jun 19 2018

Cc: msarda@chromium.org
Owner: markchang@chromium.org
Generally, yes, sort of. But this bug was introduced as the result of the changes that were made by the desktop team when moving the user menu from the top Chrome to the toolbar. At least, when I disabled #views-browser-window, I'm not able to repro it. So I think it should probably be looked at by whoever made that change.

Comment 5 by ew...@chromium.org, Jun 22 2018

Friendly ping. Can you loop in the right desktop engineer, Mark? Want to make sure this doesn't get lost.
Labels: -Restrict-View-Google -Hotlist-Teamfood-Feedback Proj-MdRefresh
Owner: robliao@chromium.org
Status: Available (was: Assigned)
Rob, can you ptal and make sure we own this codepath? Estimation if you could, kindly.
Owner: bettes@chromium.org
Status: Assigned (was: Available)
bettes: What is the appropriate interaction here?

Comment 8 by ew...@chromium.org, Jun 26 2018

Cc: ew...@chromium.org ainslie@chromium.org tangltom@chromium.org jtonollo@chromium.org bklmn@chromium.org nepper@chromium.org
 Issue 856657  has been merged into this issue.

Comment 9 by ew...@chromium.org, Jun 26 2018

I believe the appropriate interaction is that we shouldn't highlight anything by default when the menu is opened (see Max's comments in the bug I just merged into this one).

Comment 10 by ew...@chromium.org, Jun 26 2018

Cc: bettes@chromium.org
Labels: M-69
Owner: robliao@chromium.org
Just chatted with ainslie offline. He confirmed that nothing should be highlighted by default (he was the one who noticed this and asked Max to file the bug I merged into this one).

Let's make sure this gets fixed before birthday :)
Cc: kylixrd@chromium.org nyerramilli@chromium.org bsep@chromium.org pkasting@chromium.org rbasuvula@chromium.org
 Issue 857014  has been merged into this issue.
Labels: Hotlist-Polish

Comment 13 by bsep@chromium.org, Jun 28 2018

Cc: -bsep@chromium.org
Owner: bsep@chromium.org
I have context for this so I'll fix it quickly.
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffb81aba54c5995acfc4c9ed2357fdd248506845

commit ffb81aba54c5995acfc4c9ed2357fdd248506845
Author: Bret Sepulveda <bsep@chromium.org>
Date: Thu Jun 28 23:59:31 2018

Fix first profile being highlighted when the avatar button is clicked.

When the avatar button is activated using the keyboard the first profile
should be highlighted. But the new Refresh avatar button was using a
code path that always indicated the keyboard was used.

As a short-term fix, this patch avoids that code path entirely.

Bug:  849810 
Change-Id: I87c32cf76870d92911f227afd74a9dd1e201a4b2
Reviewed-on: https://chromium-review.googlesource.com/1119385
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571333}
[modify] https://crrev.com/ffb81aba54c5995acfc4c9ed2357fdd248506845/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc
[modify] https://crrev.com/ffb81aba54c5995acfc4c9ed2357fdd248506845/chrome/browser/ui/views/profiles/avatar_toolbar_button.h
[modify] https://crrev.com/ffb81aba54c5995acfc4c9ed2357fdd248506845/chrome/browser/ui/views/toolbar/toolbar_view.cc

Comment 15 by bsep@chromium.org, Jun 29 2018

Status: Fixed (was: Assigned)
Labels: -M-69 Group-Toolbar

Sign in to add a comment