New issue
Advanced search Search tips

Issue 849805 link

Starred by 1 user
Status: WontFix
Owner:
tmartino@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update GetIconResourceID to use base::Optional

Project Member Reported by tmartino@chromium.org, Jun 5 2018 
This utility function in autofill_popup_layout_model returns -1 if the resource isn't found. This is outdated; we should really use an Optional instead.

Comment 1 by tmartino@chromium.org, Jun 7 2018

Status: WontFix (was: Assigned)
Actually, 0 is a reserved (but undocumented 🙃) magic number in the IDS space indicating a resource doesn't exist, and should be used instead of a base::Optional.
►

Sign in to add a comment