New issue
Advanced search Search tips

Issue 849802 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Extension popup borders got thick

Reported by woxxom@gmail.com, Jun 5 2018

Issue description

Chrome 69

============================

1. install an extension with a dark-colored popup
   (for example test-ext attached below)
2. click the extension icon to open its popup

Expected: thin 2px borders on top and bottom or no borders at all
Observed: thick 4px borders on top and bottom

============================

Optional step:
3. open chrome://flags/#top-chrome-md
   set its value to "refresh"
   repeat steps 1-2
Observed: SUPER T H I C C 8px borders on top and bottom

============================

The problem here is that these borders are always white and the extension authors can't change their color so the disjointed parts of the popup frame look weird and too prominent when the popup background is dark. 

============================

Bisected to 8cd88c77b560468f1d41938f8d653fd0a22c4232
"Update shadows for bubbles and dialogs for Refresh"
Landed in 69.0.3446.0

    >This patch also gives bubbles and dialogs a corner radius and elevation
    >pre-Refresh. This will cause a small visual change.
 
test-ext.zip
529 bytes Download
2px expected.png
1.9 KB View Download
4px observed - standard top-ui.png
16.9 KB View Download
8px observed - refresh top-ui.png
4.9 KB View Download

Comment 1 by bsep@chromium.org, Jun 5 2018

Labels: -Pri-3 Proj-MdRefresh Pri-2
Owner: bsep@chromium.org
Status: Assigned (was: Unconfirmed)
Confirmed using this extension https://chrome.google.com/webstore/detail/lighthouse/blipmdconlkpinefehnmjammfjpmpbjk

On our short timeframe, the right thing to do is probably to not apply a corner radius to extension popup bubbles.


Comment 2 by bsep@chromium.org, Jun 7 2018

Labels: Hotlist-Helper
Cc: bsep@chromium.org
Owner: ----
Status: Available (was: Assigned)

Comment 4 by manukh@chromium.org, Jun 13 2018

Which OS was the bug observed on?
I was unable to reproduce locally on linux; tried both latest master (d559ecd55e38) and the mentioned commit (8cd88c77b560).

Comment 5 by woxxom@gmail.com, Jun 13 2018

Windows 7

Comment 6 by bsep@chromium.org, Jun 13 2018

Cc: -bsep@chromium.org
Owner: bsep@chromium.org
Status: Fixed (was: Available)
Fixed by revert, see bug 822075

Sign in to add a comment