New issue
Advanced search Search tips

Issue 849797 link

Starred by 2 users
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Nov 26
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
M-X

Blocking:
issue 847873



Sign in to add a comment

[MacViews] Show() with SHOW_STATE_NORMAL improperly implies activation

Project Member Reported by a...@chromium.org, Jun 5 2018 
NativeWidgetAura::ShowWithWindowState() with SHOW_STATE_NORMAL will show the widget, and then make a call to the delegate for CanActivate() to know if it can activate the window.

NativeWidgetMac::ShowWithWindowState() with SHOW_STATE_NORMAL will always activate the window.

NativeWidgetMac needs to be able to show a window without activating it.

Comment 1 by ellyjo...@chromium.org, Jun 6 2018

Labels: MacViews-Cleanup M-X Proj-MacViews
Status: Assigned (was: Untriaged)

Comment 2 by tapted@chromium.org, Jun 15 2018

Components: Internals>Views
grumble.. Widget::Show() already has

    CanActivate()
        ? native_widget_->Show()
        : native_widget_->ShowWithWindowState(ui::SHOW_STATE_INACTIVE);

We probably shouldn't be checking CanActivate() in multiple places.

Comment 3 by robliao@chromium.org, Jul 12

Labels: Group-Focus_Input_Selection_Activation_KeyState

Comment 4 by jmukthavaram@chromium.org, Nov 23

Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
***UI Mass Triage ***

Adding respective labels for expert review.

Comment 5 by ellyjo...@chromium.org, Nov 26

Status: Fixed (was: Assigned)
This issue is Fixed now by NativeWidgetMac::Show() having the correct behavior for ui::SHOW_STATE_INACTIVE.
►

Sign in to add a comment