New issue
Advanced search Search tips

Issue 849790 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 825890



Sign in to add a comment

Add gesture to media controls to expand into display cutout

Project Member Reported by beccahughes@chromium.org, Jun 5 2018

Issue description

Add gesture to media controls to expand into display cutout
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de89860233d43a4eac389d00f29d5e8d7021760c

commit de89860233d43a4eac389d00f29d5e8d7021760c
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Jun 15 17:59:48 2018

[Display Cutout] Add a pinch gesture to expand into cutout

Add a pinch gesture to the media controls to expand into the
cutout area.

This also adds a method to document that allows us to overrride
the viewport fit value set by the page.

BUG= 849790 

Change-Id: Ibf74497a6f8d26b2a25669a12e03c2b3f435ade1
Reviewed-on: https://chromium-review.googlesource.com/1090052
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567729}
[modify] https://crrev.com/de89860233d43a4eac389d00f29d5e8d7021760c/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/de89860233d43a4eac389d00f29d5e8d7021760c/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/de89860233d43a4eac389d00f29d5e8d7021760c/third_party/blink/renderer/core/dom/document_test.cc
[modify] https://crrev.com/de89860233d43a4eac389d00f29d5e8d7021760c/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/de89860233d43a4eac389d00f29d5e8d7021760c/third_party/blink/renderer/modules/media_controls/BUILD.gn
[add] https://crrev.com/de89860233d43a4eac389d00f29d5e8d7021760c/third_party/blink/renderer/modules/media_controls/media_controls_display_cutout_delegate.cc
[add] https://crrev.com/de89860233d43a4eac389d00f29d5e8d7021760c/third_party/blink/renderer/modules/media_controls/media_controls_display_cutout_delegate.h
[add] https://crrev.com/de89860233d43a4eac389d00f29d5e8d7021760c/third_party/blink/renderer/modules/media_controls/media_controls_display_cutout_delegate_test.cc
[modify] https://crrev.com/de89860233d43a4eac389d00f29d5e8d7021760c/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/de89860233d43a4eac389d00f29d5e8d7021760c/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
[modify] https://crrev.com/de89860233d43a4eac389d00f29d5e8d7021760c/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d73bac54c969892a68d109f7f30b0d1def1ac5a

commit 6d73bac54c969892a68d109f7f30b0d1def1ac5a
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Jun 18 20:38:50 2018

[Display Cutout] Add feature for media controls

Add a feature for media controls to recognise a gesture
and expand into the display cutout.

BUG= 849790 

Change-Id: Ice6de82f4fb94e366fca68338a55236fa1f05c8a
Reviewed-on: https://chromium-review.googlesource.com/1087710
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568142}
[modify] https://crrev.com/6d73bac54c969892a68d109f7f30b0d1def1ac5a/chrome/browser/about_flags.cc
[modify] https://crrev.com/6d73bac54c969892a68d109f7f30b0d1def1ac5a/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/6d73bac54c969892a68d109f7f30b0d1def1ac5a/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/6d73bac54c969892a68d109f7f30b0d1def1ac5a/media/base/media_switches.cc
[modify] https://crrev.com/6d73bac54c969892a68d109f7f30b0d1def1ac5a/media/base/media_switches.h
[modify] https://crrev.com/6d73bac54c969892a68d109f7f30b0d1def1ac5a/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/6d73bac54c969892a68d109f7f30b0d1def1ac5a/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/6d73bac54c969892a68d109f7f30b0d1def1ac5a/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment