WebUI Polymer 2: Update Polymer.Templatizer usage |
||
Issue descriptionThere are some breaking changes in the Polymer.Templatizer behavior across Polymer 1 and Polymer 2, see [1]. We currently use that in two places [2] and [3]. [1] https://github.com/Polymer/polymer/blob/2.x/lib/legacy/templatizer-behavior.html#L37-L88 [2] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js [3] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/controls/settings_idle_load.js
,
Jun 5 2018
1st CL landed https://chromium-review.googlesource.com/c/chromium/src/+/1087396 (somehow the bot was not automatically updated).
,
Jun 7 2018
2nd (and final) CL candidate is at https://chromium-review.googlesource.com/c/chromium/src/+/1091653.
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29d93f0b0b37f8f3137b4a2a8cce791f73135f1c commit 29d93f0b0b37f8f3137b4a2a8cce791f73135f1c Author: dpapad <dpapad@chromium.org> Date: Thu Jun 07 23:57:54 2018 WebUI Polymer 2: Update Polymer.Templatizer usage in settings-idle-load. Need to override |_forwardHostPropV2| method for Polymer 2. |_forwardParentProp| and |_forwardParentPath| can be removed after Polymer 2 migration is done. Bug: 849788 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic77854582a5184fa41fe5dca02724c9f2cc7dc7d Reviewed-on: https://chromium-review.googlesource.com/1091653 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#565470} [modify] https://crrev.com/29d93f0b0b37f8f3137b4a2a8cce791f73135f1c/chrome/browser/resources/settings/controls/settings_idle_load.js
,
Jun 8 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by dpa...@chromium.org
, Jun 5 2018