ash_content_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) |
||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of lambroslambrou@chromium.org From the log: Direct leak of 8 byte(s) in 1 object(s) allocated from: #0 0x5090b2 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3 #1 0x8a58634 in ash::KioskAppsButton::KioskAppsButton(std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, gfx::ImageSkia const&) ash/shelf/login_shelf_view.cc:145:21 #2 0x8a572c3 in ash::LoginShelfView::LoginShelfView(ash::LockScreenActionBackgroundController*) ash/shelf/login_shelf_view.cc:244:11 #3 0x85fe2f7 in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:182:15 #4 0x85e0ffa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:78:27 ... Builders failed on: - Linux Chromium OS ASan LSan Tests (1): https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29
,
Jun 5 2018
dcheng@: Please take a look? Is this something we should revert, or can you land a fix?
,
Jun 5 2018
Reassigning to the actual author of the CL, whoops! :) Please take a look.
,
Jun 5 2018
Reverted CL at revision 99a3e243f58070496a371ef66899da124eefd45e.
,
Jun 5 2018
Also similar failings: - ash_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) https://chromium-swarm.appspot.com/user/task/3de9f8c101667d10 - mash_ash_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) https://chromium-swarm.appspot.com/user/task/3de9f8c40060f210 - unit_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 - mash_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) https://chromium-swarm.appspot.com/user/task/3de9f94610d37110
,
Jun 6 2018
I relanded with a fix for the memory leak here: https://chromium-review.googlesource.com/c/chromium/src/+/1087667 Thanks for letting me know about this breakage. :) Marking this as fixed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by lambroslambrou@chromium.org
, Jun 5 2018