New issue
Advanced search Search tips

Issue 849772 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Task

Blocked on:
issue 715355
issue 719959
issue 723955
issue 849497



Sign in to add a comment

Enable team drives by default for file manager.

Project Member Reported by slangley@chromium.org, Jun 5 2018

Issue description

Turn on team drives feature flag by default.
 
Blockedon: 719959
Cc: -sashab@chromium.org slangley@chromium.org
Owner: sashab@chromium.org
Status: Assigned (was: Available)
SGTM, this is waiting on sync and capabilities (and the failing tests). Once they're done, let's flip the flag :D


Owner: slangley@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c981ac6931cc33f4b48dad87b144e517fd73333e

commit c981ac6931cc33f4b48dad87b144e517fd73333e
Author: Stuart Langley <slangley@chromium.org>
Date: Thu Jun 21 14:38:25 2018

Enable --team-drives flag by default

Rename to --disable-team-drives for disabling.

Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1103986.

sashab@ is on vacation so I am landing her changes in this CL, with fixes
for failing unit tests.

Bug:  849772 
Change-Id: I37260458a60f69d2e95d87afbf87213456131c29
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1108241
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569256}
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/chrome/browser/about_flags.cc
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/components/drive/about_resource_loader_unittest.cc
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/components/drive/change_list_loader_unittest.cc
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/components/drive/change_list_processor_unittest.cc
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/components/drive/drive_file_util_unittest.cc
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/components/drive/file_system_unittest.cc
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/components/drive/resource_metadata_unittest.cc
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/components/drive/start_page_token_loader_unittest.cc
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/components/drive/team_drive_change_list_loader_unittest.cc
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/components/drive/team_drive_list_loader_unittest.cc
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/google_apis/drive/drive_switches.cc
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/google_apis/drive/drive_switches.h
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/ui/file_manager/file_manager/background/js/volume_info_impl.js
[modify] https://crrev.com/c981ac6931cc33f4b48dad87b144e517fd73333e/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment