New issue
Advanced search Search tips

Issue 849769 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Autotest: Wait for Cryptohome by default

Project Member Reported by ljusten@chromium.org, Jun 5 2018

Issue description

Andrey Pronin:

Yes, it makes sense to wait for cryptohomed in tests in general. E.g., unlike the old tpm 1.2 case, for devices with H1 the daemon is started significantly later, already after login-prompt-visible.
I'm not aware of any ongoing issues with autotests, but we had issues with Chome not waiting for cryptohomed, for example.
 
Cc: apronin@chromium.org emaxx@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b927578485a23c2a3dd15048a8f87d82a0b9b204

commit b927578485a23c2a3dd15048a8f87d82a0b9b204
Author: Lutz Justen <ljusten@chromium.org>
Date: Mon Jun 25 17:52:49 2018

cryptohome.py: Wait for D-Bus by default

Waits 30 seconds for the initial D-Bus connection by default. On devices
with the new H1 TPM, cryptohomed is started significantly later than on
devices with the old 1.2 chip, already after login-prompt-visible. There
have been issues with Chome not waiting for cryptohomed. The
enterprise_AuthPolicyDaemon autotest had a similar issue (see
 crbug.com/843093 ) and possibly other tests as well. This CL addresses
this proactively.

BUG= chromium:849769 
TEST=cros tryjob -g 1108206 --hwtest eve-paladin-tryjob

Change-Id: I743b8bd920f12972c66fbc0aa1f62fba03e674c6
Reviewed-on: https://chromium-review.googlesource.com/1108206
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/b927578485a23c2a3dd15048a8f87d82a0b9b204/client/cros/cryptohome.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/autotest-private/+/26707f6aa46e804c8871dd14344428e33541f664

commit 26707f6aa46e804c8871dd14344428e33541f664
Author: Lutz Justen <ljusten@chromium.org>
Date: Mon Jun 25 17:52:49 2018

Status: Fixed (was: Assigned)

Sign in to add a comment