Issue metadata
Sign in to add a comment
|
12KB regression in resource_sizes (MonochromePublic.apk) at 564477:564477 |
||||||||||||||||||||
Issue descriptionCaused by “Reland "[array] Implement Array.p.sort in Torque"” Commit: aff803454745935ba7843257fcf10dce41dc33b1 Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=564477 Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase Based on the graph: 12kb of native code. It's not clear to me whether or not this increase was expected. Please have a look and either: 1. Close as “Won't Fix” with a short justification, or 2. Land a revert / fix-up. adding jgruber@ as the owner since he is the one that handled issue 837282
,
Jun 5 2018
Assigning to sheriff hablich@chromium.org because this autoroll is the only CL in range: Update V8 to version 6.9.79. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/45c9adae..acb93ae9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I02a84b9d703ebba4d477b59c0c699e83c290efb5 Reviewed-on: https://chromium-review.googlesource.com/1086971 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#564477}
,
Jun 5 2018
Supersize output:
Section Legend: t=.text, r=.rodata, R=.data.rel.ro, d=.data, b=.bss, x=.dex, m=.dex.method, p=.pak.translations, P=.pak.nontranslated, o=.other
Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path
------------------------------------------------------------
~ 0) 12556 (101.3%) o@0x0 12556 (1472820->1485376) v8/snapshot_blob_32.bin
assets/snapshot_blob_32.bin
~ 1) 11118 (89.7%) o@0x0 -1438 (0->0) {no path}
Overhead: ELF file
~ 2) 10850 (87.6%) o@0x0 -268 (0->0) {no path}
Overhead: APK file
+ 3) 11116 (89.7%) t@0xcf2190 266 (0->264) v8/src/code-stub-assembler.cc
v8::internal::CodeStubAssembler::Check
~ 4) 11322 (91.4%) t@0xcf2a14 206 (826->1032) v8/src/code-stub-assembler.cc
v8::internal::CodeStubAssembler::AllocateRaw
+ 5) 11448 (92.4%) t@0xcf22b8 126 (0->124) v8/src/code-stub-assembler.cc
v8::internal::CodeStubAssembler::Check
+ 6) 11546 (93.2%) t@Group 98 (0->96) v8/src/code-stub-assembler.cc
std::__ndk1::__function::__func<>::~__func (count=2)
+ 7) 11622 (93.8%) t@0x0 76 (0->0) {no path}
** aggregate padding of diff'ed symbols
+ 8) 11686 (94.3%) t@0xcf27bc 64 (0->64) v8/src/code-stub-assembler.cc
v8::internal::CodeStubAssembler::IsValidPositiveSmi
+ 9) 11744 (94.8%) r@0x2721fe 58 (0->58) v8/src/code-stub-assembler.cc
string literal
+ 10) 11796 (95.2%) t@0xcf2360 52 (0->52) v8/src/code-stub-assembler.cc
std::__ndk1::function<>::function<>
+ 11) 11840 (95.6%) t@0xcf52a4 44 (0->44) v8/src/code-stub-assembler.cc
std::__ndk1::__function::__func<>::__clone const
+ 12) 11882 (95.9%) t@0xcf52fe 42 (0->42) v8/src/code-stub-assembler.cc
v8::internal::CodeStubAssembler::Check const
+ 13) 11924 (96.2%) t@0xd0b322 42 (0->42) v8/src/compiler/code-assembler.cc
v8::internal::compiler::CodeAssembler::StringConstant
+ 14) 11964 (96.6%) t@0xcf53b6 40 (0->40) v8/src/code-stub-assembler.cc
v8::internal::CodeStubAssembler::FillFixedArrayWithValue const
- 15) 11924 (96.2%) t@0x0 -40 (40->0) v8/src/code-stub-assembler.cc
v8::internal::CodeStubAssembler::FillFixedArrayWithValue const
+ 16) 11962 (96.6%) r@0x2668d9 38 (0->38) v8/src/code-stub-assembler.cc
string literal
+ 17) 11998 (96.8%) R@0x28edf4c 36 (0->36) v8/src/code-stub-assembler.cc
std::__ndk1::__function::__func<> [vtable]
+ 18) 12034 (97.1%) R@0x28edf70 36 (0->36) v8/src/code-stub-assembler.cc
std::__ndk1::__function::__func<> [vtable]
+ 19) 12070 (97.4%) R@0x28edf94 36 (0->36) v8/src/code-stub-assembler.cc
std::__ndk1::__function::__func<> [vtable]
+ 20) 12106 (97.7%) R@0x28edfb8 36 (0->36) v8/src/code-stub-assembler.cc
std::__ndk1::__function::__func<> [vtable]
- 21) 12070 (97.4%) R@0x0 -36 (36->0) v8/src/code-stub-assembler.cc
std::__ndk1::__function::__func<> [vtable]
- 22) 12034 (97.1%) R@0x0 -36 (36->0) v8/src/code-stub-assembler.cc
std::__ndk1::__function::__func<> [vtable]
+ 23) 12070 (97.4%) t@0xcf52d0 36 (0->36) v8/src/code-stub-assembler.cc
std::__ndk1::__function::__func<>::__clone const
+ 24) 12106 (97.7%) t@0xcf536c 36 (0->36) v8/src/code-stub-assembler.cc
std::__ndk1::__function::__func<>::__clone const
- 25) 12070 (97.4%) t@0x0 -36 (36->0) v8/src/code-stub-assembler.cc
std::__ndk1::__function::__func<>::__clone const
+ 26) 12106 (97.7%) r@0x1947da 36 (0->36) v8/src/code-stub-assembler.cc
string literal
+ 27) 12138 (98.0%) t@0xcf5328 32 (0->32) v8/src/code-stub-assembler.cc
******************************Resource Sizes Diff******************************
MonochromePublic.apk_Breakdown (+12,354 bytes)
-268 bytes Zip Overhead
+12,556 bytes V8 Snapshots size
+64 bytes Native code size
+2 bytes Package metadata size
MonochromePublic.apk_Specifics
+12,354 bytes normalized apk size
+64 bytes main lib size
,
Jun 5 2018
Thanks for checking, 12K is probably an acceptable size for the Array.p.sort builtin - this is expected. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jun 5 2018