Issue metadata
Sign in to add a comment
|
[MacViews-Browser] Window Frame is blank when starting Chrome |
||||||||||||||||||||||
Issue descriptionChrome Version: Version 69.0.3450.0 Canary OS: macOS 10.13.5 What steps will reproduce the problem? (1) Enable MacViews-Browser (2) Quit Chrome Canary (3) Start Chrome Canary What is the expected result? A window frame with all browser elements. What happens instead? The window frame is blank for a second. A screencast is attached. Looks like a recent regression in MacViews Mode. Thanks for looking into this issue in advance, Mehmet
,
Jun 19 2018
,
Jun 22 2018
,
Jun 28 2018
,
Jun 28 2018
Any progress here as this is marked as P1 for M69?
,
Jul 2
,
Jul 12
,
Jul 12
,
Jul 12
I debugged this a little bit locally, and this just appears to be a timeout. We wait at most 250 msec for the frame to arrive from the GPU process, and, at startup, that's just too short. On a debug build I need 2.5 seconds (but that's a debug build...). Because it looks so bad when we have a blank window, we should detect this situation, and have an extra-long timeout for it.
,
Jul 12
I think we originally had the UI timeout at ~5 seconds. Maybe it should just be set to that or something similar? There's never a situation where we want the window to display in an inconsistent state as long as content times out sooner.
,
Jul 12
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51181f475ceacf8bc0c9c09e5808f9eb7be04a2e commit 51181f475ceacf8bc0c9c09e5808f9eb7be04a2e Author: Sidney San Martín <sdy@chromium.org> Date: Thu Jul 12 21:34:09 2018 Increase the UI paint timeout to 5 seconds. This fixes the first browser window appearing blank for a moment. In general, it's better to block than to show the UI in an inconsistent state. Web content should *not* wait this long. Bug: 849762 Change-Id: I2b73e52a0425ee6fa583fcddc0300dc8a2d3ad73 Reviewed-on: https://chromium-review.googlesource.com/1135119 Commit-Queue: Sidney San Martín <sdy@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#574731} [modify] https://crrev.com/51181f475ceacf8bc0c9c09e5808f9eb7be04a2e/ui/views/cocoa/bridged_native_widget.mm
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/356993f45e105380f1ac1db6894e6038830d8569 commit 356993f45e105380f1ac1db6894e6038830d8569 Author: Taiju Tsuiki <tzik@chromium.org> Date: Fri Jul 13 03:07:33 2018 Revert "Increase the UI paint timeout to 5 seconds." This reverts commit 51181f475ceacf8bc0c9c09e5808f9eb7be04a2e. Reason for revert: Speculatively revert for resolving the bot failure on the CI: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14387 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28041 Original change's description: > Increase the UI paint timeout to 5 seconds. > > This fixes the first browser window appearing blank for a moment. In > general, it's better to block than to show the UI in an inconsistent > state. Web content should *not* wait this long. > > Bug: 849762 > Change-Id: I2b73e52a0425ee6fa583fcddc0300dc8a2d3ad73 > Reviewed-on: https://chromium-review.googlesource.com/1135119 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574731} TBR=ellyjones@chromium.org,ccameron@chromium.org,sdy@chromium.org Change-Id: I80bd11b7478bd1b40b11c9c71aa75de65a874da9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849762 Reviewed-on: https://chromium-review.googlesource.com/1136131 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#574823} [modify] https://crrev.com/356993f45e105380f1ac1db6894e6038830d8569/ui/views/cocoa/bridged_native_widget.mm
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfcd515faa1cf32cbf7bffcfadd9e612868ccc5d commit cfcd515faa1cf32cbf7bffcfadd9e612868ccc5d Author: Christopher Cameron <ccameron@chromium.org> Date: Fri Jul 13 13:51:11 2018 Disable CATransactionCoordinator in tests Tests that use the fake or in-process context factory won't actually produce the CALayerParams structure that un-blocks the CATransactionCoordinator. When the CATransactionCoordinator's timeout was increased to 5 seconds, this started causing test timeouts. Disabling it for these tests should improve the test running time substantially. Bug: 849762 Change-Id: I05bb2fa07611d6a5b3e65cc2417a6af2111f2dd4 Reviewed-on: https://chromium-review.googlesource.com/1136033 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#574900} [modify] https://crrev.com/cfcd515faa1cf32cbf7bffcfadd9e612868ccc5d/ui/accelerated_widget_mac/ca_transaction_observer.h [modify] https://crrev.com/cfcd515faa1cf32cbf7bffcfadd9e612868ccc5d/ui/accelerated_widget_mac/ca_transaction_observer.mm [modify] https://crrev.com/cfcd515faa1cf32cbf7bffcfadd9e612868ccc5d/ui/compositor/test/fake_context_factory.cc [modify] https://crrev.com/cfcd515faa1cf32cbf7bffcfadd9e612868ccc5d/ui/compositor/test/in_process_context_factory.cc
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d59e8736bc3db9b6be807643ad1d6a9273625e89 commit d59e8736bc3db9b6be807643ad1d6a9273625e89 Author: Sidney San Martín <sdy@chromium.org> Date: Fri Jul 13 13:54:17 2018 Reland "Increase the UI paint timeout to 5 seconds." This reverts commit 356993f45e105380f1ac1db6894e6038830d8569. Reason for revert: Test timeouts should be fixed by crrev/c/1136033. Original change's description: > Revert "Increase the UI paint timeout to 5 seconds." > > This reverts commit 51181f475ceacf8bc0c9c09e5808f9eb7be04a2e. > > Reason for revert: > Speculatively revert for resolving the bot failure on the CI: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14387 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28041 > > Original change's description: > > Increase the UI paint timeout to 5 seconds. > > > > This fixes the first browser window appearing blank for a moment. In > > general, it's better to block than to show the UI in an inconsistent > > state. Web content should *not* wait this long. > > > > Bug: 849762 > > Change-Id: I2b73e52a0425ee6fa583fcddc0300dc8a2d3ad73 > > Reviewed-on: https://chromium-review.googlesource.com/1135119 > > Commit-Queue: Sidney San Martín <sdy@chromium.org> > > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: ccameron <ccameron@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#574731} > > TBR=ellyjones@chromium.org,ccameron@chromium.org,sdy@chromium.org > > Change-Id: I80bd11b7478bd1b40b11c9c71aa75de65a874da9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 849762 > Reviewed-on: https://chromium-review.googlesource.com/1136131 > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574823} TBR=ellyjones@chromium.org,ccameron@chromium.org,sdy@chromium.org,tzik@chromium.org Change-Id: Ibfd8e40c1795e0d0f04e7373c66a6b85c9b0c8fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849762 Reviewed-on: https://chromium-review.googlesource.com/1136551 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#574901} [modify] https://crrev.com/d59e8736bc3db9b6be807643ad1d6a9273625e89/ui/views/cocoa/bridged_native_widget.mm
,
Jul 13
,
Jul 16
Tested this issue on Mac 10.13.5 on the reported chrome version 69.0.3450.0 and latest chrome version 69.0.3493.0. Steps: ------ 1. Launched Chrome and enabled the flag # MacViews-Browser 2. Closed chrome and canary relaunched We have Observed that window frame is blank for a second @Reporter: Please find the attached screen-cast and let us know if we have missed anything in the process. Could you please help in verifying the fix. Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Jun 6 2018Status: Assigned (was: Untriaged)