New issue
Advanced search Search tips

Issue 849759 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 20
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Protect UsageTimeLimit policy with a feature flag.

Project Member Reported by hgrandinetti@google.com, Jun 5 2018

Issue description

The UsageTimeLimit policy won't be available until m69, so its code should be protected with a flag.
 
Labels: Merge-Approved-68
Labels: -Merge-Approved-68 Merge-Request-68 OS-Chrome
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 11 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8cf72233e1d2f5e17bec41088672e80ec46067f

commit c8cf72233e1d2f5e17bec41088672e80ec46067f
Author: Henrique Grandinetti <hgrandinetti@chromium.org>
Date: Thu Jun 14 01:35:49 2018

Add experiment flag to protect UsageTimeLimit policy implementation.

Bug:  849759 
Change-Id: I932a5530cf213660c85009f63970fe3edb8ed039
Reviewed-on: https://chromium-review.googlesource.com/1072587
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564746}(cherry picked from commit 68d4f6ecae0952a47f75069d4be32ab90401f1eb)
Reviewed-on: https://chromium-review.googlesource.com/1096194
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#358}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/c8cf72233e1d2f5e17bec41088672e80ec46067f/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/c8cf72233e1d2f5e17bec41088672e80ec46067f/chrome/common/chrome_features.cc
[modify] https://crrev.com/c8cf72233e1d2f5e17bec41088672e80ec46067f/chrome/common/chrome_features.h
[modify] https://crrev.com/c8cf72233e1d2f5e17bec41088672e80ec46067f/chrome/test/data/policy/policy_test_cases.json

Status: Fixed (was: Assigned)

Sign in to add a comment