Issue metadata
Sign in to add a comment
|
news.google.com popups are blocked |
||||||||||||||||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): M68, M69 iOS Version: iOS 11 Device: iPhone Steps to reproduce: 1.) Load news.google.com 2.) Tap on any article Observed behavior: Pop-ups blocked infobar appears Expected behavior: A child window with an article should be open
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6943fdf89cf1e7a81b858df0d2f953ff127b506e commit 6943fdf89cf1e7a81b858df0d2f953ff127b506e Author: Eugene But <eugenebut@google.com> Date: Thu Jun 07 22:27:32 2018 Use -userIsInteracting for user gesture detection if voice over is off. Notable changes: - updated testLinkWithBlankTargetWithoutUserGesture to execute script without user gesture - removed NavigationActionInitiationType::kScriptInitiated because there is no way to tell if action was initiated by the script (coordinates or SyntheticClickType can be 0 for valid link clicks). - Updated webView:createWebViewWithConfiguration: to use GetNavigationActionInitiationTypeWithVoiceOverOn, because there is no need to inspect action.description when Voice over is Off. -userIsInteracting can give false positives for link clicks, which is ok. window.open also have these false positives, so if the page wants to open a popup, it can exploit window.open. Bug: 849749 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8c179c9df2d6bce3253e46272c2f14e0eb6224bc Reviewed-on: https://chromium-review.googlesource.com/1087389 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#565442} [modify] https://crrev.com/6943fdf89cf1e7a81b858df0d2f953ff127b506e/ios/chrome/browser/web/window_open_by_dom_egtest.mm [modify] https://crrev.com/6943fdf89cf1e7a81b858df0d2f953ff127b506e/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/6943fdf89cf1e7a81b858df0d2f953ff127b506e/ios/web/web_state/ui/wk_navigation_action_util.h [modify] https://crrev.com/6943fdf89cf1e7a81b858df0d2f953ff127b506e/ios/web/web_state/ui/wk_navigation_action_util.mm [modify] https://crrev.com/6943fdf89cf1e7a81b858df0d2f953ff127b506e/ios/web/web_state/ui/wk_navigation_action_util_unittest.mm
,
Jun 7 2018
,
Jun 7 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 7 2018
Let's get canary verification for this please.
,
Jun 11 2018
+lindsayw@ for visibility
,
Jun 11 2018
Not completely fixed. Popup blocker is still displayed if the device has VoiceOver enabled. Tested on iPhone6S, iOS11.4, M69.0.3455.0 canary
,
Jun 11 2018
Shrikhang, do you see a popup blocker with VoiceOver enabled in M67?
,
Jun 11 2018
Yes
,
Jun 11 2018
Thanks. Please file a separate bug for Voice Over. That's a separate problem, which we can't actually fix.
,
Jun 12 2018
Verified on chrome canary version on iPhone 8 and iPad 2018 with iOS 11.4, following the steps mentioned in comment #0. Article is opened in a new window. Looks good.
,
Jun 12 2018
Approved!
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27813b0c26e46ed1906d9cab2d379c3b9c245961 commit 27813b0c26e46ed1906d9cab2d379c3b9c245961 Author: Eugene But <eugenebut@google.com> Date: Tue Jun 12 15:41:03 2018 Use -userIsInteracting for user gesture detection if voice over is off. Notable changes: - updated testLinkWithBlankTargetWithoutUserGesture to execute script without user gesture - removed NavigationActionInitiationType::kScriptInitiated because there is no way to tell if action was initiated by the script (coordinates or SyntheticClickType can be 0 for valid link clicks). - Updated webView:createWebViewWithConfiguration: to use GetNavigationActionInitiationTypeWithVoiceOverOn, because there is no need to inspect action.description when Voice over is Off. -userIsInteracting can give false positives for link clicks, which is ok. window.open also have these false positives, so if the page wants to open a popup, it can exploit window.open. TBR=eugenebut@google.com (cherry picked from commit 6943fdf89cf1e7a81b858df0d2f953ff127b506e) Bug: 849749 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8c179c9df2d6bce3253e46272c2f14e0eb6224bc Reviewed-on: https://chromium-review.googlesource.com/1087389 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#565442} Reviewed-on: https://chromium-review.googlesource.com/1097229 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#301} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/27813b0c26e46ed1906d9cab2d379c3b9c245961/ios/chrome/browser/web/window_open_by_dom_egtest.mm [modify] https://crrev.com/27813b0c26e46ed1906d9cab2d379c3b9c245961/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/27813b0c26e46ed1906d9cab2d379c3b9c245961/ios/web/web_state/ui/wk_navigation_action_util.h [modify] https://crrev.com/27813b0c26e46ed1906d9cab2d379c3b9c245961/ios/web/web_state/ui/wk_navigation_action_util.mm [modify] https://crrev.com/27813b0c26e46ed1906d9cab2d379c3b9c245961/ios/web/web_state/ui/wk_navigation_action_util_unittest.mm
,
Jun 13 2018
Srikanth, re: comment 10 once filed can you please link to the separately filed bug from here just for record?
,
Jun 13 2018
http://crbug/852425 is reported for voice over issue.
,
Jun 13 2018
Thank you!
,
Jun 20 2018
Verified in 68.0.3440.30 Beta in iPad Air(iOS 11.3.1), iPhone 7(iOS 11.4) Articles opens up as expected no block popups infobar displayed, looks good. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by kariahda@chromium.org
, Jun 7 2018