New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849746 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 732555



Sign in to add a comment

Android OOP-D coverage on waterfall

Project Member Reported by ericrk@chromium.org, Jun 5 2018

Issue description

Until we launch OOP-D on Android, we should have parallel OOP-D / non-OOP-D coverage on the waterfall (set up similarly to other platforms). This will help prevent regressions.

jonross@ - it sounds like you've done similar work on Aura platforms - would you be able to help with this? Otherwise can you link to the related CLs and we can replicate on Android.
 
Status: Started (was: Assigned)
Yeah I can take this on.

I've quickly ran all tests in an experiment: https://chromium-review.googlesource.com/c/chromium/src/+/1087782

This was without filters, and showed many expected failures. However there are other timeouts and failures present. Many of these overlap with the failures I saw when running just Surface Sync on Android. fsamuel@ will be taking a look at that.

I'll add the tests to an FYI bot to start. Once we get progress driving down failures we can revisit CQ coverage:

https://chromium-review.googlesource.com/c/chromium/src/+/1090075
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7732289c78c3fad9970a6f0dc25519c3e57aa294

commit 7732289c78c3fad9970a6f0dc25519c3e57aa294
Author: jonross <jonross@chromium.org>
Date: Wed Jun 13 12:57:51 2018

Add Viz FYI tests to Mojo Android FYI

The Viz team is beginning to target Android. We'd like to begin running our
tests regularly to catch unknown bugs, and regressions.

This adds our FYI test config to the Mojo Android FYI bot.

Bug:  849746 
Change-Id: I906be084207610209ca6936994e28ce863ad1f15
Reviewed-on: https://chromium-review.googlesource.com/1090075
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566811}
[modify] https://crrev.com/7732289c78c3fad9970a6f0dc25519c3e57aa294/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/7732289c78c3fad9970a6f0dc25519c3e57aa294/testing/buildbot/test_suites.pyl

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b65b23ccccc3bb2d62e0814bea07c562c81392cc

commit b65b23ccccc3bb2d62e0814bea07c562c81392cc
Author: jonross <jonross@chromium.org>
Date: Tue Jun 19 19:29:22 2018

Update Mojo Android FYI Viz config

Currently all viz and surface sync tests on the Mojo Android FYI bot are hitting shard timeouts.

This updates the tests to use filter lists, to remove tests that were causing the shards to timeout.
This also remove viz_content_unittests as I'm currently seeing infra failures from it. It will require local debugging.

TEST=surface_sync_content_browsertest, viz_content_browsertests

Bug:  849746 
Change-Id: I237aab39e1c4a016584940fa0362a39db4be3434
Reviewed-on: https://chromium-review.googlesource.com/1102699
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568567}
[modify] https://crrev.com/b65b23ccccc3bb2d62e0814bea07c562c81392cc/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/b65b23ccccc3bb2d62e0814bea07c562c81392cc/testing/buildbot/filters/BUILD.gn
[add] https://crrev.com/b65b23ccccc3bb2d62e0814bea07c562c81392cc/testing/buildbot/filters/surface_sync.content_browsertests.filter
[add] https://crrev.com/b65b23ccccc3bb2d62e0814bea07c562c81392cc/testing/buildbot/filters/viz.android.content_browsertests.filter
[modify] https://crrev.com/b65b23ccccc3bb2d62e0814bea07c562c81392cc/testing/buildbot/test_suites.pyl

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02a9ea694fadb12a770389b50ebbb0b164e29501

commit 02a9ea694fadb12a770389b50ebbb0b164e29501
Author: jonross <jonross@chromium.org>
Date: Wed Jun 20 13:03:06 2018

Update Android SurfaceSync and Viz filters

More flaking tests on Android in surface_sync_content_browsertests, and
viz_content_browsertests. This disables them.

TBR=fsamuel@chromium.org
TEST=viz_content_browsertests, surface_sync_content_browsertests

Bug:  849746 
Change-Id: I753452ea85d342fdb6bfc4408fb38817f8252d19
Reviewed-on: https://chromium-review.googlesource.com/1107839
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568809}
[modify] https://crrev.com/02a9ea694fadb12a770389b50ebbb0b164e29501/testing/buildbot/filters/surface_sync.content_browsertests.filter
[modify] https://crrev.com/02a9ea694fadb12a770389b50ebbb0b164e29501/testing/buildbot/filters/viz.android.content_browsertests.filter

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ea21191bbb5c39baae9eda7245f500093a2527f

commit 6ea21191bbb5c39baae9eda7245f500093a2527f
Author: jonross <jonross@chromium.org>
Date: Thu Jun 21 13:26:07 2018

Update Viz Android FYI Filters

Locally the SitePerProcessBrowserTests were working with surface sync on Android.
This updates the filter to only block SitePerProcessHitTests instead.

Also updates the Viz filter to remove the Mac only failures.

TBR=fsamuel@chromium.org
TEST=surface_sync_content_browsertests, viz_content_browsertests

Bug:  849746 
Change-Id: Id6fca3c0ff2ad31a2ee0051b2b889fb80d0c51e3
Reviewed-on: https://chromium-review.googlesource.com/1110038
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569240}
[modify] https://crrev.com/6ea21191bbb5c39baae9eda7245f500093a2527f/testing/buildbot/filters/surface_sync.content_browsertests.filter
[modify] https://crrev.com/6ea21191bbb5c39baae9eda7245f500093a2527f/testing/buildbot/filters/viz.android.content_browsertests.filter

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fac28b596d09e9246f474b66136b319b5f4ba4f

commit 0fac28b596d09e9246f474b66136b319b5f4ba4f
Author: jonross <jonross@chromium.org>
Date: Fri Jun 22 12:25:09 2018

Update Viz Android Filters from Triage

We've analyzed the existing errors in both surface sync and viz content_browsertests.
This updates the filters used on the FYI bot.

TEST=surface_sync_content_browsertests, viz_content_browsertests
TBR=fsamuel@chromium.org

Bug:  849746 
Change-Id: Id081a42d959ab2c97d98e56089320998d63bebdf
Reviewed-on: https://chromium-review.googlesource.com/1110027
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569584}
[modify] https://crrev.com/0fac28b596d09e9246f474b66136b319b5f4ba4f/testing/buildbot/filters/surface_sync.content_browsertests.filter
[modify] https://crrev.com/0fac28b596d09e9246f474b66136b319b5f4ba4f/testing/buildbot/filters/viz.android.content_browsertests.filter

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e76222411d0989ce23082bc452e15a7961a11974

commit e76222411d0989ce23082bc452e15a7961a11974
Author: jonross <jonross@chromium.org>
Date: Sun Jun 24 13:47:21 2018

Update Viz Android and Surface Sync FYI Filters
Updating testing filters for the Mojo Android FYI bot.

Surface Sync is a new consistent failure.
Viz Android are failures that occur on all Viz platforms, and are now confirmed
on Android as well.

TBR=fsamuel@chromium.org
TEST=surface_sync_content_browsertests, viz_content_browsertests

Bug:  849746 
Change-Id: Id1ba7e03aa28f28b21e59c694a7cb6f39b9d843c
Reviewed-on: https://chromium-review.googlesource.com/1112966
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569924}
[modify] https://crrev.com/e76222411d0989ce23082bc452e15a7961a11974/testing/buildbot/filters/surface_sync.content_browsertests.filter
[modify] https://crrev.com/e76222411d0989ce23082bc452e15a7961a11974/testing/buildbot/filters/viz.android.content_browsertests.filter

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9458b76627b27134fb892ef88d89cb27575a261e

commit 9458b76627b27134fb892ef88d89cb27575a261e
Author: Jonathan Ross <jonross@chromium.org>
Date: Fri Jul 20 21:53:52 2018

Update Viz Android Filter

Some tests which were in general failing for Viz have been fixed.
However it was missed re-enabling them on the Android filter.
This updates the filter accordingly.

TBR=fsamuel@chromium.org
TEST=viz_content_browsertests
SitePerProcessHitTestBrowserTest.CrossProcessMouseEnterAndLeaveTest*
SitePerProcessHitTestBrowserTest.CrossProcessMouseCapture*
SitePerProcessHitTestBrowserTest.HitTestStaleDataDeletedView*
SitePerProcessHitTestBrowserTest.RootConsumesScrollDuringOverscrollGesture*
Bug:849746

Change-Id: I9b487e0699284b5b61265ffcfb3b6a664a2f5f08
Reviewed-on: https://chromium-review.googlesource.com/1145410
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577000}
[modify] https://crrev.com/9458b76627b27134fb892ef88d89cb27575a261e/testing/buildbot/filters/viz.android.content_browsertests.filter

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9da724b1a476d0195990c6697a4eb9b79c054b8

commit e9da724b1a476d0195990c6697a4eb9b79c054b8
Author: jonross <jonross@chromium.org>
Date: Fri Aug 03 23:44:12 2018

Enable Viz Android tests on CQ

The viz_fyi_android_gtest suite has stabilized. With the flakes seen being also
seen on general android.

This renames the config to viz_android_gtests and adds it to the general
chromium_android_gtests group to expand coverage.

TEST=viz_content_browsertests, surface_sync_content_browsertests

Bug:  849746 
Change-Id: I63087db31fd9d834a0b98c3a7053577a097b92b4
Reviewed-on: https://chromium-review.googlesource.com/1133303
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580706}
[modify] https://crrev.com/e9da724b1a476d0195990c6697a4eb9b79c054b8/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/e9da724b1a476d0195990c6697a4eb9b79c054b8/testing/buildbot/chromium.android.json
[modify] https://crrev.com/e9da724b1a476d0195990c6697a4eb9b79c054b8/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/e9da724b1a476d0195990c6697a4eb9b79c054b8/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/e9da724b1a476d0195990c6697a4eb9b79c054b8/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/e9da724b1a476d0195990c6697a4eb9b79c054b8/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/e9da724b1a476d0195990c6697a4eb9b79c054b8/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/e9da724b1a476d0195990c6697a4eb9b79c054b8/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/e9da724b1a476d0195990c6697a4eb9b79c054b8/testing/buildbot/chromium.win.json
[modify] https://crrev.com/e9da724b1a476d0195990c6697a4eb9b79c054b8/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/e9da724b1a476d0195990c6697a4eb9b79c054b8/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/e9da724b1a476d0195990c6697a4eb9b79c054b8/testing/buildbot/waterfalls.pyl

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3e132bf696744532f419447ad9c8e5bb8481be2

commit f3e132bf696744532f419447ad9c8e5bb8481be2
Author: jonross <jonross@chromium.org>
Date: Mon Aug 27 18:59:49 2018

Remove Surface Sync tests from Android Bots

The last bots running surface_sync_content_browsertests were Android. However
Surface Sync is now on by default on Android, so these tests are redundant.

This removes the config from test_suites, and all Android bots.

TEST=surface_sync_content_browsertests

Bug:  849746 
Change-Id: Ie9de3fabaaee8a694acb5ce48c8ff2a9c58e0e42
Reviewed-on: https://chromium-review.googlesource.com/1190125
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586353}
[modify] https://crrev.com/f3e132bf696744532f419447ad9c8e5bb8481be2/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/f3e132bf696744532f419447ad9c8e5bb8481be2/testing/buildbot/chromium.android.json
[modify] https://crrev.com/f3e132bf696744532f419447ad9c8e5bb8481be2/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/f3e132bf696744532f419447ad9c8e5bb8481be2/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/f3e132bf696744532f419447ad9c8e5bb8481be2/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/f3e132bf696744532f419447ad9c8e5bb8481be2/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/f3e132bf696744532f419447ad9c8e5bb8481be2/testing/buildbot/test_suites.pyl

Status: Fixed (was: Started)
Field trial completes our need for coverage

Sign in to add a comment