New issue
Advanced search Search tips

Issue 849737 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[mojo blob URLs] BlobURLStoreImpl::Register should be more performant

Project Member Reported by mek@chromium.org, Jun 5 2018

Issue description

Change blob URL registry code so that BlobURLStoreImpl::Register can reply to the (sync) mojo call ASAP, rather than having to first block on looking up the UUID of the blob.

Will probably require some work on refactoring how the blob URL mapping is maintained, but there is no reason to block the sync IPC on actually looking up the uuid from the BlobPtr (in fact we might not need to ever resolve the UUID, and can just store url->BlobPtr mappings once all blob URL related work goes through to mojo interface).

(this is one cause for the timeouts in virtual/mojo-blob-urls/external/wpt/FileAPI/url/sandboxed-iframe.html)
 

Comment 1 by mek@chromium.org, Jun 8 2018

Summary: [mojo blob URLs] BlobURLStoreImpl::Register should be more performant (was: [mojo blob URLs])
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/079a988ab5daf52e9541dd3041f4cf477fa8aa7b

commit 079a988ab5daf52e9541dd3041f4cf477fa8aa7b
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Fri Jun 08 22:05:52 2018

Mark a couple of blob URL tests as timing out with mojo blob URLs.

The Mojo Blob URL interface does too much work during the sync IPC,
resulting in these tests taking twice as long as with the non-mojo API.

Bug:  850841 , 849737
Change-Id: I6290928a297ddd30227673ddb6b9c4ab78fac5be
Reviewed-on: https://chromium-review.googlesource.com/1093304
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565756}
[modify] https://crrev.com/079a988ab5daf52e9541dd3041f4cf477fa8aa7b/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment