New issue
Advanced search Search tips

Issue 849735 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Increase touch latency metrics version due to rebucketing

Project Member Reported by altimin@chromium.org, Jun 5 2018

Issue description

Some Event.Latency metrics (including Event.Latency.ScrollBegin.Touch.TimeToScrollUpdateSwapBegin2) were rebucketed recently, which presents a problem for using them in Finch experiments. We need to increase the version for these histograms to allow them to be used in Finch again.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a99d9e4e64e3528b647c05b53ca5da9c1f5e8a75

commit a99d9e4e64e3528b647c05b53ca5da9c1f5e8a75
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Wed Jun 06 14:41:24 2018

Increase the version of scrolling metrics

Due to a rebucketing change the previous version
lost its value. This CL adds the new metrics with
the broader range of buckets up to 2 seconds to
accomodate for slower devices.

Bug:  849735 
Change-Id: Ie683cf1bfc510da618e989eae7ca027497322da9
Reviewed-on: https://chromium-review.googlesource.com/1087529
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564884}
[modify] https://crrev.com/a99d9e4e64e3528b647c05b53ca5da9c1f5e8a75/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/a99d9e4e64e3528b647c05b53ca5da9c1f5e8a75/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/a99d9e4e64e3528b647c05b53ca5da9c1f5e8a75/ui/latency/latency_tracker.cc

Components: Blink>Input
Status: Fixed (was: Assigned)
I'm going to modify our chirp alerts as well accordingly.
Labels: Merge-Request-68
Status: Started (was: Fixed)
It would be great to merge the v3 version of the histogram to M68 as well, so that there's a usable metric on the Beta channel.
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 11 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Re #3: The current v2 in the Beta channel is usable if you look only at data from M68 Beta, so I don't think that's necessary.
Please specify which OS's this is impacting, so merge request can be appropriately routed. 
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Labels: -Merge-Review-68 Merge-Approved-68
Approving merge for M68. Branch:3440
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e33fd697e112604830ceadb6e8b996bb523616b1

commit e33fd697e112604830ceadb6e8b996bb523616b1
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Tue Jun 12 20:36:28 2018

Increase the maximum of scrolling latencies to 5s

Add a new version of scrolling metrics with even
higher maximum to accomodate for low end devices.

Bug:  849735 
Change-Id: I29296c7a2ce6fcfad831b9f5fe81a86cdb759e28
Reviewed-on: https://chromium-review.googlesource.com/1095416
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566556}
[modify] https://crrev.com/e33fd697e112604830ceadb6e8b996bb523616b1/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/e33fd697e112604830ceadb6e8b996bb523616b1/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/e33fd697e112604830ceadb6e8b996bb523616b1/ui/latency/latency_histogram_macros.h
[modify] https://crrev.com/e33fd697e112604830ceadb6e8b996bb523616b1/ui/latency/latency_tracker.cc

Project Member

Comment 10 by sheriffbot@chromium.org, Jun 18 2018

Cc: isherman@chromium.org abdulsyed@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 18 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13d132baf571336eb922f678e94dfe8db3c40af3

commit 13d132baf571336eb922f678e94dfe8db3c40af3
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Mon Jun 18 20:31:13 2018

Increase the version of scrolling metrics

Due to a rebucketing change the previous version
lost its value. This CL adds the new metrics with
the broader range of buckets up to 2 seconds to
accomodate for slower devices.

Bug:  849735 
Change-Id: Ie683cf1bfc510da618e989eae7ca027497322da9
Reviewed-on: https://chromium-review.googlesource.com/1087529
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564884}(cherry picked from commit a99d9e4e64e3528b647c05b53ca5da9c1f5e8a75)
Reviewed-on: https://chromium-review.googlesource.com/1104764
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#414}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/13d132baf571336eb922f678e94dfe8db3c40af3/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/13d132baf571336eb922f678e94dfe8db3c40af3/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/13d132baf571336eb922f678e94dfe8db3c40af3/ui/latency/latency_tracker.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ace7e11dc26688fbd0f8af164153ede9d50254f3

commit ace7e11dc26688fbd0f8af164153ede9d50254f3
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Tue Jun 19 15:42:20 2018

Increase the maximum of scrolling latencies to 5s

Add a new version of scrolling metrics with even
higher maximum to accomodate for low end devices.

TBR=nzolghadr@chromium.org

(cherry picked from commit e33fd697e112604830ceadb6e8b996bb523616b1)
(cherry picked from commit 8f453d9e78042b98e34ae3efb82fd3336c45c4d9)

Bug:  849735 
Change-Id: I29296c7a2ce6fcfad831b9f5fe81a86cdb759e28
Reviewed-on: https://chromium-review.googlesource.com/1095416
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566556}
Reviewed-on: https://chromium-review.googlesource.com/1106280
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#443}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/ace7e11dc26688fbd0f8af164153ede9d50254f3/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/ace7e11dc26688fbd0f8af164153ede9d50254f3/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/ace7e11dc26688fbd0f8af164153ede9d50254f3/ui/latency/latency_histogram_macros.h
[modify] https://crrev.com/ace7e11dc26688fbd0f8af164153ede9d50254f3/ui/latency/latency_tracker.cc

Status: Fixed (was: Started)

Sign in to add a comment