New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 849719 link

Starred by 1 user
Status: Started
Owner:
sadrul@chromium.org
Cc:
nzolghadr@chromium.org
█ briander...@chromium.org
tdres...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

LatencyInfo: Remove unnecessary components

Project Member Reported by sadrul@chromium.org, Jun 5 2018 
There are some unused components in LatencyInfo (e.g. INPUT_EVENT_LATENCY_GENERATE_SCROLL_UPDATE_FROM_MOUSE_WHEEL). These should be removed and the associated code cleaned up.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a63a0cd385a8f5dcb14d936dbcff7e3da0f8c2f

commit 4a63a0cd385a8f5dcb14d936dbcff7e3da0f8c2f
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Tue Jun 05 16:55:13 2018

latency: Remove an unused LatencyComponentType.

INPUT_EVENT_LATENCY_GENERATE_SCROLL_UPDATE_FROM_MOUSE_WHEEL is only ever
set on ui::LatencyInfo, but never actually consumed for anything. So
remove this.

BUG=849719

Change-Id: Iad107511dac0a3ba210b403e28452f916630523d
Reviewed-on: https://chromium-review.googlesource.com/1087038
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564543}
[modify] https://crrev.com/4a63a0cd385a8f5dcb14d936dbcff7e3da0f8c2f/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/4a63a0cd385a8f5dcb14d936dbcff7e3da0f8c2f/ui/latency/latency_info.cc
[modify] https://crrev.com/4a63a0cd385a8f5dcb14d936dbcff7e3da0f8c2f/ui/latency/latency_info.h
[modify] https://crrev.com/4a63a0cd385a8f5dcb14d936dbcff7e3da0f8c2f/ui/latency/mojo/latency_info.mojom
[modify] https://crrev.com/4a63a0cd385a8f5dcb14d936dbcff7e3da0f8c2f/ui/latency/mojo/latency_info_struct_traits.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49ebaf04fa5ef19b6fc86583d54364d8e7f8ef52

commit 49ebaf04fa5ef19b6fc86583d54364d8e7f8ef52
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Sat Jun 09 04:30:20 2018

latency: Remove unused LatencyInfo::RemoveLatency().

RemoveLatency() is no longer used, so it is removed.

BUG=849719

Change-Id: I1e3b9338f7e70d4e31e0e2bb2cae96966592210e
Reviewed-on: https://chromium-review.googlesource.com/1092631
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565858}
[modify] https://crrev.com/49ebaf04fa5ef19b6fc86583d54364d8e7f8ef52/ui/latency/latency_info.cc
[modify] https://crrev.com/49ebaf04fa5ef19b6fc86583d54364d8e7f8ef52/ui/latency/latency_info.h
[modify] https://crrev.com/49ebaf04fa5ef19b6fc86583d54364d8e7f8ef52/ui/latency/latency_info_unittest.cc

Comment 3 by npm@chromium.org, Sep 25 

Can this be marked as fixed now?

Comment 4 by maxlg@chromium.org, Jan 15 

Ping Sadrul, is it fixed?

Comment 5 by tdres...@chromium.org, Jan 15

Components: -Speed>Metrics
►

Sign in to add a comment