--print-wasm-code not effective any more |
|||
Issue descriptionThe --print-wasm-code does not print wasm code any more. Bisects to f6fbbc0c5130edcd273c8eb955eecb527b364a5a ([wasm] Move {export_wrappers} field to {WasmModuleObject}.).
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/dfb96b52342dab5922ac5052bd8ae0e3e22b053c commit dfb96b52342dab5922ac5052bd8ae0e3e22b053c Author: Michael Starzinger <mstarzinger@chromium.org> Date: Tue Jun 05 18:21:24 2018 [wasm] Fix broken --print-wasm-code for sync compiles. R=clemensh@chromium.org BUG= chromium:849713 Change-Id: I3af8a654c32f8eb77dcdd3dffeb2dd826b90db9d Reviewed-on: https://chromium-review.googlesource.com/1087451 Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53533} [modify] https://crrev.com/dfb96b52342dab5922ac5052bd8ae0e3e22b053c/src/wasm/module-compiler.cc [modify] https://crrev.com/dfb96b52342dab5922ac5052bd8ae0e3e22b053c/src/wasm/wasm-code-manager.cc [modify] https://crrev.com/dfb96b52342dab5922ac5052bd8ae0e3e22b053c/src/wasm/wasm-objects.cc [modify] https://crrev.com/dfb96b52342dab5922ac5052bd8ae0e3e22b053c/src/wasm/wasm-serialization.cc
,
Jun 5 2018
The change in comment #2 should fix the issue. However the --print-wasm-code functionality really should be made completely independent of logging and profiling because its main intended uses is for debugging purposes and it should be done rock-solid in WasmCodeManager when new code is added. Hence I'll leave this issue open as a tracking issue, but with lower priority.
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/fd047dde53d4c94616bb107251fd9556873deb6a commit fd047dde53d4c94616bb107251fd9556873deb6a Author: Michael Starzinger <mstarzinger@chromium.org> Date: Wed Jun 06 12:04:01 2018 [wasm] Simplify --print-wasm-code to print earlier. This makes sure {WasmCode} object are printed right after they have been added to a {NativeModule} instead of waiting until the module is done. This way debug output can be inspected as early as possible and works even when there are issues later before the module is finished. R=herhut@chromium.org BUG= chromium:849713 Change-Id: Icced39cfaad7c033de569fbec21c26506f5796a6 Reviewed-on: https://chromium-review.googlesource.com/1088614 Reviewed-by: Stephan Herhut <herhut@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53549} [modify] https://crrev.com/fd047dde53d4c94616bb107251fd9556873deb6a/src/compiler/pipeline.cc [modify] https://crrev.com/fd047dde53d4c94616bb107251fd9556873deb6a/src/wasm/wasm-code-manager.cc [modify] https://crrev.com/fd047dde53d4c94616bb107251fd9556873deb6a/src/wasm/wasm-serialization.cc
,
Jun 6 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mstarzinger@chromium.org
, Jun 5 2018