New issue
Advanced search Search tips

Issue 849710 link

Starred by 1 user
Status: Assigned
Owner:
pmarko@chromium.org
Cc:
r...@chromium.org
alemate@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Move WebviewClientCertsLoginTest.ClientCertRequestedInOtherWebView to signin screen tests

Project Member Reported by steve...@chromium.org, Jun 5 2018 
WebviewClientCertsLoginTest.ClientCertRequestedInOtherWebView specifically tests behavior in the signin screen.

Currently the test is based on deprecated UI and needs re-factoring.

We should move this test to a signin screen integration test and update it.

In the meanwhile the existing test is being DISABLED since the UI it depends on is being removed.

Comment 1 by pmarko@chromium.org, Jun 5 2018 

Another option would be to not actually do the test in another webview as its name suggests, but only pretending to ChromeContentBrowserClient that the sign-in webview is not in fact the sign-in webview by making |SigninPartitionManager::IsCurrentSigninStoragePartition| return false during the test, and then verifying that no client certs are exposed in the context of the webview.

I'll investigate this option and if it seems viable will send a CL doing that.

Comment 2 by zalcorn@chromium.org, Nov 9

Components: -UI>SignIn
Labels: -Pri-1 Pri-3
<triage> Dropping priority to 3 as there is no target milestone. Please assign a target milestone if this is a P1 or P2 bug </triage>
►

Sign in to add a comment