New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849709 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 732555



Sign in to add a comment

Handle fallback surfaces in Android OOP-D

Project Member Reported by ericrk@chromium.org, Jun 5 2018

Issue description

We currently don't set up fallback surfaces for Viz / OOP-D on Android. See compositor_impl_android: https://cs.chromium.org/chromium/src/content/browser/renderer_host/compositor_impl_android.cc?rcl=549ffb1a7145988316fcd1a8e603557186d81edc&l=1127
 
Is anyone working on this ? I can investigate if it helps. 

Comment 2 by samans@chromium.org, Jun 11 2018

I actually don't think anything has to be done in CompositorImpl. The convention is that the parent updates the fallback SurfaceId of the child when the child activates, but CompositorImpl doesn't have a parent. ui::Compositor also doesn't do anything in OnFirstSurfaceActivation and everything works fine.

https://cs.chromium.org/chromium/src/ui/compositor/compositor.cc?rcl=95670db5fbc28116e19d00294b777ab2423fbf8f&l=634

Comment 3 by samans@chromium.org, Jun 12 2018

I figured out what the problem is. GlOutputSurface does not call CommitOverlayPlanes in SwapBuffers. I'll send a fix tomorrow.

Comment 4 by samans@chromium.org, Jun 12 2018

Owner: samans@chromium.org
Status: Started (was: Available)
I'll send a CL to get rid of the code in OnFirstSurfaceActivation and will mark this bug as fixed afterwards.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb67bf56b4b5d4cb0a32b8376eee5e740db220d3

commit bb67bf56b4b5d4cb0a32b8376eee5e740db220d3
Author: Saman Sami <samans@chromium.org>
Date: Wed Jun 13 16:53:00 2018

Android/viz: Don't allocate a new LocalSurfaceId after each activation

Currently CompositorImpl allocates a new LocalSurfaceId every time its
previous surface activates. This was introduced because
DelegatedFrameHostAndroid did not properly set the fallback SurfaceId
but that's not the case anymore.

Bug:  849709 
Change-Id: I6dec507a968aa6ceee7fe3f05c68169bc0c37198
Reviewed-on: https://chromium-review.googlesource.com/1099179
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566875}
[modify] https://crrev.com/bb67bf56b4b5d4cb0a32b8376eee5e740db220d3/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/bb67bf56b4b5d4cb0a32b8376eee5e740db220d3/content/browser/renderer_host/compositor_impl_android.h

Comment 6 by samans@chromium.org, Jun 13 2018

Status: Fixed (was: Started)

Sign in to add a comment