New issue
Advanced search Search tips

Issue 849704 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Incorrect zoom bubble reuse for extension initiated zoom changes

Project Member Reported by mcnee@chromium.org, Jun 5 2018

Issue description

Chrome Version: 69.0.3450.0

What steps will reproduce the problem?
(1) Install an extension that uses the tabs zoom API such as "Tabs Zoom API Demo" ( https://developer.chrome.com/extensions/samples#search:tabs%20zoom%20api%20demo )
(2) Zoom a web page via the extension
(3) Observe that the zoom bubble appears and attributes the zoom change to the extension
(4) Before the bubble closes, zoom again via the extension
(5) Observe that the zoom bubble is closed and a new bubble is created
(6) Before the bubble closes, close the extension's popup and zoom the page manually (Ctrl-+)
(7) Observe that the existing zoom bubble is reused for the manual zoom change

What is the expected result?
If an extension initiated zoom opens the zoom bubble, a subsequent zoom by the same extension should be able to reuse the zoom bubble, since the attribution is the same. Also, if a manual zoom occurs while a zoom bubble attributed to an extension is showing, the zoom bubble should not be reused.

What happens instead?
Step 5: A new zoom bubble is created for each extension initiated zoom even though a bubble with the correct attribution is already showing.
Step 7: A manual zoom is incorrectly attributed to an extension.
 
Owner: mcnee@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db1b9c39beb36f103ad1034346c645f3d502aaa7

commit db1b9c39beb36f103ad1034346c645f3d502aaa7
Author: Kevin McNee <mcnee@chromium.org>
Date: Mon Jul 09 20:08:52 2018

Have intuitive reuse of the zoom bubble for extension initiated zoom changes

The current logic for reusing the zoom bubble for extensions
1) prevents an extension initiated zoom change from reusing the zoom
bubble even when the bubble is showing for a previous zoom change by the
same extension, and
2) attributes a user initiated zoom to an extension if the extension
recently initiated a zoom change.

The logic for reuse is now essentially, allow reuse if the attribution
hasn't changed.

Bug:  849704 
Change-Id: Ia4935fa84e30ab263772500f7ca566c0f5fc29be
Reviewed-on: https://chromium-review.googlesource.com/1124945
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573423}
[modify] https://crrev.com/db1b9c39beb36f103ad1034346c645f3d502aaa7/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
[modify] https://crrev.com/db1b9c39beb36f103ad1034346c645f3d502aaa7/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment