New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849695 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Remove blink side legacy use counter histograms

Project Member Reported by loonyb...@chromium.org, Jun 5 2018

Issue description

Now that the browser side histograms are replacing the flawed blink side histograms. We should remove all the histograms from the blink side.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/486ead8398efa5552e0137cd8ee3fc9a5280c6fc

commit 486ead8398efa5552e0137cd8ee3fc9a5280c6fc
Author: Luna Lu <loonybear@chromium.org>
Date: Thu Jun 14 14:44:56 2018

Remove legacy features histogram from blink

Tests for counting features are removed from the blink side because
there are browser side testing them, please see:
chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Tests for frame fetch context is removed, but there's still test
coverage in
chromium/src/chrome/browser/client_hints/client_hints_browsertest.cc

Tests for blink side use counter dropping ntp activities is no longer
needed as blink side use counter is being removed.

TBR: nhiroki@chromium.org
Bug:  849695 ,  790957 
Change-Id: I32b0d01b768c7043fb01f2329cc089049126ed2b
Reviewed-on: https://chromium-review.googlesource.com/1087045
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567259}
[modify] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/content/browser/service_worker/service_worker_browsertest.cc
[add] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/runtime/runtime-evaluate-silent-expected.txt
[add] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/runtime/runtime-evaluate-silent.js
[modify] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/third_party/blink/renderer/core/frame/use_counter.cc
[modify] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/third_party/blink/renderer/core/frame/use_counter_test.cc
[modify] https://crrev.com/486ead8398efa5552e0137cd8ee3fc9a5280c6fc/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc

Status: Fixed (was: Started)

Sign in to add a comment