toggle-class-with-state-source-buffer.html consistently fails on ToTMac |
||
Issue descriptionhttps://ci.chromium.org/buildbot/chromium.clang/ToTMac/ https://ci.chromium.org/buildbot/chromium.clang/ToTMac/1708 https://test-results.appspot.com/data/layout_results/ToTMac/1708/layout-test-results/results.html This is a testharness.js-based test. FAIL Test that player buffering is reflected in CSS classes assert_true: Controls should have class: state-buffering expected true got false Harness: the test ran to completion. Test timed out. (4.7s) for the regular version at http/tests/media/controls/toggle-class-with-state-source-buffer.html ; Test timed out. (6.1s) for virtual/new-remote-playback-pipeline/http/tests/media/controls/toggle-class-with-state-source-buffer.html That bot does component builds, which might have performance implications.
,
Jun 6 2018
Sorry for the delay. I took a quick look and it's not obvious to me what's going wrong. However, in a fortunate stroke of luck, I'm currently in the middle of a CL which will completely remove our dependence on the state-buffering CSS class, so this test will essentially be meaningless (though it won't be immediately removed). Long story short, you can just add a testexpectation for this (or I can)
,
Jun 8 2018
Please update TestExpectations, if that's the right fix.
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c388dadb0f68479b7fc4431092bc7c2b04574f35 commit c388dadb0f68479b7fc4431092bc7c2b04574f35 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Jun 13 21:35:20 2018 Add TestExpectation for toggle-class-with-state-source-buffer Bug: 849694 Change-Id: I624f6a5c6a63a757055ce0616b50ab4bee0ba09d Reviewed-on: https://chromium-review.googlesource.com/1099690 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#566989} [modify] https://crrev.com/c388dadb0f68479b7fc4431092bc7c2b04574f35/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 26 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by thakis@chromium.org
, Jun 6 2018