New issue
Advanced search Search tips

Issue 849692 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 843511



Sign in to add a comment

realtimeanalyser-freq-data.html consistently fails on ToTMac

Project Member Reported by thakis@chromium.org, Jun 5 2018

Issue description

https://ci.chromium.org/buildbot/chromium.clang/ToTMac/

https://ci.chromium.org/buildbot/chromium.clang/ToTMac/1708

https://test-results.appspot.com/data/layout_results/ToTMac/1708/layout-test-results/results.html

...

FAIL X 256-point float FFT does not equal [-71.9521255493164,-53.59292984008789,-28.569778442382812,-19.748321533203125,-20.293832778930664,-29.871273040771484,-28.293466567993164,-24.988117218017578,-30.608078002929688,-35.813697814941406,-28.863449096679688,-30.543323516845703,-39.949012756347656,-33.431251525878906,-31.214340209960938,-37.93589401245117...] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":8.4828e-7}.
	Index	Actual			Expected		AbsError		RelError		Test threshold
	[112]	-7.3069831848144531e+1	-7.3069908142089844e+1	7.6293945312500000e-5	1.0441226388863220e-6	6.1983741678771966e-5
	Max AbsError of 7.6293945312500000e-5 at index of 112.
	Max RelError of 1.0441226388863220e-6 at index of 112.
 assert_true: expected true got false

...


FAIL < [8-order FFT] 1 out of 4 assertions were failed. assert_true: expected true got false
PASS > [9-order FFT] 
FAIL X 512-point float FFT does not equal [-99.73450469970703,-95.5750503540039,-90.04157257080078,-86.16575622558594,-82.12152099609375,-36.43669891357422,-22.325963973999023,-18.973859786987305,-24.65760040283203,-42.647552490234375,-83.69905853271484,-79.33260345458984,-39.85673141479492,-27.42534828186035,-25.198009490966797,-32.10475540161133...] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0.000023906}.
	Index	Actual			Expected		AbsError		RelError		Test threshold
	[121]	-9.6717956542968750e+1	-9.6715400695800781e+1	2.5558471679687500e-3	2.6426475510427373e-5	2.3120783690338135e-3
	Max AbsError of 2.5558471679687500e-3 at index of 121.
	Max RelError of 2.6426475510427373e-5 at index of 121.
 assert_true: expected true got false
PASS   Order: 9: Min FFT value is less than or equal to -100.
PASS   Order: 9: Max FFT value is greater than or equal to -30.
PASS   512-point byte FFT equals [0,16,36,50,65,231,255,255,255,208,59,75,219,255,255,247...] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
FAIL < [9-order FFT] 1 out of 4 assertions were failed. assert_true: expected true got false


...


FAIL # AUDIT TASK RUNNER FINISHED: 2 out of 12 tasks were failed. assert_true: expected true got false



Not sure if we can just bump up the threshold a bit since it's not all that far away?
 
Components: -Blink>Media>Audio
Owner: hongchan@chromium.org
Status: Started (was: Untriaged)

Comment 2 by rtoy@chromium.org, Jun 5 2018

Probably ok since we use macos's FFT routines.

I wonder what version of macos is being used for this bot.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3262c17cebe6539166dff92595d9024cebe3c03b

commit 3262c17cebe6539166dff92595d9024cebe3c03b
Author: Hongchan Choi <hongchan@chromium.org>
Date: Tue Jun 05 16:40:09 2018

Update error threshold values in realtimeanalyser-freq-data.html

The threshold in the test does not work anymore on the recent version of
MacOS (due to potential changes in FFT). This CL updates threshold
values accordingly.

Bug:  849692 
Change-Id: I92c4ec6b741a2aedbc09a1605a9750363e83cfc5
Reviewed-on: https://chromium-review.googlesource.com/1087128
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564537}
[modify] https://crrev.com/3262c17cebe6539166dff92595d9024cebe3c03b/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data.html

Status: Fixed (was: Started)

Sign in to add a comment