mac: build with 10.14 SDK |
|||
Issue descriptionTwo changes affect the chrome target: 1) The return type of dispatch_get_global_queue() has changed from dispatch_queue_t to dispatch_queue_global_t 2) ICCameraDeviceDelegate (implemented by ImageCaptureDevice) has a bunch of new methods
,
Jun 6 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd7154e0bb5f3ca9c72586da79f87d13afb5361a commit cd7154e0bb5f3ca9c72586da79f87d13afb5361a Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Jun 06 21:31:34 2018 mac: support build with 10.14 SDK Two changes are required: 1) Explicitly upcast the result of dispatch_get_global_queue() to a dispatch_queue_t*, since it changed to return dispatch_queue_global_t*; 2) Add empty implementations of the new methods on ICCameraDeviceDelegate for ImageCaptureDevice TBR=maxmorin@chromium.org Bug: 849689 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9448d1b07f8d4116ecdb0c75a7796472e51c6dd8 Reviewed-on: https://chromium-review.googlesource.com/1087169 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565040} [modify] https://crrev.com/cd7154e0bb5f3ca9c72586da79f87d13afb5361a/components/storage_monitor/image_capture_device.mm [modify] https://crrev.com/cd7154e0bb5f3ca9c72586da79f87d13afb5361a/media/audio/mac/coreaudio_dispatch_override.cc
,
Jun 7 2018
This is now done :) |
|||
►
Sign in to add a comment |
|||
Comment 1 by ellyjo...@chromium.org
, Jun 6 2018