New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 849686 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

LatencyInfo: merge the various terminate components

Project Member Reported by sadrul@chromium.org, Jun 5 2018

Issue description

There are currently five 'terminating components' for LatencyInfo:

INPUT_EVENT_LATENCY_TERMINATED_COMMIT_FAILED_COMPONENT
INPUT_EVENT_LATENCY_TERMINATED_COMMIT_NO_UPDATE_COMPONENT
INPUT_EVENT_LATENCY_TERMINATED_NO_SWAP_COMPONENT
INPUT_EVENT_LATENCY_TERMINATED_SWAP_FAILED_COMPONENT

These four components are set in various places, but they are never actually consumed or processed for anything. These components can be removed, and replaced instead with a LatencyInfo::Terminate() method to mark the termination.
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77c7c7dd4ba975b2ca237756ea8644931def128c

commit 77c7c7dd4ba975b2ca237756ea8644931def128c
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Tue Jun 05 20:28:14 2018

latency: Remove some of the terminal components.

The four terminal components are set in various places, but they are
are never actually consumed or processed for anything. These components
are removed, and replaced instead with a LatencyInfo::Terminate() method
to mark the termination. Removed components:
 INPUT_EVENT_LATENCY_TERMINATED_COMMIT_FAILED_COMPONENT
 INPUT_EVENT_LATENCY_TERMINATED_COMMIT_NO_UPDATE_COMPONENT
 INPUT_EVENT_LATENCY_TERMINATED_NO_SWAP_COMPONENT
 INPUT_EVENT_LATENCY_TERMINATED_SWAP_FAILED_COMPONENT

This also renames INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT to
just INPUT_EVENT_LATENCY_FRAME_SWAP_COMPONENT.

BUG= 849686 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If2fb7941c299393e77d8909e3681c6292e5c0e74
Reviewed-on: https://chromium-review.googlesource.com/1087292
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564642}
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/cc/trees/latency_info_swap_promise.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/components/viz/service/display/display.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/components/viz/service/display/output_surface.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/components/viz/service/display_embedder/software_output_surface.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/content/browser/compositor/software_browser_compositor_output_surface.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/content/browser/renderer_host/input/touchpad_pinch_event_queue.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/ui/latency/ipc/latency_info_param_traits_unittest.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/ui/latency/latency_info.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/ui/latency/latency_info.h
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/ui/latency/latency_tracker.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/ui/latency/mojo/latency_info.mojom
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/ui/latency/mojo/latency_info_struct_traits.cc
[modify] https://crrev.com/77c7c7dd4ba975b2ca237756ea8644931def128c/ui/latency/mojo/struct_traits_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment