Is High sorting on chrome://media-engagement/ doesn't work
Reported by
carbonat...@gmail.com,
Jun 5 2018
|
|||||
Issue description
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36
Steps to reproduce the problem:
1. open chrome://media-engagement/
2. sort by "Is High" tab in table
What is the expected behavior?
The "Is High" table column gets sorted.
What went wrong?
Everything in the table disappears.
Did this work before? N/A
Chrome version: 66.0.3359.181 Channel: n/a
OS Version: 10.0
Flash Version:
Javascript error:
util.js:27 Uncaught Error: Assertion failed: Unsupported sort key: isHigh
at assert (util.js:27)
at assertNotReached (util.js:60)
at compareTableItem (media-engagement.js:87)
at info.sort (media-engagement.js:60)
at Array.sort (chrome://media-engagement/native)
at sortInfo (media-engagement.js:59)
at renderTable (media-engagement.js:126)
at HTMLTableCellElement.headers.(chrome://media-engagement/anonymous function).addEventListener (chrome://media-engagement/media-engagement.js:177:7)
I guess the sort key is not defined. That can be fixed in lines 80-85 in chrome://media-engagement/media-engagement.js by adding the key:
if (sortKey == 'visits' || sortKey == 'mediaPlaybacks' ||
sortKey == 'lastMediaPlaybackTime' || sortKey == 'totalScore' ||
sortKey == 'audiblePlaybacks' || sortKey == 'significantPlaybacks' ||
sortKey == 'highScoreChanges' || sortKey == "isHigh") {
return val1 - val2;
}
,
Jun 6 2018
Thanks for filing the issue! Tried checking the issue on reported chrome version 66.0.3359.181 using Windows 10 with the below mentioned steps. 1. Launched chrome 2. Navigated to chrome://media-engagement/ Observed table with empty data, clicked on "Is High" still we didn't observe anything disappearing(...as there isn't any data in it). Attaching the screen cast of the same. @Reporter: Could you please have a look at the screen cast and let us know if we have missed anything in the process. Any further inputs from your end may be helpful.
,
Jun 11 2018
,
Jun 11 2018
,
Jul 3
This is fixed in 67.0.3378.0. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vamshi.kommuri@chromium.org
, Jun 5 2018