Persistent quota is not removed correctly |
||||
Issue descriptionChrome Version: 69.0.3450.0 OS: Linux What steps will reproduce the problem? (1) Request persistent filesystem storage (e.g. at https://demo.agektmr.com/storage/) (2) Delete cookies and site settings from Clear Browsing Data for all time What is the expected result? The persistent storage permission should be revoked either when the storage is removed or when site settings are deleted. Requesting quota again should show the permission dialog. What happens instead? Persistent storage is still granted. There seems to be another bug in BrowsingDataQuotaHelperImpl::RevokeHostQuotaOnIOThread that sets the quota to 0 when individual site data entries are deleted at chrome://settings/siteData but doesn't remove the row from HostQuotaTable. Can this just be changed to call QuotaDatabase::DeleteHostQuota instead of SetHostQuota? (btw, there is not a single caller of DeleteHostQuota)
,
Jun 5 2018
The second problem seems to be easy to fix so I created a CL: https://crrev.com/c/1087057
,
Jun 5 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66b08a086d2dc796ca8f4dc7628a7383449037aa commit 66b08a086d2dc796ca8f4dc7628a7383449037aa Author: Christian Dullweber <dullweber@chromium.org> Date: Wed Jun 06 08:21:04 2018 Remove quota if set to zero When site data is removed, persistent quota gets resetted to zero. Instead of keeping the origin in the database, we should just delete it to remove traces of browsing_data. Bug: 849677 Change-Id: Ice2282274012fe8d2cb65bbac0b328523e8ce666 Reviewed-on: https://chromium-review.googlesource.com/1087057 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#564821} [modify] https://crrev.com/66b08a086d2dc796ca8f4dc7628a7383449037aa/storage/browser/quota/quota_database.cc [modify] https://crrev.com/66b08a086d2dc796ca8f4dc7628a7383449037aa/storage/browser/quota/quota_database_unittest.cc
,
Jun 6 2018
The second part of this issue is fixed, now only sites that were explicitly granted persistent quota leave data on Disk when deleting with Clear Browsin Data. Will assign to me to decide how to handle these cases.
,
Jun 6 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dullweber@chromium.org
, Jun 5 2018