New issue
Advanced search Search tips

Issue 849676 link

Starred by 1 user
Status: Fixed
Owner:
justincohen@chromium.org
Closed: Jun 2018
Cc:
rsesek@chromium.org
thakis@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

sdk_info.py gives incorrect results for Xcode 10

Project Member Reported by ellyjo...@chromium.org, Jun 5 2018 
Xcode 9.4:

$ xcodebuild -version                                            
Xcode 9.4
Build version 9F1027a
$ python build/config/mac/sdk_info.py macosx                     
machine_os_build="17G31f"
sdk_build="17E189"
sdk_path="/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk"
sdk_platform_path="/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform"
sdk_version="10.13"
xcode_build="9F1027a"
xcode_version="0940"
xcode_version_int=940

Xcode 10.0:

$ xcodebuild -version                                                 
Xcode 10.0
Build version 10L176w
$ python build/config/mac/sdk_info.py macosx                          
machine_os_build="17G31f"
sdk_build="10.14"
sdk_path="/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk"
sdk_platform_path="/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform"
sdk_version="10.14"
xcode_build="10L176w"
xcode_version="0100"
xcode_version_int=100

Note that xcode_version and xcode_version_int are wrong.

Comment 1 by thakis@chromium.org, Jun 5 2018

Owner: justincohen@chromium.org
Status: Started (was: Assigned)
As mentioned in person earlier, the iOS folks are on it: https://chromium-review.googlesource.com/c/chromium/src/+/1086233

Comment 2 by ellyjo...@chromium.org, Jun 5 2018 

doh, thanks thakis :)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27f9cbd88beea37bda9d6b46dabec9cf5eb386f3

commit 27f9cbd88beea37bda9d6b46dabec9cf5eb386f3
Author: Justin Cohen <justincohen@google.com>
Date: Tue Jun 05 15:30:25 2018

[ios] Various build fixes for Xcode 10.

  * Removes IDEBundleInjection.framework from egtests.
  * Corrects the DTXcode generation function to handle leading '10'.
  * Fixes a main_application_delegate SDK change
  * Fixes a non-null SDK change in a net unittest.

Bug:  843234 ,  849676 
TBR: davidben@chromium.org
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6555bd396e4b4bb4d05822ee5867f878d7928c65
Reviewed-on: https://chromium-review.googlesource.com/1086233
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564512}
[modify] https://crrev.com/27f9cbd88beea37bda9d6b46dabec9cf5eb386f3/build/config/ios/rules.gni
[modify] https://crrev.com/27f9cbd88beea37bda9d6b46dabec9cf5eb386f3/build/config/mac/sdk_info.py
[modify] https://crrev.com/27f9cbd88beea37bda9d6b46dabec9cf5eb386f3/ios/chrome/app/main_application_delegate.mm
[modify] https://crrev.com/27f9cbd88beea37bda9d6b46dabec9cf5eb386f3/net/cert/cert_verify_proc_ios_unittest.cc

Comment 5 by justincohen@chromium.org, Jun 5 2018

Status: Fixed (was: Started)
►

Sign in to add a comment